RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1596954 - Does NetworkManager need CAP_SYS_ADMIN for iBFT?
Summary: Does NetworkManager need CAP_SYS_ADMIN for iBFT?
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: NetworkManager
Version: 7.6
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Lubomir Rintel
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-30 19:11 UTC by Thomas Haller
Modified: 2021-10-17 19:32 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-10-30 11:14:18 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:3207 0 None None None 2018-10-30 11:15:03 UTC

Description Thomas Haller 2018-06-30 19:11:06 UTC 
on rhel-7.3 (for example NetworkManager-1.4.0-20.el7_3), we give capability

  CapabilityBoundingSet=... CAP_SYS_ADMIN

in /usr/lib/systemd/system/NetworkManager.service .

This was done to fix bug 1371201. rhel-7.3 carried downstream patch 0011-ibft-cap-sys-admin-rh1371201.patch for that.



On rhel-7.4 and later, this capability is no longer present. I don't remember there was a bug/discussion about that, I think the patch was accidentally dropped for version 1:1.8.0-0.1.git20170215.1d40c5f4.


Open this bug, to investigate whether iBFT is working correctly on rhel-7.4 and newer, whether bug 1371201 resurfaced (or why not?), and whether we need this capability.

If we don't need CAP_SYS_ADMIN for iBFT, then the code comment at upstream https://cgit.freedesktop.org/NetworkManager/NetworkManager/tree/data/NetworkManager.service.in?id=b26efa5b680b45a1e6e8fcfb2f9ea996d8e28706#n19 should be adjusted.
Comment 2 Thomas Haller 2018-06-30 19:14:52 UTC 
TODO/hint: maybe rhel-7.4 does not require CAP_SYS_ADMIN to read iBFT related sysfs? See https://bugzilla.redhat.com/show_bug.cgi?id=1371201#c7
Comment 3 Beniamino Galvani 2018-07-09 09:25:03 UTC 
Tested on a fresh RHEL 7.5 installation, the iBFT plugin can't read the iBFT table:

 ibft: failed to read iscsiadm records: iBFT: /sbin/iscsiadm exited with error 21.  Message: 'iscsiadm: Could not get list of targets from firmware. (err 21) '

After enabling the CAP_SYS_ADMIN capability, NM is able to read the table:

 settings-connection[0x55b80f717360]: constructed (NMSIbftConnection)
 ibft: read connection 'iBFT eth0'
 ++ connection 'new connection' (0x55b80f717360/NMSIbftConnection/"802-3-ethernet"): [/org/freedesktop/NetworkManager/Settings/3]
 ++ connection                [ 0x55b80f786250 ]
 ++ connection.id             = 'iBFT eth0'
 ...
Comment 4 Lubomir Rintel 2018-08-14 15:43:47 UTC 
Re-applied this:

commit 0c8ef57c0ff58e977dd7ae4a8d9dc99ee1579330 (HEAD -> rhel-7.6, origin/rhel-7.6)
Author: Thomas Haller <thaller>
Date:   Fri Sep 2 16:13:58 2016 +0200

    ibft: grant required CAP_SYS_ADMIN capabilities (rh#1596954)
    
    [lrintel: re-apply this.]
    
    Resolves: #1596954
    Related: #1371201
Comment 7 errata-xmlrpc 2018-10-30 11:14:18 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3207
Note You need to log in before you can comment on or make changes to this bug.