Bug 1597417 - Review Request: python-pwntools - A CTF framework and exploit development library
Summary: Review Request: python-pwntools - A CTF framework and exploit development lib...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1594430 1594431
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-07-02 21:58 UTC by W. Michael Petullo
Modified: 2018-07-15 03:32 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-07-05 14:13:18 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description W. Michael Petullo 2018-07-02 21:58:45 UTC
Spec URL: https://www.flyn.org/SRPMS/python-pwntools.spec
SRPM URL: https://www.flyn.org/SRPMS/python-pwntools-3.12.0-1.fc28.src.rpm
Description:
Pwntools is a CTF framework and exploit development library. Written
in Python, it is designed for rapid prototyping and development, and
intended to make exploit writing as simple as possible.

Fedora Account System Username: mikep

Comment 1 Robert-André Mauchin 🐧 2018-07-03 16:42:45 UTC
 - Could you add a comment before the patch to explain what it does.

 - There's no tests provided so you can remove %check

 - Another issue is that you're using python2-tox which has been removed from Fedora. This is not really needed to use the library so you can safely remove it.


 - Install the docs:

BuildRequires:  python2-sphinx



%package doc
Summary:        pwntools documentation
%description doc
Documentation for pwntools




%build
%py2_build
# generate html docs 
PYTHONPATH=${PWD} sphinx-build-2 docs/source html
# remove the sphinx-build leftovers
rm -rf html/.{doctrees,buildinfo}



%files doc
%doc html
%license LICENSE-pwntools.txt


(might need other BR)

Comment 2 W. Michael Petullo 2018-07-03 22:04:05 UTC
Spec URL: https://www.flyn.org/SRPMS/python-pwntools.spec
SRPM URL: https://www.flyn.org/SRPMS/python-pwntools-3.12.0-1.fc28.src.rpm
Description:
Pwntools is a CTF framework and exploit development library. Written
in Python, it is designed for rapid prototyping and development, and
intended to make exploit writing as simple as possible.

Fedora Account System Username: mikep

Addressed comment #1. Statements to build documentation are present, but I commented them out because pwntools does not yet seem compatible with sphinx 1.7 as shipped by Fedora.

Comment 3 Robert-André Mauchin 🐧 2018-07-03 22:11:09 UTC
Package approved.

Comment 4 Gwyn Ciesla 2018-07-05 13:27:20 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pwntools

Comment 5 Fedora Update System 2018-07-05 14:08:42 UTC
python-pwntools-3.12.0-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-0b553b789e

Comment 6 Fedora Update System 2018-07-06 17:52:59 UTC
python-pwntools-3.12.0-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-0b553b789e

Comment 7 Fedora Update System 2018-07-15 03:32:01 UTC
python-pwntools-3.12.0-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.