Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1597731

Summary:	need 'shellcheck' in smoke.
Product:	[Community] GlusterFS	Reporter:	Amar Tumballi <atumball>
Component:	project-infrastructure	Assignee:	bugs <bugs>
Status:	CLOSED UPSTREAM	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	mainline	CC:	bugs, gluster-infra, jeff, srangana
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	Process-Automation
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-12 12:53:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Amar Tumballi 2018-07-03 14:21:47 UTC

# Description of problem:

Today, there is no validation for 'shell' scripts (present in the form of executable binary, files ending with `.sh`, or files ending with `.sh.in`).

Ideally, if any shell script files gets modified in the patch, that particular shell script should pass 'shellcheck' test. This should be a voting job.

Comment 1 Shyamsundar 2018-07-03 15:44:30 UTC

Ack! Extremely useful for obvious reasons (and as an aside, this is what helps me get my bash scripts working, considering my bash skills :) )

Comment 2 Nigel Babu 2018-10-04 14:00:16 UTC

How do we want to go about this?

There is a lot of errors at the moment. Do we want to tackle it by number? Or do we want to ignore the non-serious errors so this count is more manageable?

$ find . -name '*.sh' | xargs shellcheck | grep -c 'In'
1629

Comment 4 Worker Ant 2020-03-12 12:53:19 UTC

This bug is moved to https://github.com/gluster/project-infrastructure/issues/31, and will be tracked there from now on. Visit GitHub issues URL for further details