Bug 159792 - rpmbuild doesnt like -F1
rpmbuild doesnt like -F1
Product: Fedora
Classification: Fedora
Component: rpm (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Paul Nasrat
Mike McLean
Depends On:
  Show dependency treegraph
Reported: 2005-06-07 20:03 EDT by Dave Jones
Modified: 2015-01-04 17:20 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2006-02-12 11:15:08 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Dave Jones 2005-06-07 20:03:10 EDT
I'd like to force all patches in the kernel spec to apply with -F1, as I've had
patches that have applied with the default fuzz factor which have done
completely the wrong thing.

Currently, adding

%patch1 -p1 -F1

causes rpmbuild to break
Comment 1 Jeff Johnson 2005-06-08 05:31:56 EDT
Use patch directly then. E.g.
    %patch1 -p1 -F1
should be written as
    patch -p1 -F1 < %{PATCH1}

It's just a steenking script ...
Comment 2 Dave Jones 2005-06-08 23:33:35 EDT
That makes for awfully cluttered spec files when you have a lot of patches applied
Comment 3 Jeff Johnson 2005-06-08 23:42:11 EDT
So write a script that applies patches, add to the Source: list,
and run that script like
   Source123: mypatchapplier

It's just a steenking script ...
Comment 4 Jeff Johnson 2005-06-08 23:44:32 EDT
    sh %{SOURCE123}

And its's still a steenking script, just withou execute bits ;-)
Comment 5 Dave Jones 2005-06-08 23:51:38 EDT
That's a lot of hoop jumping to work around something that should be a trivial
change to rpmbuild.
Comment 6 Jeff Johnson 2005-06-09 00:11:06 EDT
Changing the source code to add an option is trivial.

Introducing an incompatibility in builds -- particularly for kernel --
forces a non-trivial deployment of rpm.

"Clutter" (at least by metric no. of bytes) can be addressed by writing a macro
something like
    %define mpF  patch -p1 -F1
to be used as
    %mpF < %PATCH1
to remove "clutter".
Comment 7 Jeff Johnson 2006-02-12 11:15:08 EST
I don't believe that adding -F1 to %patch in rpmbuild is a sound idea.

Note You need to log in before you can comment on or make changes to this bug.