Bug 1598698 - Review Request: elementary-terminal - The terminal of the 21st century
Summary: Review Request: elementary-terminal - The terminal of the 21st century
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PantheonDesktopPackageReviews
TreeView+ depends on / blocked
 
Reported: 2018-07-06 08:33 UTC by Fabio Valentini
Modified: 2018-07-06 16:52 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-07-06 16:52:21 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2018-07-06 08:33:58 UTC
Spec URL: https://decathorpe.fedorapeople.org/packages/elementary-terminal.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/elementary-terminal-0.5-1.fc28.src.rpm

Description:
A super lightweight, beautiful, and simple terminal. It's designed to be
setup with sane defaults and little to no configuration. It's just a
terminal, nothing more, nothing less.

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=28049883


NOTE: This package will obsolete pantheon-terminal, according to the new upstream naming. Please verify that the Obsoletes and Provides are correct for a renamed package.

Comment 1 Neal Gompa 2018-07-06 11:44:19 UTC
Review notes:
[x] Package follows guidelines for naming, structure, etc.
[x] Obsoletes and Provides are correct for replacing pantheon-terminal
[!] fish subpackage should be noarch

I expect you to fix the fish subpackage not being noarch on import.

PACKAGE APPROVED.

Comment 2 Fabio Valentini 2018-07-06 14:36:46 UTC
Thanks for the review, -fish subpackage will have "BuildArch: noarch" added before import.

Comment 3 Gwyn Ciesla 2018-07-06 14:46:30 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/elementary-terminal

Comment 4 Fabio Valentini 2018-07-06 16:52:21 UTC
Built for rawhide.

Not building for stable releases, because settings won't be migrated and dock items will be broken.

koji rawhide build task:
https://koji.fedoraproject.org/koji/taskinfo?taskID=28056086


Note You need to log in before you can comment on or make changes to this bug.