Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-spyder-kernels/python-spyder-kernels.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-spyder-kernels/python-spyder-kernels-1.0.1-1.fc28.src.rpm Description: This package provides jupyter kernels used by spyder on its IPython console. Fedora Account System Username: nonamedotc
I will take this review.
This package is APPROVED. The only issue is that the spec file given in the URL and the spec file inside the SRPM differ. Since the only difference is a comment which does not appear to make sense, my guess is that the spec file given in the URL is the correct one. Just be sure to commit the correct one when importing. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python2-spyder-kernels-1.0.1-1.fc29.noarch.rpm python3-spyder-kernels-1.0.1-1.fc29.noarch.rpm python-spyder-kernels-1.0.1-1.fc29.src.rpm python2-spyder-kernels.noarch: W: spelling-error Summary(en_US) Jupyter -> Jupiter, Junketeer python2-spyder-kernels.noarch: W: spelling-error %description -l en_US jupyter -> Jupiter python3-spyder-kernels.noarch: W: spelling-error Summary(en_US) Jupyter -> Jupiter, Junketeer python3-spyder-kernels.noarch: W: spelling-error %description -l en_US jupyter -> Jupiter python-spyder-kernels.src: W: spelling-error Summary(en_US) Jupyter -> Jupiter, Junketeer python-spyder-kernels.src: W: spelling-error %description -l en_US jupyter -> Jupiter 3 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- python2-spyder-kernels.noarch: W: spelling-error Summary(en_US) Jupyter -> Jupiter, Junketeer python2-spyder-kernels.noarch: W: spelling-error %description -l en_US jupyter -> Jupiter python2-spyder-kernels.noarch: W: invalid-url URL: https://github.com/spyder-ide/spyder-kernels <urlopen error [Errno -2] Name or service not known> python3-spyder-kernels.noarch: W: spelling-error Summary(en_US) Jupyter -> Jupiter, Junketeer python3-spyder-kernels.noarch: W: spelling-error %description -l en_US jupyter -> Jupiter python3-spyder-kernels.noarch: W: invalid-url URL: https://github.com/spyder-ide/spyder-kernels <urlopen error [Errno -2] Name or service not known> 2 packages and 0 specfiles checked; 0 errors, 6 warnings. Diff spec file in url and in SRPM --------------------------------- --- /home/jamesjer/1599026-python-spyder-kernels/srpm/python-spyder-kernels.spec 2018-07-07 21:57:44.447476482 -0600 +++ /home/jamesjer/1599026-python-spyder-kernels/srpm-unpacked/python-spyder-kernels.spec 2018-07-07 19:49:47.000000000 -0600 @@ -67,4 +67,6 @@ %install +# Must do the default python version install last because +# the scripts in /usr/bin are overwritten with every setup.py install. %py2_install %py3_install Requires -------- python2-spyder-kernels (rpmlib, GLIBC filtered): python(abi) python2dist(cloudpickle) python2dist(ipykernel) python3-spyder-kernels (rpmlib, GLIBC filtered): python(abi) python3dist(cloudpickle) python3dist(ipykernel) Provides -------- python2-spyder-kernels: python-spyder-kernels python2-spyder-kernels python2.7dist(spyder-kernels) python2dist(spyder-kernels) python3-spyder-kernels: python3-spyder-kernels python3.6dist(spyder-kernels) python3dist(spyder-kernels) Source checksums ---------------- https://files.pythonhosted.org/packages/source/s/spyder-kernels/spyder-kernels-1.0.1.tar.gz : CHECKSUM(SHA256) this package : ce4950684a3b82cd995700e2623c8749d1194823f990d6ed24711e7db4cf202a CHECKSUM(SHA256) upstream package : ce4950684a3b82cd995700e2623c8749d1194823f990d6ed24711e7db4cf202a Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1599026 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Thanks for the review. I forgot to run rpmbuild -bs after removing the comment. I have requested new-repo.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-spyder-kernels
Built on rawhide.