Bug 1600942

Description of problem:
In ceph-ansible version 2.2.x clients.yml had different syntax for adding client.name keys from syntax used in ceph-ansible version 3.0.x:

- ceph-ansible version 2.2.x
https://github.com/ceph/ceph-ansible/blob/v2.2.11/group_vars/clients.yml.sample
#keys:
#  - { name: client.test, value: "mon 'allow r' osd 'allow class-read object_prefix rbd_children, allow rwx pool=test'" }
# - { name: client.test2, value: "mon 'allow r' osd 'allow class-read object_prefix rbd_children, allow rwx pool=test2'" }

 ceph-ansible version 3.0.x (last shipped 3.0.39) :
https://github.com/ceph/ceph-ansible/blob/v3.0.39/group_vars/clients.yml.sample
#keys:
#  - { name: client.test, key: "ADD-KEYRING-HERE==", mon_cap: "allow r", osd_cap: "allow class-read object_prefix rbd_children, allow rwx pool=test", mode: "0600", acls: [] }
#  - { name: client.test2, key: "ADD-KEYRING-HERE==", mon_cap: "allow r", osd_cap: "allow class-read object_prefix rbd_children, allow rwx pool=test2", mode: "0600", acls: [] }

This should be documented to prevent the ansible-playbook fail with:
 {"msg": "The conditional check 'item.key == 'ADD-KEYRING-HERE=='' failed. The error was: error while evaluating conditional (item.key == 'ADD-KEYRING-HERE=='): 'dict object' has no attribute 'key'\n\nThe error appears to have been in '/usr/share/ceph-ansible/roles/ceph-client/tasks/pre_requisite.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: check keys has been filled in users.key variables\n  ^ here\n"}


The documentation change should be like:
For an update [clients] from RHCS 2.x deployed and managed with ceph-ansible version 2.2.x, check before the update the syntax change in group_vars/clients.yml file against default group_vars/clients.yml.sample

# ceph auth get-or-create client.test
 - the output is a key for client.test, add it to the "ADD-KEYRING-HERE==" in group_vars/clients.yml file and change the syntax like following:
------------
keys:
  - { name: client.test, key: "ADD-KEYRING-HERE==",  mon_cap: "allow r", osd_cap: "allow class-read object_prefix rbd_children, allow rwx pool=test", mode: "0600", acls: [] }

NOTE:
clients.yml changes are not mentioned in [1] , because it is not name  change, but syntax change:

[1] - https://access.redhat.com/documentation/en-us/red_hat_ceph_storage/3/html-single/installation_guide_for_red_hat_enterprise_linux/#changes-in-ansible-variables-between-version-2-and-3


Version-Release number of selected component (if applicable):
RHCS 3

How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info: