Created attachment 1459271 [details] Patch fixing the bug urrently, when running `iptables-restore --table=X`, where `X` is not the first table in the rules dump, the restore will fail when parsing the second table: - a lock is acquird when parsing the first table name - the table name does not match the parameter to `--table` so processing continues until the next table - when processing the next table a lock is acquired, which fails because a lock is already held This will release the lock as soon as it's decided the current table won't be used. With existing code: # iptables -L Chain INPUT (policy ACCEPT) target prot opt source destination Chain FORWARD (policy ACCEPT) target prot opt source destination Chain OUTPUT (policy ACCEPT) target prot opt source destination # iptables-restore <iptables.dump Another app is currently holding the xtables lock. Perhaps you want to use the -w option? # iptables -L Chain INPUT (policy ACCEPT) target prot opt source destination Chain FORWARD (policy ACCEPT) target prot opt source destination Chain OUTPUT (policy ACCEPT) target prot opt source destination With the change from the attached patch: # iptables -L Chain INPUT (policy ACCEPT) target prot opt source destination Chain FORWARD (policy ACCEPT) target prot opt source destination Chain OUTPUT (policy ACCEPT) target prot opt source destination # iptables-restore <iptables.dump # iptables -L Chain INPUT (policy DROP) target prot opt source destination ACCEPT all -- anywhere anywhere ACCEPT all -- anywhere anywhere state RELATED,ESTABLISHED ACCEPT icmp -- anywhere anywhere Chain FORWARD (policy DROP) target prot opt source destination Chain OUTPUT (policy ACCEPT) target prot opt source destination REJECT tcp -- anywhere anywhere tcp dpt:netbios-ns reject-with icmp-port-unreachable REJECT udp -- anywhere anywhere udp dpt:netbios-ns reject-with icmp-port-unreachable And the test suite: # ./iptables/tests/shell/run-tests.sh I: [OK] ././iptables/tests/shell/testcases/chain/0001duplicate_1 I: [OK] ././iptables/tests/shell/testcases/chain/0002newchain_0 I: [OK] ././iptables/tests/shell/testcases/chain/0003rename_1 I: [OK] ././iptables/tests/shell/testcases/ebtables/0001-ebtables- basic_0 I: [OK] ././iptables/tests/shell/testcases/firewalld-restore/0001- firewalld_0 I: [OK] ././iptables/tests/shell/testcases/firewalld-restore/0002- firewalld-restart_0 I: [OK] ././iptables/tests/shell/testcases/ipt-restore/0001load- specific-table_0 I: [OK] ././iptables/tests/shell/testcases/ipt-save/0001load- dumps_0 I: [OK] ././iptables/tests/shell/testcases/ipt-save/0002load- fedora27-firewalld_0 I: legacy results: [OK] 9 [FAILED] 0 [TOTAL] 9 I: [OK] ././iptables/tests/shell/testcases/chain/0001duplicate_1 I: [OK] ././iptables/tests/shell/testcases/chain/0002newchain_0 I: [OK] ././iptables/tests/shell/testcases/chain/0003rename_1 I: [OK] ././iptables/tests/shell/testcases/ebtables/0001-ebtables- basic_0 I: [OK] ././iptables/tests/shell/testcases/firewalld-restore/0001- firewalld_0 I: [OK] ././iptables/tests/shell/testcases/firewalld-restore/0002- firewalld-restart_0 I: [OK] ././iptables/tests/shell/testcases/ipt-restore/0001load- specific-table_0 I: [OK] ././iptables/tests/shell/testcases/ipt-save/0001load- dumps_0 I: [OK] ././iptables/tests/shell/testcases/ipt-save/0002load- fedora27-firewalld_0 I: nft results: [OK] 9 [FAILED] 0 [TOTAL] 9 I: combined results: [OK] 18 [FAILED] 0 [TOTAL] 18
Created attachment 1459272 [details] Rule dump for testing with iptables-restore
Created attachment 1459273 [details] Rule dump for testing with ip6tables-restore
Fix is upstream: commit 31e4b5906ff676a3c13060d6f456d72b7f6c90c2 Author: Joel Goguen <contact+netfilter> Date: Wed Jul 11 16:32:20 2018 -0700 iptables-restore: free the table lock when skipping a table Currently, when running `iptables-restore --table=X`, where `X` is not the first table in the rules dump, the restore will fail when parsing the second table: - a lock is acquird when parsing the first table name - the table name does not match the parameter to `--table` so processing continues until the next table - when processing the next table a lock is acquired, which fails because a lock is already held Another app is currently holding the xtables lock. Perhaps you want to use the -w option? This will release the lock as soon as it's decided the current table won't be used. Signed-off-by: Joel Goguen <contact+netfilter> Signed-off-by: Florian Westphal <fw>
This message is a reminder that Fedora 28 is nearing its end of life. On 2019-May-28 Fedora will stop maintaining and issuing updates for Fedora 28. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '28'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 28 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.