Description of problem: Update FEDORA-2018-6f661431ac linked Samba 4.8.3 against libldb 1.4.0, which isn't supposed to happen. Samba 4.8.3 is supposed to use libldb 1.3.x. (Libldb 1.4.0 is for Samba 4.9.x). As such, there are serious issues with Samba, AD, replication, and DNS updates. See: https://bodhi.fedoraproject.org/updates/FEDORA-2018-6f661431ac https://lists.samba.org/archive/samba/2018-July/216883.html Version-Release number of selected component (if applicable): Samba 4.8.3 and libldb 1.4.0. How reproducible: Very Steps to Reproduce: 1. Install a Samba AD controller 2. dnf update to Samba 4.8.3/libldb 1.4.0 3. Restart Samba, look at the logs. Actual results: "ldb: Failed to unlock db" Expected results: No error. Additional info: As above, referenced on bodhi and Samba's mailing lists: https://bodhi.fedoraproject.org/updates/FEDORA-2018-6f661431ac https://lists.samba.org/archive/samba/2018-July/216883.html
*** This bug has been marked as a duplicate of bug 1601944 ***
Initially I wanted to clone 1601944 to samba but I decided to reuse this bug. It would be good to add build time checks to samba for supported version of libldb (e.g. >= 1.3.0 && <= 1.3.99) IMHO Build time checks can be dome on spec file level for BuildRequires or it can be done at configure time in waf.
There is a patch in 4.9rc1 for that. See git show 1a559fd6a9026d72c3cd50d97c454081e9532068, bug https://bugzilla.samba.org/show_bug.cgi?id=13519 I think we can add this one to f28.
(In reply to Alexander Bokovoy from comment #3) > There is a patch in 4.9rc1 for that. > > See git show 1a559fd6a9026d72c3cd50d97c454081e9532068, bug > https://bugzilla.samba.org/show_bug.cgi?id=13519 > > I think we can add this one to f28. f28 is fine but upstream first approach is more important to avoid issues in other distros. I cannot see that patch or backported version in origin/v4-8-test and that patch is not useful in 4.9 branch (4.9 branch has already configure time check for minimal version of libldb)
(In reply to Alexander Bokovoy from comment #3) > There is a patch in 4.9rc1 for that. > > See git show 1a559fd6a9026d72c3cd50d97c454081e9532068, bug > https://bugzilla.samba.org/show_bug.cgi?id=13519 > > I think we can add this one to f28. I found few more patches which should be backported to v4-8-stable branch f8b368c9f0c2a34b6d15303a9d6facd762e1a517 ldb: Fix missing NULL terminator in ldb_mod_op_test testsuite 350826868dc81846e0b1086ad5f69506ae2a44f6 replace: Only warn if rpc/rpc.h haven't been found
@Lukas, Are we good here to close the bug? I could see the fix for upstream samba bug included from v4.8.5.
(In reply to Anoop C S from comment #6) > @Lukas, > > Are we good here to close the bug? I could see the fix for upstream samba > bug included from v4.8.5. f28 has samba-4.8.6-0.fc28 and there is still some patch in libldb which is not in related upstream breanch. I mentioned in in comment 5 https://src.fedoraproject.org/rpms/libldb/blob/f28/f/0001-replace-Only-warn-if-rpc-rpc.h-haven-t-been-found.patch
This message is a reminder that Fedora 28 is nearing its end of life. On 2019-May-28 Fedora will stop maintaining and issuing updates for Fedora 28. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '28'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 28 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
(In reply to Lukas Slebodnik from comment #7) > (In reply to Anoop C S from comment #6) > > @Lukas, > > > > Are we good here to close the bug? I could see the fix for upstream samba > > bug included from v4.8.5. > > f28 has samba-4.8.6-0.fc28 > and there is still some patch in libldb which is not in related upstream > breanch. > I mentioned in in comment 5 > > https://src.fedoraproject.org/rpms/libldb/blob/f28/f/0001-replace-Only-warn- > if-rpc-rpc.h-haven-t-been-found.patch 0001-replace-Only-warn-if-rpc-rpc.h-haven-t-been-found.patch is already in upstream in f29 and keeping it in f28 is acceptable because it will be soon EOL