Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1603205

Summary:	[OSP13] Fix the deep_compare functions to use crm_diff and not crm_simulate
Product:	Red Hat OpenStack	Reporter:	Michele Baldessari <michele>
Component:	puppet-pacemaker	Assignee:	Michele Baldessari <michele>
Status:	CLOSED ERRATA	QA Contact:	pkomarov
Severity:	high	Docs Contact:
Priority:	high
Version:	13.0 (Queens)	CC:	jjoyce, jschluet, pkomarov, slinaber, tvignaud
Target Milestone:	z2	Keywords:	Triaged, ZStream
Target Release:	13.0 (Queens)
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	puppet-pacemaker-0.7.2-0.20180423212250.el7ost	Doc Type:	No Doc Update
Doc Text:	undefined	Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-08-29 16:38:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michele Baldessari 2018-07-19 12:47:02 UTC

Description of problem:
Currently we can "deep compare" pcmk resources by enabling special hiera keys.
The problem is that it is using crm_simulate due to an older crm_diff bug. Now that crm_diff is fixed let's bring in the proper code (which is conditionalized on testing crm_diff anyway).

This will allow us in the future to update pcmk puppet resources (the default of which is still under discussion). This is fairly low risk as this code is disabled by default.

Comment 10 pkomarov 2018-08-02 05:04:09 UTC

Verified , 

Tested Using : https://code.engineering.redhat.com/gerrit/#/c/144420/

(undercloud) [stack@undercloud-0 ~]$ cat /home/stack/custom_params.yaml
parameter_defaults:
  ExtraConfig:
    tripleo::haproxy::haproxy_globals_override:
      'maxconn': 1111
    pacecemaker::resource::bundle::deep_compare: true   
    pacemaker::resource::ip::deep_compare: true
    pacemaker::resource::ocf::deep_compare: true

[root@controller-1 ~]# docker exec -it haproxy-bundle-docker-1 bash
()[root@controller-1 /]# cat /etc/haproxy/haproxy.cfg|grep 1111
  maxconn  1111

(undercloud) [stack@undercloud-0 ~]$ tail update.out
2018-08-02 01:02:48Z [AllNodesDeploySteps]: UPDATE_COMPLETE  state changed
2018-08-02 01:03:00Z [overcloud]: UPDATE_COMPLETE  Stack UPDATE completed successfully

 Stack overcloud UPDATE_COMPLETE 

Started Mistral Workflow tripleo.deployment.v1.get_horizon_url. Execution ID: 34e831ed-dcf0-438b-989c-f2503aaa8eb3
Overcloud Endpoint: http://10.0.0.109:5000/
Overcloud Horizon Dashboard URL: http://10.0.0.109:80/dashboard
Overcloud rc file: /home/stack/overcloudrc
Overcloud Deployed

Comment 12 errata-xmlrpc 2018-08-29 16:38:50 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2574