Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1605133

Summary: [downstream clone - 4.2.5] Skipped power management operation has misleading logs
Product: Red Hat Enterprise Virtualization Manager Reporter: RHV bug bot <rhv-bugzilla-bot>
Component: ovirt-engineAssignee: Ravi Nori <rnori>
Status: CLOSED ERRATA QA Contact: Petr Matyáš <pmatyas>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.1.10CC: dfodor, lsurette, lsvaty, lveyde, mgoldboi, michal.skrivanek, mperina, Rhev-m-bugs, srevivo, tburke
Target Milestone: ovirt-4.2.5Keywords: ZStream
Target Release: ---Flags: pmatyas: testing_plan_complete-
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1568265 Environment:
Last Closed: 2018-07-31 17:49:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1568265    
Bug Blocks:    

Description RHV bug bot 2018-07-20 09:13:22 UTC
+++ This bug is a downstream clone. The original bug is: +++
+++   bug 1568265 +++
======================================================================

Description of problem:

In executeCommand() in VdsNotRespondingTreatmentCommand.java, there is this initial if clause that aborts fencing:

if (!previousHostedEngineHost.isPreviousHostId(getVds().getId())                                                                                                                       
        && !new FenceValidator().isStartupTimeoutPassed()) {                                                                                                                           
    log.error("Failed to run Fence script on vds '{}'.", getVdsName());                                                                                                                
    alertIfPowerManagementOperationSkipped(RESTART, null);                                                                                                                             
    // If fencing can't be done and the host is the SPM, set storage-pool to non-operational                                                                                           
    if (getVds().getSpmStatus() != VdsSpmStatus.None) {                                                                                                                                
        setStoragePoolNonOperational();                                                                                                                                                
    }                                                                                                                                                                                  
return;

On entering the if clause, the host is not fenced and VDS_ALERT_FENCE_OPERATION_SKIPPED is logged. And VDS_ALERT_FENCE_OPERATION_SKIPPED="....It has no power management configured..."

I dont see that if clause testing for power management configured, Power management configured check on a different place.

The if clause evaluates DisableFenceAtStartupInSec and not fencing the HE host, IMHO this has nothing to do with power management enabled. 

Am I missing something or this produces misleading logs?

Please improve logging, a separate message for each reason would be nice:
- HostedEngine (4.1+)
- DisableFenceAtStartup (4.1+)
- isInFenceFlow() (4.2+)
- Move VDS_ALERT_FENCE_OPERATION_SKIPPED

(Originally by Germano Veit Michel)

Comment 1 RHV bug bot 2018-07-20 09:13:30 UTC
This bug is Modified for some time already, but misses PM an QA ack, can you please check?

(Originally by Dusan Fodor)

Comment 6 Petr Matyáš 2018-07-27 14:06:37 UTC
Verified on ovirt-engine-4.2.5.2-0.1.el7ev.noarch

Comment 8 errata-xmlrpc 2018-07-31 17:49:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2318