Bug 1605133 - [downstream clone - 4.2.5] Skipped power management operation has misleading logs
Summary: [downstream clone - 4.2.5] Skipped power management operation has misleading ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 4.1.10
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ovirt-4.2.5
: ---
Assignee: Ravi Nori
QA Contact: Petr Matyáš
URL:
Whiteboard:
Depends On: 1568265
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-07-20 09:13 UTC by RHV bug bot
Modified: 2022-03-13 15:16 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1568265
Environment:
Last Closed: 2018-07-31 17:49:18 UTC
oVirt Team: Infra
Target Upstream Version:
Embargoed:
pmatyas: testing_plan_complete-


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHV-43556 0 None None None 2021-09-09 15:08:37 UTC
Red Hat Knowledge Base (Solution) 3493331 0 None None None 2018-07-20 09:13:49 UTC
Red Hat Product Errata RHBA-2018:2318 0 None None None 2018-07-31 17:50:03 UTC
oVirt gerrit 91848 0 master MERGED engine : Skipped power management operation has misleading logs 2018-07-20 09:13:49 UTC
oVirt gerrit 92760 0 ovirt-engine-4.2 MERGED engine : Skipped power management operation has misleading logs 2018-07-20 09:13:49 UTC

Description RHV bug bot 2018-07-20 09:13:22 UTC
+++ This bug is a downstream clone. The original bug is: +++
+++   bug 1568265 +++
======================================================================

Description of problem:

In executeCommand() in VdsNotRespondingTreatmentCommand.java, there is this initial if clause that aborts fencing:

if (!previousHostedEngineHost.isPreviousHostId(getVds().getId())                                                                                                                       
        && !new FenceValidator().isStartupTimeoutPassed()) {                                                                                                                           
    log.error("Failed to run Fence script on vds '{}'.", getVdsName());                                                                                                                
    alertIfPowerManagementOperationSkipped(RESTART, null);                                                                                                                             
    // If fencing can't be done and the host is the SPM, set storage-pool to non-operational                                                                                           
    if (getVds().getSpmStatus() != VdsSpmStatus.None) {                                                                                                                                
        setStoragePoolNonOperational();                                                                                                                                                
    }                                                                                                                                                                                  
return;

On entering the if clause, the host is not fenced and VDS_ALERT_FENCE_OPERATION_SKIPPED is logged. And VDS_ALERT_FENCE_OPERATION_SKIPPED="....It has no power management configured..."

I dont see that if clause testing for power management configured, Power management configured check on a different place.

The if clause evaluates DisableFenceAtStartupInSec and not fencing the HE host, IMHO this has nothing to do with power management enabled. 

Am I missing something or this produces misleading logs?

Please improve logging, a separate message for each reason would be nice:
- HostedEngine (4.1+)
- DisableFenceAtStartup (4.1+)
- isInFenceFlow() (4.2+)
- Move VDS_ALERT_FENCE_OPERATION_SKIPPED

(Originally by Germano Veit Michel)

Comment 1 RHV bug bot 2018-07-20 09:13:30 UTC
This bug is Modified for some time already, but misses PM an QA ack, can you please check?

(Originally by Dusan Fodor)

Comment 6 Petr Matyáš 2018-07-27 14:06:37 UTC
Verified on ovirt-engine-4.2.5.2-0.1.el7ev.noarch

Comment 8 errata-xmlrpc 2018-07-31 17:49:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2318


Note You need to log in before you can comment on or make changes to this bug.