Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-HTML-Tidy5.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-HTML-Tidy5-1.04-1.fc29.src.rpm Description: HTML::Tidy5 is an HTML checker in a handy dandy object. It's meant as a replacement for HTML::Lint. Fedora Account System Username: corsepiu This package is new - so far optional - testsuite requirement of some other packages already in Fedora.
- Source0 is 404. Source0 should be: Source0: https://cpan.metacpan.org/authors/id/P/PE/PETDANCE/HTML-Tidy5-%{version}.tar.gz - NO_PACKLIST=1 is only supported on perl(ExtUtils::MakeMaker) >= 6.76, thus you should constrain your BR: BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 - PERL_INSTALL_ROOT is not used anymore, it is replaced by DESTDIR: %{__make} pure_install DESTDIR=$RPM_BUILD_ROOT - You need add perl-interpreter at a BR: perl-interpreter – The Perl interpreter must be listed as a build dependency if it is called in any way, either explicitly via perl or %__perl, or as part of your package's build system. BuildRequires: perl-interpreter URL and Source addresses are Ok. Source archive (SHA-256: c9fd157e4026df7b4550d2ab51934e83d96640c721ffa8869758971b3276effe) is original. Ok. Summary verified from lib/HTML/Tidy5.pm. Ok. Description verified from lib/HTML/Tidy5.pm. Ok. License verified from lib/HTML/Tidy5.pm and README.md. Ok. XS code, BuildArch is arched: Ok. All tests pass. Ok. $ rpmlint perl-HTML-Tidy5.spec review-perl-HTML-Tidy5/results/perl-HTML-Tidy5-1.04-1.fc29.x86_64.rpm review-perl-HTML-Tidy5/results/perl-HTML-Tidy5-1.04-1.fc29.src.rpm perl-HTML-Tidy5.x86_64: W: no-manual-page-for-binary webtidy5 2 packages and 1 specfiles checked; 0 errors, 1 warnings. $ rpm -q -lv -p perl-HTML-Tidy5-1.04-1.fc29.x86_64.rpm -rwxr-xr-x 1 root root 2089 juil. 23 19:38 /usr/bin/webtidy5 drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/lib/.build-id drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/lib/.build-id/e3 lrwxrwxrwx 1 root root 64 juil. 23 19:38 /usr/lib/.build-id/e3/78e0ea2bf87d25ce06b5b87362873585767884 -> ../../../../usr/lib64/perl5/vendor_perl/auto/HTML/Tidy5/Tidy5.so drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/lib64/perl5/vendor_perl/HTML drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/lib64/perl5/vendor_perl/HTML/Tidy5 -rw-r--r-- 1 root root 10957 avril 20 23:49 /usr/lib64/perl5/vendor_perl/HTML/Tidy5.pm -rw-r--r-- 1 root root 2489 avril 4 21:41 /usr/lib64/perl5/vendor_perl/HTML/Tidy5/Message.pm drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/lib64/perl5/vendor_perl/Test drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/lib64/perl5/vendor_perl/Test/HTML -rw-r--r-- 1 root root 4095 avril 20 23:49 /usr/lib64/perl5/vendor_perl/Test/HTML/Tidy5.pm drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/lib64/perl5/vendor_perl/auto/HTML drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/lib64/perl5/vendor_perl/auto/HTML/Tidy5 -rwxr-xr-x 1 root root 19776 juil. 23 19:38 /usr/lib64/perl5/vendor_perl/auto/HTML/Tidy5/Tidy5.so drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/share/doc/perl-HTML-Tidy5 -rw-r--r-- 1 root root 1164 avril 20 23:49 /usr/share/doc/perl-HTML-Tidy5/Changes -rw-r--r-- 1 root root 901 mars 26 23:32 /usr/share/doc/perl-HTML-Tidy5/README.md -rw-r--r-- 1 root root 3607 juil. 23 19:38 /usr/share/man/man3/HTML::Tidy5.3pm.gz -rw-r--r-- 1 root root 1754 juil. 23 19:38 /usr/share/man/man3/HTML::Tidy5::Message.3pm.gz -rw-r--r-- 1 root root 2196 juil. 23 19:38 /usr/share/man/man3/Test::HTML::Tidy5.3pm.gz File permissions and layout are Ok. $ rpm -q --requires -p perl-HTML-Tidy5-1.04-1.fc29.x86_64.rpm | sort -f | uniq -c 1 /usr/bin/perl 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libperl.so.5.28()(64bit) 1 libpthread.so.0()(64bit) 1 libpthread.so.0(GLIBC_2.2.5)(64bit) 1 libtidy.so.5()(64bit) 1 perl(:VERSION) >= 5.10.1 1 perl(base) 1 perl(Carp) 1 perl(constant) 1 perl(Exporter) 1 perl(Getopt::Long) 1 perl(HTML::Tidy5) 1 perl(HTML::Tidy5::Message) 1 perl(parent) 1 perl(strict) 1 perl(Test::Builder) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p perl-HTML-Tidy5-1.04-1.fc29.x86_64.rpm perl(HTML::Tidy5) = 1.04 perl(HTML::Tidy5::Message) perl(Test::HTML::Tidy5) = 1.04 perl-HTML-Tidy5 = 1.04-1.fc29 perl-HTML-Tidy5(x86-64) = 1.04-1.fc29 Binary provides are Ok. Package does not build in F29 (https://koji.fedoraproject.org/koji/taskinfo?taskID=28545894) Tests failure on i686.
To solve the test failure, backport this commit: https://github.com/petdance/html-tidy5/commit/23db6204554498928553ca1b92789386a86e1d45.patch
Spec URL: https://mklvr.fedorapeople.org/perl-HTML-Tidy5/perl-HTML-Tidy5.spec SRPM URL: https://mklvr.fedorapeople.org/perl-HTML-Tidy5/perl-HTML-Tidy5-1.04-1.fc29.src.rpm Description: HTML::Tidy5 is an HTML checker in a handy dandy object. It's meant as a replacement for HTML::Lint. Fedora Account System Username: mklvr Resubmitting for corsepiu with requested changes/patches. I can take over maintaining the package if they're no longer interested. Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=29782083 Builds for all architectures on f28, as well.
You didn't solve the other point I mentioned: - NO_PACKLIST=1 is only supported on perl(ExtUtils::MakeMaker) >= 6.76, thus you should constrain your BR: BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 - PERL_INSTALL_ROOT is not used anymore, it is replaced by DESTDIR: %{__make} pure_install DESTDIR=$RPM_BUILD_ROOT - You need add perl-interpreter at a BR: perl-interpreter – The Perl interpreter must be listed as a build dependency if it is called in any way, either explicitly via perl or %__perl, or as part of your package's build system. BuildRequires: perl-interpreter You should discuss with Corsepius whether he agrees or not to leave you this package. Also you're not a member of the packager group so you would also need a sponsor.
Spec URL: https://mklvr.fedorapeople.org/perl-HTML-Tidy5/perl-HTML-Tidy5.spec SRPM URL: https://mklvr.fedorapeople.org/perl-HTML-Tidy5/perl-HTML-Tidy5-1.04-1.fc29.src.rpm I've made the requested changes. I'm not sure what happened with the perl-interpreter BR, but it was originally included. In any case, I've made the rest of the changes. I've reached out to Corsepius and asked him if he was still interested in maintaining this package. I've directed him to respond here. If he decides that he's no longer interested, I'll start pursuing a sponsorship. Thanks for the help.
(In reply to Mike Oliver from comment #5) > I've made the requested changes. I'm not sure what happened with the > perl-interpreter BR, but it was originally included. In any case, I've made > the rest of the changes. These change requests are mostly cosmetical without any actual sense. > I've reached out to Corsepius and asked him if he was still interested in > maintaining this package. I've directed him to respond here. I am still interested, but did decided not update the request, because this package still fails to build on the i386 for undetermined causes. > If he decides that he's no longer interested, I'll start pursuing a > sponsorship. ?!?
(In reply to Ralf Corsepius from comment #6) > (In reply to Mike Oliver from comment #5) > > I've made the requested changes. I'm not sure what happened with the > > perl-interpreter BR, but it was originally included. In any case, I've made > > the rest of the changes. > These change requests are mostly cosmetical without any actual sense. > > > I've reached out to Corsepius and asked him if he was still interested in > > maintaining this package. I've directed him to respond here. > I am still interested, but did decided not update the request, because this > package still fails to build on the i386 for undetermined causes. > I already pointed out that you need to backport this commit to solve the failure https://github.com/petdance/html-tidy5/commit/23db6204554498928553ca1b92789386a86e1d45.patch
I backported that as a patch in my spec file. He's welcome to take over from here with my spec and SRPM. It's his review request. I was just trying to get the ball rolling again.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.