Bug 1607305 - wrong total num of log stream on openshift console
Summary: wrong total num of log stream on openshift console
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 3.10.0
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: 3.11.0
Assignee: Jon Jackson
QA Contact: Yadan Pei
Depends On: 1601832
TreeView+ depends on / blocked
Reported: 2018-07-23 09:06 UTC by shahan
Modified: 2018-08-23 11:54 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: Log viewer was not accounting for multi-line or partial line responses. Consequence: If a response contained a multiline message, it would be directly appended and treated as a single line, causing the line numbers to be incorrect. Similarly, if a partial line was received, it would be treated as a full line, causing longer log lines to sometimes be split into multiple lines, again making the line count incorrect. Fix: Added logic in the log viewer to account for multiline and partial line responses. Result: Line numbers are now accurate.
Clone Of: 1601832
Last Closed: 2018-08-23 11:54:49 UTC
Target Upstream Version:

Attachments (Terms of Use)
build log with wrong line count (93.81 KB, image/png)
2018-07-23 09:06 UTC, shahan
no flags Details

Description shahan 2018-07-23 09:06:39 UTC
Created attachment 1469909 [details]
build log with wrong line count

+++ This bug was initially created as a clone of Bug #1601832 +++

Description of problem:
 The old console also marked the wrong total num of build log stream in build page.

Version-Release number of selected component (if applicable):
docker.io/openshift/origin-console   latest    1f14ec53b95d 

How reproducible:

Steps to Reproduce:

1. oc new-app centos/ruby-22-centos7~https://github.com/openshift/ruby-ex.git
2. check build log 

Actual results:
The total num is 2 lines

Expected results:
Should be correct total num of lines.

Comment 1 shahan 2018-07-23 09:07:53 UTC
Console version should be:

OpenShift Master:v3.10.23 
OpenShift Web Console: v3.10.23

Comment 3 Jon Jackson 2018-07-24 16:54:41 UTC
Fixed by: https://github.com/openshift/origin-web-console/pull/3042

Comment 4 openshift-github-bot 2018-07-24 19:09:45 UTC
Commit pushed to master at https://github.com/openshift/origin-web-console

Merge pull request #3042 from TheRealJon/log-line-number-bug

Bug 1607305 - Adjust log viewer to handle multiline and non-newline terminated responses

Comment 6 shahan 2018-08-23 07:02:04 UTC
This issue has been fixed,count of the log is correct now. verified bug.
OpenShift Web Console:

Note You need to log in before you can comment on or make changes to this bug.