Bug 1607319 - Remove uuid from contrib/
Summary: Remove uuid from contrib/
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: build
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On: 1608707
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-07-23 09:36 UTC by Niels de Vos
Modified: 2018-10-23 15:14 UTC (History)
1 user (show)

Fixed In Version: glusterfs-5.0
Clone Of:
Environment:
Last Closed: 2018-10-23 15:14:52 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2018-07-23 09:36:27 UTC
Description of problem:

Bundling libuuid is not needed anymore, all current distributions provide it now.

Comment 1 Worker Ant 2018-07-23 09:37:51 UTC
REVIEW: https://review.gluster.org/20551 (build: remove uuid from contrib/) posted (#1) for review on master by Niels de Vos

Comment 2 Worker Ant 2018-07-26 13:29:26 UTC
REVIEW: https://review.gluster.org/20570 (build: move GF_CPPFLAGS to last option while compiling) posted (#1) for review on master by Niels de Vos

Comment 3 Worker Ant 2018-07-27 17:38:07 UTC
COMMIT: https://review.gluster.org/20570 committed in master by "Niels de Vos" <ndevos> with a commit message- build: rename event.h to gf-event.h

Newer FreeBSD versions (noticed with 10.3-RELEASE) provide a event.h
file that on occasion gets included instead of the libglusterfs file.
When this happens, 'struct event_pool' will not be defined and building
will fail with errors like:

    autoscale-threads.c:18:55: error: incomplete definition of type 'struct event_pool'
            int                      thread_count   = pool->eventthreadcount;
                                                      ~~~~^
    autoscale-threads.c:17:16: note: forward declaration of 'struct event_pool'
            struct event_pool       *pool           = ctx->event_pool;
                   ^

This problem is caused by 'pkg-config --cflags uuid' that adds
/usr/local/include to the GF_CPPFLAGS. The use of libuuid is preferred
so that the contrib/uuid/ directory can be removed.

By renaming event.h to gf-event.h there is no conflict between the
different event.h files anymore and compiling on FreeBSD works without
issues.

Change-Id: Ie69f6b8a4f8f8e9630d39a86693eb74674f0f763
Updates: bz#1607319
Signed-off-by: Niels de Vos <ndevos>

Comment 4 Worker Ant 2018-07-27 17:38:28 UTC
COMMIT: https://review.gluster.org/20551 committed in master by "Niels de Vos" <ndevos> with a commit message- build: remove uuid from contrib/

Bundling libuuid is not needed anymore, all current distributions
provide it now.

Some OS's provide their own uuid_*() functions in libc. These may not be
fully compatible with libuuid.so found on Linux systems. In that case,
either e2fsprogs-libuuid can be installed, or support for the native
uuid_*() functions can be added to libglusterfs/src/compat-uuid.h.

Change-Id: Icfa48caea81307a3bca549364969c2038911942b
Fixes: bz#1607319
Signed-off-by: Niels de Vos <ndevos>

Comment 5 Shyamsundar 2018-10-23 15:14:52 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.