Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1607689

Summary:	Memory leaks on glfs_fini
Product:	[Community] GlusterFS	Reporter:	Zhang Huan <zhhuan>
Component:	libgfapi	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-5.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-10-23 15:15:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Zhang Huan 2018-07-24 03:17:36 UTC

Description of problem:
Found several memory leaks in glfs_fini to fix.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2018-07-24 03:23:16 UTC

REVIEW: https://review.gluster.org/20553 (libgfapi: add missing unref of mgmt client in glfs_fini) posted (#1) for review on master by Zhang Huan

Comment 2 Worker Ant 2018-07-24 03:25:12 UTC

REVIEW: https://review.gluster.org/20555 (rpc: add missing free of rpc->dnscache) posted (#1) for review on master by Zhang Huan

Comment 3 Worker Ant 2018-07-24 03:49:02 UTC

REVIEW: https://review.gluster.org/20554 (libgfapi: fix memory leak on old volume files) posted (#2) for review on master by Zhang Huan

Comment 4 Worker Ant 2018-07-27 00:54:59 UTC

REVIEW: https://review.gluster.org/20573 (rpc: fix return value in rpc destroy) posted (#1) for review on master by Zhang Huan

Comment 5 Worker Ant 2018-07-28 07:21:50 UTC

COMMIT: https://review.gluster.org/20553 committed in master by "Amar Tumballi" <amarts> with a commit message- libgfapi: add missing unref of mgmt client in glfs_fini

Change-Id: I89cdf14cb9d822eaf7c01cf0b0220b423eb5b705
fixes: bz#1607689
Signed-off-by: Zhang Huan <zhanghuan>

Comment 6 Worker Ant 2018-07-28 07:22:10 UTC

COMMIT: https://review.gluster.org/20554 committed in master by "Amar Tumballi" <amarts> with a commit message- libgfapi: fix memory leak on old volume files

Fix missing free of fs->oldvolfile. This patch uses standard
calloc/realloc to allocate memory for vol file. As by the time fs struct
is destroyed, the THIS->ctx is already gone, that causes invalid memory
access.

Change-Id: I72ae19c76eb16e61f077714f7e52405fee721997
fixes: bz#1607689
Signed-off-by: Zhang Huan <zhanghuan>

Comment 7 Worker Ant 2018-07-28 07:22:30 UTC

COMMIT: https://review.gluster.org/20555 committed in master by "Amar Tumballi" <amarts> with a commit message- rpc: add missing free of rpc->dnscache

Change-Id: I3fa97b99bf23459cf548205d75d2cc7936b2310e
fixes: bz#1607689
Signed-off-by: Zhang Huan <zhanghuan>

Comment 8 Worker Ant 2018-07-28 07:22:51 UTC

COMMIT: https://review.gluster.org/20573 committed in master by "Amar Tumballi" <amarts> with a commit message- rpc: fix return value in rpc destroy

Change-Id: I73a113e2d40f508fd53b273a990a2371692c87bf
fixes: bz#1607689
Signed-off-by: Zhang Huan <zhanghuan>

Comment 9 Shyamsundar 2018-10-23 15:15:30 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/