Created attachment 1470335[details]
ffu-upgrade-prepare-log
Description of problem:
In a ceph topology env, while running openstack overcloud ffwd-upgrade prepare command wihout passing ceph-ansible-env.yaml, the upgrade prepare command passes and does not report any missing file/config error.
Steps to Reproduce:
1. Deploy rhos-10 with 3 controller, 2 compute and 3 ceph
2.Upgrade undercloud from rhos-10 to rhos-13
3. Start overcloud ffwd-upgrade process:
openstack overcloud ffwd-upgrade prepare --templates $ENV_FILES -e $HOME/cli_opts_params.yaml -e $HOME/ffu_repos.yaml -e /home/stack/virt/docker-images.yaml --yes
Actual results:
Stack overcloud UPDATE_COMPLETE
Expected results:
Stack overcloud UPDATE_FAILED: Missing ceph-ansible-env.yaml
Additional info:
Due to this issue, the upgrade prepare passed till the ffwd-upgrade converge step where it failed without any errors, logs attached
openstack overcloud ceph-upgrade run --templates \
-e $ALL_ENVIRONMENTS_USED_TO_DEPLOY \
-e $HOME/cli_opts_params.yaml \
-e $HOME/ceph-ansible-env.yaml \
-e /home/stack/virt/docker-images.yaml \
--ceph-ansible-playbook '/usr/share/ceph-ansible/infrastructure-playbooks/switch-from-non-containerized-to-containerized-ceph-daemons.yml,/usr/share/ceph-ansible/infrastructure-playbooks/rolling_update.yml'
Here, the passed ceph-ansible-env.yaml was not created and still the command passed without any errors.
This improvement is wider than it looks, as it the end it requires to identify an environment file which is required (used during deployment or needed for FFWD). A work is ongoing to save the plan environment used during deployment, so it would be easier to identify this case of user errors. Marking the BZ as an RFE.
Created attachment 1470335 [details] ffu-upgrade-prepare-log Description of problem: In a ceph topology env, while running openstack overcloud ffwd-upgrade prepare command wihout passing ceph-ansible-env.yaml, the upgrade prepare command passes and does not report any missing file/config error. Steps to Reproduce: 1. Deploy rhos-10 with 3 controller, 2 compute and 3 ceph 2.Upgrade undercloud from rhos-10 to rhos-13 3. Start overcloud ffwd-upgrade process: openstack overcloud ffwd-upgrade prepare --templates $ENV_FILES -e $HOME/cli_opts_params.yaml -e $HOME/ffu_repos.yaml -e /home/stack/virt/docker-images.yaml --yes Actual results: Stack overcloud UPDATE_COMPLETE Expected results: Stack overcloud UPDATE_FAILED: Missing ceph-ansible-env.yaml Additional info: Due to this issue, the upgrade prepare passed till the ffwd-upgrade converge step where it failed without any errors, logs attached