User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0 Build Identifier: msitools (which depends on libgcab1-1.1-1 on Fedora 28) mostly produces garbage when extracting an msi file. Reproducible: Always Steps to Reproduce: 1. Fetch this example: https://github.com/billziss-gh/winfsp/releases/download/v1.3/winfsp-1.3.18160.msi 2. Run msiextract winfsp-1.3.18160.msi 3. Examine ./Program\ Files/WinFsp/inc/fuse/*.h, all of them should be ASCII but at least fuse.h is some binary garbage Actual Results: Most of the files are not extracted correctly Expected Results: All files in the msi should be extracted correctly If I fetch the old gcab-0.7 src rpm from Fedora27, build and install libgcab1 ant libgcab1-devel, then rpmbuild msitools against this, msiextract starts working again. So this appears to be some incompatibility to the newer libgcab1-1.1
Created attachment 1470500 [details] fix here is a fix for the regression. However, I am not sure if it's really correct yet. I'll ask Richard his review
Hi Marc-Andre, I have tested your patch and it appears to work fine. Any progress regarding that review? Shall I open another Bug against the gcab package?
Can you PLEASE trigger a build with this patch applied?
https://bodhi.fedoraproject.org/updates/FEDORA-2018-a2e46e0cf8