Bug 1608401 - Review Request: python-pyperclip - A cross-platform clipboard module for Python
Summary: Review Request: python-pyperclip - A cross-platform clipboard module for Python
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Pierre-YvesChibon
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-07-25 13:04 UTC by Haïkel Guémar
Modified: 2018-07-25 15:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-07-25 15:11:36 UTC
Type: ---
Embargoed:
pingou: fedora-review+

Attachments (Terms of Use)

Description Haïkel Guémar 2018-07-25 13:04:56 UTC 
Spec URL: https://hguemar.fedorapeople.org/reviews/python-pyperclip.spec
SRPM URL: https://hguemar.fedorapeople.org/reviews/python-pyperclip-1.6.4-1.fc28.src.rpm
Description: A cross-platform clipboard module for Python
Fedora Account System Username: hguemar
Comment 1 Pierre-YvesChibon 2018-07-25 13:18:14 UTC 
* Spec is nice and clean
  - I'd recommend using the new %pypi_source macro but that's at your option
  - I'd also recommend including the CHANGES.txt in the %doc (though looking at the MANIFEST.in I'm not sure upstream ships it in their tarball)
  - I'd recommend asking upstream to include their LICENSE.txt file so it can be flagged in the spec file
* Builds fine in all arches:
  https://koji.fedoraproject.org/koji/taskinfo?taskID=28595642
* License is valid and correct
* Basic test of the code shows no error:
   >>> import pyperclip
   >>> pyperclip.copy('foo')
   >>> pyperclip.paste()
   'foo'

APPROVED
Comment 2 Gwyn Ciesla 2018-07-25 14:31:48 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pyperclip
Comment 3 Haïkel Guémar 2018-07-25 15:11:36 UTC 
Imported and built in rawhide
Note You need to log in before you can comment on or make changes to this bug.