Bug 1609027 - installer does not handle openshift_crio_docker_gc_node_selector={"node-role.kubernetes.io/compute": "true"} well.
Summary: installer does not handle openshift_crio_docker_gc_node_selector={"node-role....
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 3.10.0
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: 3.10.z
Assignee: Russell Teague
QA Contact: Johnny Liu
Depends On:
TreeView+ depends on / blocked
Reported: 2018-07-26 18:43 UTC by Johnny Liu
Modified: 2018-08-31 06:18 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: If a node selector was provided as a value of 'true', it was interpreted as a boolean and would cause daemonset deployment to fail. Fix: The template for creating the daemonset is updated to quote the provided value to ensure it is interpreted as a string.
Clone Of:
Last Closed: 2018-08-31 06:18:10 UTC
Target Upstream Version:

Attachments (Terms of Use)
installation log with inventory file embedded (1.78 MB, text/plain)
2018-07-26 18:43 UTC, Johnny Liu
no flags Details

System ID Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:2376 None None None 2018-08-31 06:18:51 UTC

Description Johnny Liu 2018-07-26 18:43:29 UTC
Created attachment 1470867 [details]
installation log with inventory file embedded

Description of problem:
See the following details.

Version-Release number of the following components:

How reproducible:

Steps to Reproduce:
1. install a cluster enable cri-o, and setting the following parameter
openshift_crio_docker_gc_node_selector={"node-role.kubernetes.io/compute": "true"}
2. trigger installation

Actual results:
installation failed.
TASK [openshift_docker_gc : Apply dockergc DaemonSet] **************************
Thursday 26 July 2018  03:28:10 -0400 (0:00:00.537)       0:23:52.802 ********* 
fatal: [host-8-245-162.host.centralci.eng.rdu2.redhat.com]: FAILED! => {"changed": false, "failed": true, "msg": {"cmd": "/usr/bin/oc create -f /tmp/tmp.FizoYr71Pd/dockergc-ds.yaml -n default", "results": {}, "returncode": 1, "stderr": "Error from server (BadRequest): DaemonSet in version \"v1beta1\" cannot be handled as a DaemonSet: [pos 797]: json: expect char '\"' but got char 't'\n", "stdout": "serviceaccount \"dockergc\" created\n"}}

Expected results:
Installation succeed.

Additional info:
After the failure, log into cluster, check /tmp/tmp.FizoYr71Pd/dockergc-ds.yaml, found its node selector is set to:
        node-role.kubernetes.io/compute: true

If adding quote for true like the following, the dockergc ds will be created successfully.
        node-role.kubernetes.io/compute: "true"

openshift_crio_docker_gc_node_selector={'node-role.kubernetes.io/compute': '"true"'}

Comment 1 Russell Teague 2018-08-08 18:43:40 UTC
Proposed: https://github.com/openshift/openshift-ansible/pull/9486

Comment 2 openshift-github-bot 2018-08-10 08:04:05 UTC
Commit pushed to master at https://github.com/openshift/openshift-ansible

Merge pull request #9486 from mtnbikenc/fix-1609027

[Bug 1609027] Add quotes to docker gc node selector

Comment 3 Russell Teague 2018-08-14 14:09:28 UTC
release-3.10: https://github.com/openshift/openshift-ansible/pull/9587

Comment 5 Johnny Liu 2018-08-21 09:43:27 UTC
Verified this but with openshift-ansible-3.10.32-1.git.0.100156fNone, and PASS.

When openshift_crio_docker_gc_node_selector={"node-role.kubernetes.io/compute": "true"}, install is completed successfully.
# oc get ds dockergc -o yaml|grep nodeSelec -A 3
        node-role.kubernetes.io/compute: "true"
      restartPolicy: Always
      schedulerName: default-scheduler

When openshift_crio_docker_gc_node_selector={"role": "node"}, install is also completed successfully.
# oc get ds dockergc -o yaml|grep nodeSelec -A 3
        role: node
      restartPolicy: Always
      schedulerName: default-scheduler

Once correct rpm is moved to errata, will move this bug to verified.

Comment 6 Johnny Liu 2018-08-22 03:51:22 UTC
Now openshift-ansible-3.10.34-1.git.0.48df172None.noarch is already attached to errata, which is including the fix PR, based on comment 5, move this bug to verified.

Comment 8 errata-xmlrpc 2018-08-31 06:18:10 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.