Bug 1609363 - the comment on github job should post full commit message to issue.
Summary: the comment on github job should post full commit message to issue.
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: GlusterFS
Classification: Community
Component: project-infrastructure
Version: mainline
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard: Process-Automation
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-07-27 18:36 UTC by Amar Tumballi
Modified: 2019-05-27 00:49 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-05-27 00:49:32 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Amar Tumballi 2018-07-27 18:36:43 UTC
# Description of problem:

Currently github patch link update job, only posts the URL, subject of the commit. It would be great to get it to post full message to github so if people have given more details, it can be present in github issue, which later can be used for further discussion etc. Also serves as easy method to validate the labels.

# Additional info:

Post to bugzilla job is already posting full commit message to the comment.

Comment 1 Nigel Babu 2018-10-04 13:42:14 UTC
I'm not sure if this useful. Even the bugzilla check only links title until the merge comes along. At that point we post the whole thing.

Comment 2 Shyamsundar 2018-10-04 16:33:39 UTC
My 2 c's:

- Commit subject appears twice, once due to posting and once merged as github picks up the reference to the "Fixes"/"Updates" keywords
- Commit message in whole can be useful to understand more details, than going to the patch
- So having the job post the entire message can be useful and also possibly drive better commit message writing as an aside

The downsides could be claims that the commit message itself provides the required documentation and such, which we should avoid.

I would prefer the entire message than just the subject, unless there are considerations that I am missing.


Note You need to log in before you can comment on or make changes to this bug.