Seems OK except the dangling symlink instead of a license file.

https://github.com/containers/fuse-overlayfs/pull/6/commits/f16819486aa1937be410134a2ac8c3bafdcf58f8

SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lsm5/fuse-overlayfs/fedora-rawhide-x86_64/00782399-fuse-overlayfs/fuse-overlayfs-0.1-3.dev.git79c70fd.fc29.src.rpm

This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Provides: bundled(gnulib) in place as required.
  Note: Bundled gnulib but no Provides: bundled(gnulib)
  See:
  http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Requirement_if_you_bundle
- Header files in -devel subpackage, if present.
  Note: fuse-overlayfs-debugsource : /usr/src/debug/fuse-
  overlayfs-0.1-3.dev.git79c70fd.fc28.x86_64/lib/bitrotate.h fuse-
  overlayfs-debugsource : /usr/src/debug/fuse-
  overlayfs-0.1-3.dev.git79c70fd.fc28.x86_64/lib/hash.h fuse-overlayfs-
  debugsource : /usr/src/debug/fuse-
  overlayfs-0.1-3.dev.git79c70fd.fc28.x86_64/lib/xalloc-oversized.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc make
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2


===== MUST items =====

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v3 or later)", "Unknown or generated". 26 files have
     unknown license. Detailed output of licensecheck in /home/lsm5/1609598
     -fuse-overlayfs/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/.build-id
     (libwayland-server, cyrus-sasl-md5, iputils, spectrwm,
     qt5-qtxmlpatterns, cups-client, numactl-libs, gc, libxshmfence,
     libchromaprint, gpgme, libsndfile, libvisio, libmcpp, libnfsidmap,
     postgresql-libs, giflib, libreoffice-graphicfilter, gdb-headless,
     trousers, bzip2-libs, unzip, dbus-libs, xcb-util-wm, libdb-utils, vlc,
     xorg-x11-font-utils, gtk2, gtk3, libwayland-egl, lame-libs, openssl-
     pkcs11, libv4l, libdbusmenu-gtk3, u2f-hidraw-policy, npth, p11-kit,
     libyaml, iptables-libs, libabw, device-mapper-persistent-data,
     cryptsetup-libs, python2-krbv, libmodman, xdotool, ttmkfdir,
     libselinux-utils, perl-Scalar-List-Utils, parted, libdvdread, zstd,
     xcb-util-image, bluez-libs, python2-cryptography, lua-posix, libinput,
     libwebp, libxslt, gdbm, libkcapi-hmaccalc, libebml, libpkgconf,
     libunistring, keyutils-libs, perl-Encode, elfutils, libproxy,
     libevdev, libgpg-error, lvm2-libs, rxvt-unicode, perl-Digest-SHA,
     libreoffice-math, qt5-qtsvg, perl-Data-Dumper, game-music-emu,
     libreoffice-calc, gstreamer1-plugins-good, gawk, libzstd, libasyncns,
     libbasicobjects, c-ares, libmicrodns, perl-libs, zathura-pdf-poppler,
     jansson, libcdr, ftgl, e2fsprogs-libs, pulseaudio-libs, libsmbclient,
     librsvg2, firefox, lcms2, alsa-utils, nmap, libsss_nss_idmap, annobin,
     deltarpm, file-libs, libdvbpsi, grub2-tools, libxcb, trousers-lib,
     libyubikey, python3-pycurl, tar, zip, libnetfilter_conntrack, webrtc-
     audio-processing, alsa-tools, startup-notification, m4, lksctp-tools,
     ocl-icd, rpm-sign-libs, libvdpau, libusbx, python3-PyYAML, poppler-
     glib, java-openjdk-headless, qrencode-libs, opencore-amr, libICE,
     harfbuzz-devel, drpm, xcb-util, linux-atm-libs, llvm5.0-libs,
     createrepo_c-libs, python3-setools, elfutils-libs, dep, libindicator-
     gtk3, libtasn1, speexdsp, libwbclient, xcb-util-renderutil, openssh,
     libe-book, libreoffice-x11, python3-dbus, sqlite, http-parser,
     python3-libsemanage, links, sudo, freetype, openssl, dhcp-client,
     libgomp, libeot, gcc, systemd-bootchart, dwz, alsa-lib, gstreamer1
     -plugins-good-gtk, libupnp, cyrus-sasl-sql, vid.stab, ostree-libs,
     x264-libs, libappindicator-gtk3, ebtables, libicu-devel, libsmartcols,
     avahi-libs, mesa-dri-drivers, seamonkey, pyliblzma, ncurses-libs,
     libidn2, snapd, samba-common-libs, pigz, checkpolicy, libpsl, gdbm-
     libs, fribidi, xorg-x11-xkb-utils, libcom_err, libxkbfile,
     python3-rpm, libini_config, scrot, openssh-clients, libuser, bind-
     export-libs, python3-hawkey, libwpd, libnotify, libdc1394, kbd,
     beignet, rpm-build, mutt, boost-date-time, libwps, libreoffice-core,
     python3-cryptography, wayland-devel, faad2-libs, mythes, xterm-resize,
     atkmm, libacl, libwayland-cursor, libnl3, libsecret, libseccomp,
     libSM, policycoreutils, pixman, libpaper, squashfs-tools, chromium-
     libs, zathura-djvu, libidn, xvidcore, libXxf86misc, libwacom,
     libbluray, grubby, minizip, python2-kerberos, pango, pcre2-utf16,
     libss, libbabeltrace, libdbusmenu, libpath_utils, esmtp, dbus,
     libmpeg2, polkit-libs, psmisc, perl-threads, perl-Params-Validate,
     xorg-x11-drv-libinput, pangomm, libsss_certmap, libglvnd-gles,
     python3-audit, python2-libcomps, redhat-lsb-core, ed, cyrus-sasl-gs2,
     audit-libs, cyrus-sasl-devel, nss-sysinit, bluez, libgcc, freeglut,
     gstreamer1, gettext-libs, python2-cffi, nss-mdns, qt5-qtwayland,
     libref_array, ykpers, python3-cffi, poppler, pocl, sshpass, djvulibre-
     libs, libreoffice-gtk2, cairo-gobject, raptor2, fftw-libs-double,
     containernetworking-cni, at-spi2-core, sbc, git, qt5-qtbase-gui,
     rtkit, usermode, orc, bash, glibc-common, liblockfile, dmenu, libedit,
     polkit, enchant, libuuid, subversion-libs, atk, wavpack, libarchive,
     libfreehand, libreoffice-gtk3, utf8proc, isl, libffado, cryptsetup,
     ima-evm-utils, clucene-contribs-lib, lvm2, mesa-libGLU, harfbuzz, xz,
     libXcomposite, criu, libva, libmpcdec, gtk-update-icon-cache, vim-
     minimal, harfbuzz-icu, opus, tor, tokyocabinet, zathura-ps, libqxp,
     json-c, NetworkManager-libnm, urlview, NetworkManager, libkate,
     liblangtag, hwloc-libs, llvm-libs, groff-base, libdatrie, gdk-pixbuf2,
     svgalib, libglvnd-egl, libusb, nmap-ncat, python2-libs, redland,
     python2-cccolutils, libtalloc, libldb, grep, guile, pcre-utf16,
     xorg-x11-server-Xorg, libmodplug, libepoxy, gnupg, mesa-libOpenCL,
     libcanberra, rpm-plugin-selinux, cronie-anacron, libserf, authselect,
     man-db, libcroco, libgudev, dconf, xz-libs, dbus-glib, mesa-libgbm,
     timedatex, fltk, perl-Package-Stash-XS, samba-client-libs, libdvdnav,
     libspectre, colord-libs, which, boost-chrono, libcap, libprojectM,
     aalib-libs, perl-Variable-Magic, glib-networking, rasqal, cyrus-sasl-
     ntlm, wireless-tools, libdb, compiler-rt, passwd, libcddb, gpgmepp,
     kmod-libs, libdv, libreoffice-writer, desktop-file-utils, libXdamage,
     cronie, libmatroska, libexttextcat, libmwaw, nettle, createrepo_c,
     libunwind, gtkmm30, clang5.0-libs, libtevent, nss-tools, lmdb-libs,
     libpipeline, libgpg-error-devel, libevent, tolua++, xmlsec1, iproute,
     java-openjdk, python2-gpg, findutils, popt, python2-smartcols,
     fakeroot-libs, qt5-qtx11extras, libsss_idmap, gobject-introspection,
     libpwquality, python2-librepo, libraw1394, oci-systemd-hook,
     fontconfig, krb5-workstation, libwpg, os-prober, jbigkit-libs,
     iptables, mcpp, iproute-tc, libX11, irc-otr, systemd-libs, libglvnd-
     opengl, cpio, vlc-core, libfdisk, lz4-libs, util-linux, libdaemon,
     mariadb-connector-c, NetworkManager-wifi, xlockmore, perl-Sort-Key,
     patch, krb5-libs, sqlite-libs, rpm-build-libs, libconfig, libvorbis,
     python3-librepo, pkgconf, pcre-cpp, python3-libselinux, liborcus,
     rhash, libodfgen, libwayland-client, libpciaccess, sed, libipt,
     clucene-core, libsss_autofs, perl-threads-shared, libaio, kmod,
     libxml++, nss-util, libetonyek, device-mapper, libgs, lua, libXtst,
     kpartx, libpng, xorg-x11-xauth, sssd-client, GeoIP, screen, cyrus-
     sasl, systemd, libpagemaker, dhcp-libs, hardlink, libsigc++20,
     libcollection, libXrandr, libsolv, pulseaudio-module-bluetooth,
     libxkbcommon, vulkan-loader, cairomm, perl-Unicode-UTF8, python2-rpm,
     yajl, zathura-cb, nss-softokn, crda, libXft, schroedinger, at-
     spi2-atk, libattr, qt5-qtdeclarative, libnsl2, hyphen, vo-amrwbenc,
     twolame-libs, mesa-libGL, gnupg2-smime, lpsolve, libXfont2, chromium,
     libmfx, mozjs52, xorg-x11-server-utils, torsocks, python3-libcomps,
     xmlsec1-nss, libxcrypt, gnupg2, libgcrypt, gcc-gdb-plugin, libomp,
     libverto, glibmm24, gpgme-devel, dracut, glib2-devel, libXScrnSaver,
     cracklib, procps-ng, libplacebo, libmspub, plymouth-core-libs,
     ncurses, libdnf, python3-libs, graphite2, python3-kerberos, libXpm,
     imlib2, libmad, zathura-pdf-mupdf, perl-PathTools, gmp, ipset-libs,
     libotr, pulseaudio-libs-glib2, zlib, liba52, avahi, libselinux,
     cdparanoia-libs, libreoffice-pyuno, ncurses-compat-libs, libassuan,
     perl-Unicode-Normalize, libxml2, expat, iw, libreoffice-ure, ffmpeg-
     libs, perl-interpreter, chkconfig, cyrus-sasl-gssapi, live555,
     libargon2, chromium-libs-media, mesa-vulkan-drivers, libcurl, make,
     hostname, libseccomp-devel, giblib, coreutils, protobuf-lite, libcap-
     ng, libsoup, pam, libnet, libatomic_ops, p11-kit-trust, libdca,
     pinentry, openldap, perl-Net-SSLeay, perl-Filter, librepo, audit,
     cups-libs, ipcalc, boost-locale, gdk-pixbuf2-modules, binutils,
     libsepol, gzip, gsm, libuv, boost-filesystem, speex, vim-common, lzo,
     less, neon, rest, libvpx, cyrus-sasl-ldap, libnghttp2, mercurial,
     libsamplerate, python2-lxml, libglvnd, boost-iostreams, openssl-libs,
     util-linux-user, jack-audio-connection-kit, pakchois, boost-system,
     libpcap, snap-confine, libxkbcommon-x11, subversion, apr, python3,
     libtdb, python3-gpg, libXdmcp, ipset, libxdo, xterm, perl-Socket,
     libcaca, python2-alsa, apr-util, soxr, libdrm, gpm-libs, polkit-pkla-
     compat, libvisual, pcre2, jbig2dec-libs, python2, libmtp, cyrus-sasl-
     lib, librevenge, libtirpc, qt5-qtbase, nspr, fuse-libs, python3
     -gobject-base, perl-TermReadKey, zvbi, protobuf-c, libpng-devel, perl-
     MIME-Base64, libXfixes, shared-mime-info, libglvnd-glx, runc, girara,
     sssd-nfs-idmap, libblkid, libcdio, zathura, libsigsegv, json-glib,
     libsss_sudo, libX11-xcb, libfontenc, libmodulemd, boost-thread,
     libicu, sssd-common, oci-umount, rpm, glibc, btrfs-progs, shadow-
     utils, perl-IO, lua-libs, libcgroup, pavucontrol, perl-Params-Util,
     libXaw, libXau, fipscheck, authselect-libs, bc, libssh2, gdk-
     pixbuf2-devel, mesa-libglapi, libXinerama, lirc-libs, wget, glx-utils,
     libijs, vim-enhanced, conky, libcmis, xcb-util-keysyms, libesmtp,
     libjpeg-turbo, fuse3-libs, acl, libmount, libkadm5, cyrus-sasl-scram,
     gnutls, xorg-x11-drv-fbdev, libgusb, glib2, libvncserver, libass,
     libavc1394, libtiff, wpa_supplicant, irssi, golang-github-cpuguy83-go-
     md2man, libstdc++, libffi, libmnl, libzmf, libXcursor, libXxf86vm,
     pcre, libtiger, mesa-libEGL, clang-libs, rpm-plugin-systemd-inhibit,
     mpg123-libs, systemd-pam, gstreamer1-plugins-base, spax, cairo, git-
     core, python2-gobject-base, perl-Storable, perl-Digest-MD5, grub2
     -tools-extra, cyrus-sasl-plain, libmpc, openssh-server, libXi,
     fluidsynth-libs, openjpeg2, libshout, flac-libs, taglib, libXt,
     libreoffice-pdfimport, libXv, rpm-libs, libXext, libtheora, info,
     libnfnetlink, libiec61883, device-mapper-event-libs, libkcapi,
     initscripts, plymouth, libcanberra-gtk3, device-mapper-event,
     hunspell, libsemanage, libXrender, libndp, libreoffice-base, mtdev,
     systemd-container, libcomps, mailx, systemd-udev, golang, at, file,
     curl, jsoncpp, libepubgen, libthai, bzip2, libssh, cmake, java-1.8.0
     -openjdk-headless, x265-libs, libXmu, gettext, fakeroot, pcre2-utf32,
     elfutils-libelf, nss-softokn-freebl, fipscheck-lib, libreoffice-
     impress, jasper-libs, android-tools, time, python2-pycurl,
     python3-smartcols, libutempter, device-mapper-libs, xorg-x11-xinit,
     libogg, libmetalink, libtool-ltdl, readline, libGLEW, slang,
     libstaroffice, lzo-minilzo, pcre-utf32, python2-hawkey, nss,
     diffutils, gtk3-devel, pulseaudio, e2fsprogs, chrony, grub2-tools-
     minimal, libdhash, cpp, perl-version, libksba, mpfr), /usr/lib/.build-
     id/ca(iptables, libavc1394, util-linux, chromium-libs, qt5-qtbase,
     glibc, systemd-udev, irssi, polkit-libs, policycoreutils, utf8proc,
     dhcp-libs, sssd-common, vlc-core, libpng-devel, make, binutils, fuse-
     libs)
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fuse-
     overlayfs-debuginfo , fuse-overlayfs-debugsource
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Package should not use obsolete m4 macros
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: fuse-overlayfs-0.1-3.dev.git79c70fd.fc28.x86_64.rpm
          fuse-overlayfs-debuginfo-0.1-3.dev.git79c70fd.fc28.x86_64.rpm
          fuse-overlayfs-debugsource-0.1-3.dev.git79c70fd.fc28.x86_64.rpm
          fuse-overlayfs-0.1-3.dev.git79c70fd.fc28.src.rpm
fuse-overlayfs.x86_64: W: spelling-error Summary(en_US) shiftfs -> shifts, shift's, shift
fuse-overlayfs.x86_64: W: spelling-error %description -l en_US shiftfs -> shifts, shift's, shift
fuse-overlayfs.x86_64: W: no-manual-page-for-binary fuse-overlayfs
fuse-overlayfs.src: W: spelling-error Summary(en_US) shiftfs -> shifts, shift's, shift
fuse-overlayfs.src: W: spelling-error %description -l en_US shiftfs -> shifts, shift's, shift
4 packages and 0 specfiles checked; 0 errors, 5 warnings.




Rpmlint (debuginfo)
-------------------
Checking: fuse-overlayfs-debuginfo-0.1-3.dev.git79c70fd.fc28.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
fuse-overlayfs-debugsource.x86_64: W: invalid-url URL: https://github.com/containers/fuse-overlayfs <urlopen error [Errno -2] Name or service not known>
fuse-overlayfs-debuginfo.x86_64: W: invalid-url URL: https://github.com/containers/fuse-overlayfs <urlopen error [Errno -2] Name or service not known>
fuse-overlayfs.x86_64: W: spelling-error Summary(en_US) shiftfs -> shifts, shift's, shift
fuse-overlayfs.x86_64: W: spelling-error %description -l en_US shiftfs -> shifts, shift's, shift
fuse-overlayfs.x86_64: W: invalid-url URL: https://github.com/containers/fuse-overlayfs <urlopen error [Errno -2] Name or service not known>
fuse-overlayfs.x86_64: W: no-manual-page-for-binary fuse-overlayfs
3 packages and 0 specfiles checked; 0 errors, 6 warnings.



Requires
--------
fuse-overlayfs-debugsource (rpmlib, GLIBC filtered):

fuse-overlayfs-debuginfo (rpmlib, GLIBC filtered):

fuse-overlayfs (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libfuse3.so.3()(64bit)
    libfuse3.so.3(FUSE_3.0)(64bit)
    libpthread.so.0()(64bit)
    rtld(GNU_HASH)



Provides
--------
fuse-overlayfs-debugsource:
    fuse-overlayfs-debugsource
    fuse-overlayfs-debugsource(x86-64)

fuse-overlayfs-debuginfo:
    debuginfo(build-id)
    fuse-overlayfs-debuginfo
    fuse-overlayfs-debuginfo(x86-64)

fuse-overlayfs:
    fuse-overlayfs
    fuse-overlayfs(x86-64)



Source checksums
----------------
https://github.com/containers/fuse-overlayfs/archive/79c70fd91a67861a78d336b30ce46ce34fc6712d/fuse-overlayfs-79c70fd.tar.gz :
  CHECKSUM(SHA256) this package     : 0e8ad1135891a58e55e6aba55c1769c56790cd387d31ab0c77e68354b2bee3c2
  CHECKSUM(SHA256) upstream package : 0e8ad1135891a58e55e6aba55c1769c56790cd387d31ab0c77e68354b2bee3c2


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1609598
Buildroot used: fedora-28-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v3 or later)", "Unknown or generated". 26 files have
     unknown license. Detailed output of licensecheck in /home/lsm5/1609598
     -fuse-overlayfs/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines

Frantisek, PTAL at the manual review above. Please approve if you agree or comment otherwise. Thanks.

SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lsm5/fuse-overlayfs/fedora-rawhide-x86_64/00782433-fuse-overlayfs/fuse-overlayfs-0.1-4.dev.git79c70fd.fc29.src.rpm

added Provides: bundled(gnulib)

Comment from Giuseppe Scrivano (upstream): 
---------------------------------------------------------------------------------
gnulib is a "copylib" where it is expected to statically link it.  A bunch of GNU programs are using it.  Are coreutils or wget doing anything special in the .spec file for gnulib? 
I've used commit: cb634d40c7b9bbf33fa5198d2e27fdab4c0bf143
---------------------------------------------------------------------------------

Seems OK to me now.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/fuse-overlayfs

fuse-overlayfs-0.1-4.dev.git79c70fd.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-345884d092

fuse-overlayfs-0.1-4.dev.git79c70fd.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-345884d092

fuse-overlayfs-0.1-4.dev.git79c70fd.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.