Bug 1609629 - Review Request: kwave - Sound Editor for KDE
Summary: Review Request: kwave - Sound Editor for KDE
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: kwave (view as bug list)
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2018-07-30 04:01 UTC by Sergio Monteiro Basto
Modified: 2018-07-31 20:07 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-07-31 20:07:32 UTC
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Sergio Monteiro Basto 2018-07-30 04:01:47 UTC
Spec URL: https://www.serjux.com/rpms/kwave.spec
SRPM URL: https://www.serjux.com/rpms/kwave-18.04.3-1.fc29.src.rpm

Description:
With Kwave you can record, play back, import and edit many sorts of audio files
including multi-channel files. Kwave includes some plugins to transform audio
files in several ways and presents a graphical view with a complete zoom- and
scroll capability.

Fedora Account System Username: sergiomb

Comment 1 Sergio Monteiro Basto 2018-07-30 04:02:15 UTC

*** This bug has been marked as a duplicate of bug 1186900 ***

Comment 2 Sergio Monteiro Basto 2018-07-30 04:06:30 UTC
*** Bug 1186900 has been marked as a duplicate of this bug. ***

Comment 3 Robert-André Mauchin 2018-07-30 14:06:29 UTC
 - None of these scriptlets are used anymore:

%post
/sbin/ldconfig
/usr/bin/update-desktop-database &> /dev/null || :
/bin/touch --no-create %{_kf5_datadir}/icons/hicolor &>/dev/null || :

%postun
/sbin/ldconfig
/usr/bin/update-desktop-database &> /dev/null || :
if [ $1 -eq 0 ] ; then
    /bin/touch --no-create %{_kf5_datadir}/icons/hicolor &>/dev/null
    /usr/bin/gtk-update-icon-cache %{_kf5_datadir}/icons/hicolor &>/dev/null || :
fi

%posttrans
/usr/bin/gtk-update-icon-cache %{_kf5_datadir}/icons/hicolor &>/dev/null || :


You can safely remove them. If you plan to support F27, add: %ldconfig_scriptlets

 - Don't set the checks to always true with "||:" :

%check
appstream-util validate-relax --nonet %{buildroot}%{_kf5_metainfodir}/org.kde.%{name}.appdata.xml
desktop-file-validate %{buildroot}%{_kf5_datadir}/applications/org.kde.%{name}.desktop

 - The icons should not be gzipped:

kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_end.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_fwd.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_loop.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_pause.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_pause_2.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_play.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_record.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_rew.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_start.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_stop.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_viewmag.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_viewmagfit.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_zoom_in.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_zoom_original.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_zoom_out.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/apps/kwave.svgz





Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2 or later)", "Unknown or generated", "*No copyright*
     GFDL CC0 (v1.0) GPL (v2)", "*No copyright* BSD (3 clause)", "BSD (2
     clause) GPL (v2 or later)", "BSD (3 clause)", "CC by-sa (v4.0)", "GPL
     (v2)". 529 files have unknown license. Detailed output of licensecheck
     in /home/bob/packaging/review/kwave/review-kwave/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 81920 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kwave-
     doc , kwave-debuginfo , kwave-debugsource
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 3133440 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: kwave-18.04.3-1.fc29.x86_64.rpm
          kwave-doc-18.04.3-1.fc29.noarch.rpm
          kwave-debuginfo-18.04.3-1.fc29.x86_64.rpm
          kwave-debugsource-18.04.3-1.fc29.x86_64.rpm
          kwave-18.04.3-1.fc29.src.rpm
kwave.x86_64: I: enchant-dictionary-not-found de
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_end.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_fwd.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_loop.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_pause.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_pause_2.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_play.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_record.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_rew.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_start.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_player_stop.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_viewmag.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_viewmagfit.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_zoom_in.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_zoom_original.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/kwave_zoom_out.svgz
kwave.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/apps/kwave.svgz
kwave.x86_64: W: no-manual-page-for-binary kwave
5 packages and 0 specfiles checked; 0 errors, 17 warnings.

Comment 4 Sergio Monteiro Basto 2018-07-30 16:47:55 UTC
Spec URL: https://www.serjux.com/rpms/kwave.spec
SRPM URL: https://www.serjux.com/rpms/kwave-18.04.3-1.fc29.src.rpm

Scriplets fixed, I don't know  how to fix gzipped icons

Comment 5 Robert-André Mauchin 2018-07-30 19:37:26 UTC
 - Simply add in %install:

gzip -dS z %{buildroot}%{_datadir}/icons/hicolor/scalable/actions/*.svgz
gzip -dS z %{buildroot}%{_datadir}/icons/hicolor/scalable/apps/kwave.svgz


 → -d = -d --decompress
 → -S z = When decompressing, add .z to the beginning of the list of suffixes to try, when deriving an output file name from an input file name.


Package is approved, just add the ungzipping before import.

Comment 6 Sergio Monteiro Basto 2018-07-30 20:04:50 UTC
OK , thanks

Comment 7 Igor Gnatenko 2018-07-31 06:38:56 UTC
Missing BuildRequires for compiler. Whether it is gcc or gcc-c++.

Comment 8 Igor Gnatenko 2018-07-31 06:39:13 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/kwave

Comment 9 Sergio Monteiro Basto 2018-07-31 14:08:38 UTC
(In reply to Igor Gnatenko from comment #7)
> Missing BuildRequires for compiler. Whether it is gcc or gcc-c++.

[1]  gcc and gcc-c++ appears in Installing dependencies, should I explicitly add BR gcc gcc-c++ ? 

Thanks

https://koji.fedoraproject.org/koji/taskinfo?taskID=28707198
https://kojipkgs.fedoraproject.org//work/tasks/7198/28707198/root.log

Comment 10 Robert-André Mauchin 2018-07-31 14:21:49 UTC
(In reply to Igor Gnatenko from comment #7)
> Missing BuildRequires for compiler. Whether it is gcc or gcc-c++.

Same question as Sergio, since gcc-c++ is already implied by the BR, is it necessary to add them?

Comment 11 Igor Gnatenko 2018-07-31 18:24:22 UTC
Relying on transitive dependencies is bad.

Comment 12 Sergio Monteiro Basto 2018-07-31 20:07:32 UTC
Thank you .

About BR gcc, I'll see how the other Qt / KDE packages behave


Note You need to log in before you can comment on or make changes to this bug.