Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1609871

Summary: Istio sidecar injection fails for replicasets with resource requests specified
Product: OpenShift Container Platform Reporter: Ben Browning <bbrownin>
Component: MasterAssignee: Stefan Schimanski <sttts>
Status: CLOSED ERRATA QA Contact: Xingxing Xia <xxia>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.10.0CC: aos-bugs, jokerman, mmccomas, pmorie, travi
Target Milestone: ---   
Target Release: 3.10.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-08-31 06:18:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
ReplicaSet to trigger bug none

Description Ben Browning 2018-07-30 17:06:12 UTC 
Created attachment 1471596 [details]
ReplicaSet to trigger bug

Description of problem:

Creating a replicaset that contains a resource request (such as https://gist.github.com/bbrowning/839eb7166261f8c1238a6f024981ae17) fails to ever spin up a pod when Istio is also installed and auto sidecar injection enabled for this namespace.

It fails with events like:

Warning FailedCreate 4m (x17 over 6m) replicaset-controller Error
creating: Internal error occurred: Internal error occurred:
reflect.Value.Addr of unaddressable value

https://github.com/kubernetes/kubernetes/pull/64255/files#diff-e057ec5b2ec27b4ba1e1a3915f715262L118 is cited as a potential fix, with its corresponding Kubernetes 1.10 backport at https://github.com/kubernetes/kubernetes/pull/64971

Neither of those fixes have been tested yet.

This issue does not happen with the same replicaset under Kubernetes 1.10.5.


Version-Release number of selected component (if applicable):

OpenShift Origin v3.10.0-rc.0
Istio v0.8


How reproducible:

happens every time


Steps to Reproduce:

For reference, the exact steps I took are listed at https://gist.github.com/bbrowning/b0e8fd32dd75a264062b2bd3bb17526e . More generic steps are listed below.

1. Install Istio 0.8 into an OpenShift Origin 3.10.0-rc.0 cluster, following the steps at https://istio.io/docs/setup/kubernetes/quick-start/#openshift-origin (Ensure Mutating & Validating webhooks are enabled, all the oc adm policy bits, install Istio itself using the istio-demo.yaml file)
2. oc adm policy add-scc-to-user privileged -z default -n default
3. oc label namespace default istio-injection=enabled
4. oc project default
5. Deploy a replicaset such as the one attached, with a resource request specified

Actual results:
The pod for the replicaset never comes up. oc describe rs - you should see the "reflect.Value.Addr of unaddressable value" error


Expected results:
The pod should come up without error.


Additional info:

This blocks being able to install Knative on OpenShift 3.10.
Comment 1 Paul Morie 2018-07-30 17:16:47 UTC 
Changed the parameters of the bug a little bit.
Comment 3 Stefan Schimanski 2018-08-06 09:42:57 UTC 
The backport https://github.com/openshift/origin/pull/20509 has merged into the 3.10 branch.
Comment 5 Xingxing Xia 2018-08-21 09:06:08 UTC 
Verified in openshift v3.10.28. The pod can come up.
Comment 7 errata-xmlrpc 2018-08-31 06:18:10 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2376