Bug 1609884 - ovirt-release-master for centos doesn't contain current ovirt-web-ui
Summary: ovirt-release-master for centos doesn't contain current ovirt-web-ui
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-release
Classification: oVirt
Component: General
Version: ---
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.3.0
: ---
Assignee: Sandro Bonazzola
QA Contact:
Rolfe Dlugy-Hegwer
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-07-30 17:49 UTC by Greg Sheremeta
Modified: 2019-02-13 07:44 UTC (History)
10 users (show)

Fixed In Version: ovirt-release43-4.3.0_rc1
Clone Of:
Environment:
Last Closed: 2019-02-13 07:44:57 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-4.3+
rule-engine: blocker+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 93910 0 master MERGED repos: update ovirt-web-ui repo 2018-08-27 11:50:07 UTC

Description Greg Sheremeta 2018-07-30 17:49:47 UTC
Description of problem:
ovirt-release-master for centos doesn't contain Marek's people.redhat.com or copr repo, so an old copy of ovirt-web-ui in snapshots-static is used on a fresh c7 machine

Version-Release number of selected component (if applicable):
4.2.4

Comment 1 Red Hat Bugzilla Rules Engine 2018-07-31 06:26:26 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 2 Sandro Bonazzola 2018-08-02 14:28:52 UTC
I'm not sure adding the centos copr repo from mlibra to master release rpm is the right thing to do.

ovirt-web-ui is an oVirt project and should be built nightly in Jenkins or TravisCI go through OST (selenium) testing and land on ovirt-master-snapshot automatically.

Last patch tested on Jenkins for this project is from February 2017: https://jenkins.ovirt.org/job/ovirt-web-ui_master_github_check-merged-el7-x86_64/

I see Travis CI is testing this (example: https://travis-ci.org/oVirt/ovirt-web-ui/builds/411249261?utm_source=github_status&utm_medium=notification )

I think that right thing to do here should be add the missing automation piece to get a rpmbuild added to the change queue after merge of the PR.

On 4.2/stable we publish the released builds from mlibra copr into 4.2 stable repo. On fedora side we just included the copr repo being fedora not fully supported yet.

Marek, you're the maintainer there, what do you think?

Comment 3 Greg Sheremeta 2018-08-02 14:44:28 UTC
I took this over for Marek :)

> I think that right thing to do here should be add the missing automation piece to get a rpmbuild added to the change queue after merge of the PR.

I agree. But how to do that without having ovirt CI do the builds? We want to keep travis for now.

Comment 4 Marek Libra 2018-08-03 06:24:05 UTC
It was intended to keep ovirt-web-ui as an independent project building on common infrastructure (like travis or github). The project integrates on API level only and from this perspective it is just one of (multiple) clients.

Historically, oVirt's automation was added to the project but removed later for the reasons stated above.

Builds are published to yum repo under people.redhat.com. Any other stable location (means not copr) should be ok.

Selected releases/builds were added to oVirt's releng-tools for their inclusion in particular oVirt releases.

Comment 5 Greg Sheremeta 2018-08-03 14:49:31 UTC
(In reply to Marek Libra from comment #4)
> Any other stable location (means not copr) should be ok.

I'm going to try copr actually. It's been heavily used for years and really should be stable by now.

Thanks!

Comment 6 Raz Tamir 2018-08-22 14:38:52 UTC
Any update on this?
Is it still considered as a blocker?

Comment 7 Greg Sheremeta 2018-08-22 16:56:35 UTC
Yes, the rpm now exists at
https://copr.fedorainfracloud.org/coprs/ovirtwebui/ovirt-web-ui/


IMO it's a 4.2.6 blocker, but it's @Michal's decision

Comment 8 Michal Skrivanek 2018-08-22 19:08:21 UTC
Why a blocker foe 4.2? This is about master only. 4.2 is done differently.

Comment 9 Greg Sheremeta 2018-08-22 20:26:50 UTC
(In reply to Michal Skrivanek from comment #8)
> Why a blocker foe 4.2? This is about master only. 4.2 is done differently.

Oh, sorry for the noise then.

Comment 10 Sandro Bonazzola 2018-09-06 07:49:21 UTC
ovirt-release-master included in master repo contains this fix

Comment 11 Sandro Bonazzola 2018-11-02 15:05:48 UTC
Closed by mistake, moving back to qa -> verified

Comment 12 Rolfe Dlugy-Hegwer 2019-01-21 12:40:19 UTC
Hi Sandro. How does the current Doc Type and Doc Text look to you? Please feel free to update. Thanks!

Comment 13 Sandro Bonazzola 2019-01-21 12:43:04 UTC
(In reply to Rolfe Dlugy-Hegwer from comment #12)
> Hi Sandro. How does the current Doc Type and Doc Text look to you? Please
> feel free to update. Thanks!

Looks good to me, thanks!

Comment 14 Sandro Bonazzola 2019-02-13 07:44:57 UTC
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.