Bug 1609947 - Event notifications: distant position of Do Not Disturb dropdown
Summary: Event notifications: distant position of Do Not Disturb dropdown
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.2.5
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.3.1
: ---
Assignee: Greg Sheremeta
QA Contact: Pavel Novotny
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-07-30 21:34 UTC by Pavel Novotny
Modified: 2019-03-01 10:17 UTC (History)
4 users (show)

Fixed In Version: ovirt-engine-4.3.1.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-03-01 10:17:47 UTC
oVirt Team: UX
michal.skrivanek: ovirt-4.3?
pnovotny: testing_plan_complete-
pnovotny: planning_ack?
rule-engine: devel_ack+
pnovotny: testing_ack+

Attachments (Terms of Use)
Do Not Disturb - distant dropdown (198.21 KB, image/png)
2018-07-30 21:34 UTC, Pavel Novotny 		no flags Details
ovirt fixed 1 (124.21 KB, image/png)
2018-10-02 20:57 UTC, Greg Sheremeta 		no flags Details
rhv fixed 1 (110.80 KB, image/png)
2018-10-02 20:57 UTC, Greg Sheremeta 		no flags Details
Do Not Disturb - distant dropdown #2 (118.86 KB, image/png)
2018-10-18 12:30 UTC, Pavel Novotny 		no flags Details
Do Not Disturb - distant dropdown #2 (118.86 KB, image/png)
2018-10-18 12:49 UTC, Pavel Novotny 		no flags Details
fixed - demo (2.78 MB, application/x-matroska)
2019-01-31 02:24 UTC, Greg Sheremeta 		no flags Details
fixed - screen (87.33 KB, image/png)
2019-01-31 02:24 UTC, Greg Sheremeta 		no flags Details
fixed - DnD list alignment (39.58 KB, image/png)
2019-02-25 17:01 UTC, Pavel Novotny 		no flags Details
Show Obsolete (3) View All


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 97441 0 master MERGED webadmin: notification drawer buttons always visible 2019-01-31 14:26:09 UTC

Description Pavel Novotny 2018-07-30 21:34:25 UTC 
Created attachment 1471644 [details]
Do Not Disturb - distant dropdown

Description of problem:
The dropdown for Do Not Disturb button should be placed right under it.
However it is placed at the end of the notifications.

Version-Release number of selected component (if applicable):
ovirt-engine-4.2.5.2-0.1.el7ev.noarch
ovirt-engine-webadmin-portal-4.2.5.2-0.1.el7ev.noarch

Browsers: Firefox 52 ESR & 62b12, Chromium 67

How reproducible:
100%

Steps to Reproduce:
1. Having multiple event notification, click on the Do No Disturb button.
2. Check position of the dropdown.
3.

Actual results:
It is placed at the end of the notifications.
See attached screenshot.

Expected results:
The dropdown should be displayed right under the button, like here https://i.imgur.com/BOPonyM.png

Additional info:
Comment 1 Greg Sheremeta 2018-08-01 18:17:48 UTC 
can you paste the results of

`rpm -qa ovirt-js-dependencies`

thanks
Comment 2 Pavel Novotny 2018-08-02 13:41:53 UTC 
Sure.

# rpm -qa ovirt-js-dependencies
ovirt-js-dependencies-1.2.0-3.1.el7ev.noarch
Comment 3 Greg Sheremeta 2018-10-02 20:57:07 UTC 
Should be ok on the next build, please re-test
Comment 4 Greg Sheremeta 2018-10-02 20:57:38 UTC 
Created attachment 1489633 [details]
ovirt fixed 1
Comment 5 Greg Sheremeta 2018-10-02 20:57:58 UTC 
Created attachment 1489634 [details]
rhv fixed 1
Comment 6 Pavel Novotny 2018-10-18 12:29:21 UTC 
FailedQA in
ovirt-engine-4.2.7.2-0.1.el7ev.noarch
ovirt-engine-webadmin-portal-4.2.7.2-0.1.el7ev.noarch

The problem are not the buttons Dismiss All and Do Not Disturb
but the options for Do Not Disturb (for 10 minutes, for 1 hour, ...) that are displayed under all the notifications.
Comment 7 Pavel Novotny 2018-10-18 12:30:30 UTC 
Created attachment 1495281 [details]
Do Not Disturb - distant dropdown #2
Comment 8 Pavel Novotny 2018-10-18 12:49:00 UTC 
Created attachment 1495283 [details]
Do Not Disturb - distant dropdown #2
Comment 9 Michal Skrivanek 2018-10-22 07:46:24 UTC 
pushing out to 4.3
Comment 10 Sandro Bonazzola 2019-01-28 09:39:46 UTC 
This bug has not been marked as blocker for oVirt 4.3.0.
Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.
Comment 11 Greg Sheremeta 2019-01-31 01:33:15 UTC 
this was indeed a tiny CSS problem
Comment 12 Greg Sheremeta 2019-01-31 02:24:02 UTC 
Created attachment 1525221 [details]
fixed - demo
Comment 13 Greg Sheremeta 2019-01-31 02:24:23 UTC 
Created attachment 1525222 [details]
fixed - screen
Comment 14 Pavel Novotny 2019-02-25 17:00:54 UTC 
Verified in
ovirt-engine-4.3.1.1-0.1.el7.noarch
ovirt-engine-webadmin-portal-4.3.1.1-0.1.el7.noarch

The DnD dropdown list is now aligned under the Do Not Disturb toggle.
Comment 15 Pavel Novotny 2019-02-25 17:01:32 UTC 
Created attachment 1538524 [details]
fixed - DnD list alignment
Comment 16 Sandro Bonazzola 2019-03-01 10:17:47 UTC 
This bugzilla is included in oVirt 4.3.1 release, published on February 28th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Note You need to log in before you can comment on or make changes to this bug.