RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1610335 - unable to open Additional Layout Options in tweak tool
Summary: unable to open Additional Layout Options in tweak tool
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: gnome-tweak-tool
Version: 7.6
Hardware: x86_64
OS: Linux
high
medium
Target Milestone: rc
: ---
Assignee: Milan Crha
QA Contact: Desktop QE
URL: http://faf.lab.eng.brq.redhat.com/faf...
Whiteboard:
Depends On:
Blocks: 1649362 1656436 1664791
TreeView+ depends on / blocked
 
Reported: 2018-07-31 12:43 UTC by Tomas Hudziec
Modified: 2019-08-07 12:48 UTC (History)
6 users (show)

Fixed In Version: gnome-tweak-tool-3.28.1-3.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1664791 (view as bug list)
Environment:
Last Closed: 2019-08-07 12:48:33 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Tomas Hudziec 2018-07-31 12:43:46 UTC
Description of problem:
Additional Layout Options dialog window cannot be opened in gnome tweak tool and error with traceback is printed into terminal.

Version-Release number of selected component (if applicable):
gnome-tweak-tool-3.28.1-2.el7.noarch

How reproducible:
always

Steps to Reproduce:
1. $ gnome-tweaks
2. click on Keyboard & Mouse button in left panel
3. click on Additional Layout Options button

Actual results:
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_keymouse.py", line 245, in _on_browse_clicked
    box = TypingTweakGroup()
  File "/usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_xkb.py", line 167, in __init__
    TweakGroup.__init__(self, _("Typing"), *self._option_objects)
TypeError: unbound method __init__() must be called with TweakGroup instance as first argument (got TypingTweakGroup instance instead)


Expected results:
some dialog window with Additional Layout Options should be opened

Additional info:

Comment 7 Shing-Shong Shei 2019-02-15 17:54:14 UTC
Maybe just a missing argument?

--- /usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_xkb.py	2019-02-15 12:46:27.000000000 -0500
+++ /usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_xkb.py-	2018-07-18 07:27:01.000000000 -0400
@@ -135,7 +135,7 @@
         elif active and not w._val in self._values and w._val:
             self._parent_settings.setting_add_to_list(TypingTweakGroup.XKB_GSETTINGS_NAME, w._val)
 
-class TypingTweakGroup(Gtk.Box, TweakGroup):
+class TypingTweakGroup(Gtk.Box):
 
     XKB_GSETTINGS_SCHEMA = "org.gnome.desktop.input-sources"
     XKB_GSETTINGS_NAME = "xkb-options"

Comment 8 schanzle 2019-03-18 22:58:25 UTC
Confusingly, with CentOS 7.6 gnome-tweak-tool-3.28.1-2.el7.noarch, I could not get the Additional Layout Options to open and got a similar traceback:

  File "/usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_keymouse.py", line 245, in _on_browse_clicked
    box = TypingTweakGroup()
  File "/usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_xkb.py", line 167, in __init__
    TweakGroup.__init__(self, _("Typing"), *self._option_objects)
TypeError: unbound method __init__() must be called with TweakGroup instance as first argument (got TypingTweakGroup instance instead)

Seems my system is patched per comment #7:

$ grep '^class TypingTweakGroup(Gtk.Box' tweak_group_xkb.py
class TypingTweakGroup(Gtk.Box):


so I just made a reverse patch:

--- usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_xkb.py.fcs	2018-11-02 11:49:10.000000000 -0400
+++ usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_xkb.py	2019-03-15 15:29:41.982656983 -0400
@@ -135,7 +135,7 @@
         elif active and not w._val in self._values and w._val:
             self._parent_settings.setting_add_to_list(TypingTweakGroup.XKB_GSETTINGS_NAME, w._val)
 
-class TypingTweakGroup(Gtk.Box):
+class TypingTweakGroup(Gtk.Box, TweakGroup):
 
     XKB_GSETTINGS_SCHEMA = "org.gnome.desktop.input-sources"
     XKB_GSETTINGS_NAME = "xkb-options"


Works great after restarting gnome-tweaks.

Comment 9 schanzle 2019-03-18 23:01:51 UTC
With further review, it seems comment #7 just posted the patch reversed.  Sorry for the noise.

Comment 10 Shing-Shong Shei 2019-03-18 23:15:44 UTC
(In reply to schanzle from comment #9)
> With further review, it seems comment #7 just posted the patch reversed. 
> Sorry for the noise.

Yes, I did the diff in reverse order. Sorry about the mistake.


Note You need to log in before you can comment on or make changes to this bug.