Bug 1610335
| Summary: | unable to open Additional Layout Options in tweak tool | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Tomas Hudziec <thudziec> | |
| Component: | gnome-tweak-tool | Assignee: | Milan Crha <mcrha> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Desktop QE <desktop-qa-list> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | high | |||
| Version: | 7.6 | CC: | afox, csoriano, schanzle, shei, tpelka, vanhoof | |
| Target Milestone: | rc | Keywords: | ZStream | |
| Target Release: | --- | |||
| Hardware: | x86_64 | |||
| OS: | Linux | |||
| URL: | http://faf.lab.eng.brq.redhat.com/faf/problems/bthash/?bth=95269d8b1017fc32755d2acbba57370a7efa2a9a | |||
| Whiteboard: | ||||
| Fixed In Version: | gnome-tweak-tool-3.28.1-3.el7 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1664791 (view as bug list) | Environment: | ||
| Last Closed: | 2019-08-07 12:48:33 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1649362, 1656436, 1664791 | |||
Maybe just a missing argument?
--- /usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_xkb.py 2019-02-15 12:46:27.000000000 -0500
+++ /usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_xkb.py- 2018-07-18 07:27:01.000000000 -0400
@@ -135,7 +135,7 @@
elif active and not w._val in self._values and w._val:
self._parent_settings.setting_add_to_list(TypingTweakGroup.XKB_GSETTINGS_NAME, w._val)
-class TypingTweakGroup(Gtk.Box, TweakGroup):
+class TypingTweakGroup(Gtk.Box):
XKB_GSETTINGS_SCHEMA = "org.gnome.desktop.input-sources"
XKB_GSETTINGS_NAME = "xkb-options"
Confusingly, with CentOS 7.6 gnome-tweak-tool-3.28.1-2.el7.noarch, I could not get the Additional Layout Options to open and got a similar traceback:
File "/usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_keymouse.py", line 245, in _on_browse_clicked
box = TypingTweakGroup()
File "/usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_xkb.py", line 167, in __init__
TweakGroup.__init__(self, _("Typing"), *self._option_objects)
TypeError: unbound method __init__() must be called with TweakGroup instance as first argument (got TypingTweakGroup instance instead)
Seems my system is patched per comment #7:
$ grep '^class TypingTweakGroup(Gtk.Box' tweak_group_xkb.py
class TypingTweakGroup(Gtk.Box):
so I just made a reverse patch:
--- usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_xkb.py.fcs 2018-11-02 11:49:10.000000000 -0400
+++ usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_xkb.py 2019-03-15 15:29:41.982656983 -0400
@@ -135,7 +135,7 @@
elif active and not w._val in self._values and w._val:
self._parent_settings.setting_add_to_list(TypingTweakGroup.XKB_GSETTINGS_NAME, w._val)
-class TypingTweakGroup(Gtk.Box):
+class TypingTweakGroup(Gtk.Box, TweakGroup):
XKB_GSETTINGS_SCHEMA = "org.gnome.desktop.input-sources"
XKB_GSETTINGS_NAME = "xkb-options"
Works great after restarting gnome-tweaks.
With further review, it seems comment #7 just posted the patch reversed. Sorry for the noise. (In reply to schanzle from comment #9) > With further review, it seems comment #7 just posted the patch reversed. > Sorry for the noise. Yes, I did the diff in reverse order. Sorry about the mistake. |
Description of problem: Additional Layout Options dialog window cannot be opened in gnome tweak tool and error with traceback is printed into terminal. Version-Release number of selected component (if applicable): gnome-tweak-tool-3.28.1-2.el7.noarch How reproducible: always Steps to Reproduce: 1. $ gnome-tweaks 2. click on Keyboard & Mouse button in left panel 3. click on Additional Layout Options button Actual results: Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_keymouse.py", line 245, in _on_browse_clicked box = TypingTweakGroup() File "/usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_xkb.py", line 167, in __init__ TweakGroup.__init__(self, _("Typing"), *self._option_objects) TypeError: unbound method __init__() must be called with TweakGroup instance as first argument (got TypingTweakGroup instance instead) Expected results: some dialog window with Additional Layout Options should be opened Additional info: