Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://copr-be.cloud.fedoraproject.org/results/tendrl/release/epel-7-x86_64/00777272-tendrl-node-agent/tendrl-node-agent.spec https://github.com/Tendrl/node-agent/blob/master/tendrl-node-agent.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/tendrl/release/epel-7-x86_64/00777272-tendrl-node-agent/tendrl-node-agent-1.6.3-9.el7.src.rpm Github url: https://github.com/Tendrl/node-agent Description: Hi I have finished packaging up tendrl-node-agent. Tendrl node agent resides on every node managed by tendrl. It is responsible for operating system level operations such as hardware inventory, service management, process monitoring etc. The node agent also serves as the provisioning controller and can invoke provisioning operations on the node. I would appreciate a review so that I can get it into Fedora Extras!. Thank you! Fedora Account System Username: timothyasir
- %{__python} setup.py build → %py3_build - %{__python} setup.py install --single-version-externally-managed -O1 --root=$RPM_BUILD_ROOT → %py3_install - Source0 must point to a URL - Package must be Python3, you mist not require python-X package as this is deprecated. Python 2 is also deprecated. - If you install systemd files you must require: %{?systemd_requires} BuildRequires: systemd - Keep timestamps with install-p - These permissions are not standard, please provide rationale. It should be 0644 %attr(0655, root, root) %{_sysconfdir}/collectd_template/* %attr(0655, root, root) %{_libdir}/collectd/* - Add your own %changelog entry
Timothy, is this review stale?
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.