Bug 1611928 - abrt automatic reporting of application crashes is abysmally inefficient
Summary: abrt automatic reporting of application crashes is abysmally inefficient
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: abrt
Version: 28
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: abrt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-03 05:02 UTC by John Reiser
Modified: 2019-05-28 22:41 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-05-28 22:41:21 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
/var/spool/abrt/ccpp-2018-08-02-15:21:39.339717-2341/event_log (truncated at beginning by abrt) (20.46 KB, text/plain)
2018-08-03 05:02 UTC, John Reiser
no flags Details

Description John Reiser 2018-08-03 05:02:42 UTC
Created attachment 1472878 [details]
/var/spool/abrt/ccpp-2018-08-02-15:21:39.339717-2341/event_log (truncated at beginning by abrt)

Description of problem: Automatic reporting of application crashes by 
abrt is horribly inefficient.  In important cases it is a factor of 30 slower than necessary for SIGSEGV in a large application such as thunderbird.

I suffered the crash and watched the automatic reporting by abrt of https://bugzilla.redhat.com/show_bug.cgi?id=1611852: [abrt] thunderbird: nsProfileLock::FatalSignalHandler(): thunderbird killed by SIGSEGV.  abrt took over half an hour, including over 20 minutes using nearly 100% of 1 CPU, to report the crash.  It should have taken around 1 minute.  event_log is attached.

86 debuginfo files required fetching, expanding to over 1GB of disk space.  Two debuginfo were gigantic: thunderbird and one other.  abrt truncated the beginning of the event_log, but I watched System tools > Monitor and /usr/bin/top.  Unpacking debuginfo for thunderbird took over 60 seconds of at least 98% CPU.  abrt did nothing else while expanding, not even downloading the other files.  In contrast, it is easy for one process to download a list of .debuginfo.rpm files, writing into a pipe the name of each resulting file as it is received.  The second process reads filenames from the pipe and expands each .debuginfo.rpm in turn.  This two-stage pipeline achieves maximal overlap, and the savings is likely to be significant when there is at least one large debuginfo.rpm.

Then the backtrace.  There were 5 separate attempts, setting the depth limit on number of frames to 1024, 512, 256, 128, and 64.  Each attempt except the last took 4 minutes of 100% CPU.  The first 4 attempts were discarded because the output was too long at 267161 bytes (1/4 MB).  By looking at the final, accepted backtrace https://bugzilla.redhat.com/attachment.cgi?id=1472829 it can be seen that using the actual number of discovered frames (15 + 1) is a much better metric than the size in bytes.  A line that begins with '#' is an easy heuristic for a discovered frame.

Even the final accepted backtrace took nearly 2 minutes to compute only 16 frames.  Yes, the map of program counter to line number is intricate; but process it once to produce a table that can be searched quickly.  And pipeline the construction of the table with decompression of the file.

Version-Release number of selected component (if applicable):
abrt-2.10.10-1.fc28.x86_64


How reproducible: did not try


Steps to Reproduce:
1. wait for thunderbird to die from SIGSEGV
2. wait for abrt to report the crash in thunderbird
3.

Actual results: abrt takes over half an hour to report the crash.


Expected results: abrt takes one minute to report the crash.


Additional info: 3.3 GHz Intel Core-i5 with 32BG DDR3.

Comment 1 Ben Cotton 2019-05-02 20:46:44 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 2 Ben Cotton 2019-05-28 22:41:21 UTC
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.