Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1612019 - [W21FD0v0] env COMMIT_INTERVAL does not work when router dynamic changes enabled
[W21FD0v0] env COMMIT_INTERVAL does not work when router dynamic changes enabled
Status: CLOSED ERRATA
Product: OpenShift Container Platform
Classification: Red Hat
Component: Routing (Show other bugs)
3.11.0
Unspecified Unspecified
medium Severity medium
: ---
: 3.11.0
Assigned To: Ram Ranganathan
zhaozhanqi
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2018-08-03 05:24 EDT by hongli
Modified: 2018-10-11 03:23 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2018-10-11 03:23:29 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Github https://github.com/openshift/origin/pull/20559 None None None 2018-08-07 18:44 EDT
Red Hat Product Errata RHBA-2018:2652 None None None 2018-10-11 03:23 EDT

  None (edit)
Description hongli 2018-08-03 05:24:12 EDT
Description of problem:
the env COMMIT_INTERVAL does not work when router dynamic changes enabled

Version-Release number of selected component (if applicable):
openshift v3.11.0-0.10.0
kubernetes v1.11.0+d4cacc0

How reproducible:
always

Steps to Reproduce:
1. enable dynamic changes and set COMMIT_INTERVAL
$ oc set env dc/router ROUTER_HAPROXY_CONFIG_MANAGER=true COMMIT_INTERVAL=300s
2. create your project, pod, svc and route.
$ oc create -f https://raw.githubusercontent.com/openshift-qe/v3-testfiles/master/routing/caddy-docker.json
$ oc create -f https://raw.githubusercontent.com/openshift-qe/v3-testfiles/master/routing/edge/service_unsecure.json
$ oc expose svc service-unsecure
3. check the router reloaded in logs
$ oc logs router-x-xxxxx

Actual results:
wait more than 300s but no router reloaded in logs, the route is reachable but settings are not committed to haproxy.conf

Expected results:
the dynamic changes should be committed to haproxy.config in COMMIT_INTERVAL.

Additional info:
try to use the default 3600s setting (do not set COMMIT_INTERVAL env), wait for more than one hour but no router reloaded.  

code:
// defaultCommitInterval is how often (in seconds) to commit the "in-memory"
// router changes made using the dynamic configuration manager.
const defaultCommitInterval = 60 * 60
Comment 1 Ram Ranganathan 2018-08-06 19:36:26 EDT
@hongli, good catch ... aargh, the reason the router doesn't reload is because
it doesn't find any config changes. 

Fixed with PR: https://github.com/openshift/origin/pull/20559

Thx
Comment 3 hongli 2018-08-23 03:18:40 EDT
verified in atomic-openshift-3.11.0-0.20.0.git.0.d80d8ad.el7 and the issue has been fixed.
Comment 5 errata-xmlrpc 2018-10-11 03:23:29 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2652

Note You need to log in before you can comment on or make changes to this bug.