Spec URL: https://fedorapeople.org/~otaylor/regindexer.spec SRPM URL: https://fedorapeople.org/~otaylor/regindexer-0.1-1.fc27.src.rpm Description: regindexer is a tool for creating an index of a container registry. It can be run manually from the command line, or can run as a fedmsg consumer, rebuilding the index when it sees messages from Bodhi. Fedora Account System Username: otaylor
This is an informal review. Some minor comments: - You may consider using %{name} to avoid repeating "regindexer". - You may consider using %{py3_dist} to list dependencies. https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names - Given that you are the upstream maintainer, please consider adding a man page. Apart from that, looks good to me. Here's the entire report: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: regindexer-0.1-1.fc28.noarch.rpm regindexer-0.1-1.fc28.src.rpm regindexer.noarch: W: spelling-error %description -l en_US fedmsg -> Feds regindexer.noarch: W: non-standard-uid /var/lib/regindexer fedmsg regindexer.noarch: W: non-standard-gid /var/lib/regindexer fedmsg regindexer.noarch: W: no-manual-page-for-binary regindexer regindexer.src: W: spelling-error %description -l en_US fedmsg -> Feds 2 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory regindexer.noarch: W: spelling-error %description -l en_US fedmsg -> Feds regindexer.noarch: W: invalid-url URL: https://pagure.io/regindexer <urlopen error [Errno -2] Name or service not known> regindexer.noarch: W: non-standard-uid /var/lib/regindexer fedmsg regindexer.noarch: W: non-standard-gid /var/lib/regindexer fedmsg regindexer.noarch: W: no-manual-page-for-binary regindexer 1 packages and 0 specfiles checked; 0 errors, 5 warnings. Requires -------- regindexer (rpmlib, GLIBC filtered): /usr/bin/python3 config(regindexer) python(abi) python3-PyYAML python3-click python3-fedmsg python3-requests python3-six Provides -------- regindexer: config(regindexer) python3.6dist(regindexer) python3dist(regindexer) regindexer Source checksums ---------------- https://releases.pagure.org/regindexer/regindexer-0.1.tar.gz : CHECKSUM(SHA256) this package : 2db80cb68e36e1644376d8d1dbd97c151c258667d4952a6fb94a0aa7ffaed7b6 CHECKSUM(SHA256) upstream package : 2db80cb68e36e1644376d8d1dbd97c151c258667d4952a6fb94a0aa7ffaed7b6 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1612141 Buildroot used: fedora-28-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
- Additionally: %{python3_sitelib}/* is now verboten. Be more specific instead of a glob. (See https://pagure.io/packaging-committee/issue/782)
Thanks for the comments! I used %{py3_dist} and got rid of %{python3_sitelib}/*, but I decided against adding the man pages, because this is a pretty specialized project (mostly for Fedora infrastructure), and I don't want the overhead of keeping them in sync with the README.md. The larger change is that I switched the "daemon mode" upstream from a fedmsg-hub plugin to a standalone-daemon that reads from fedmsg. This is in preparation for the planned Fedora infrastructure move to This involved specfile changes like adding a unit file and a regindexer user. I intentionally did *not* add Requires: systemd, to support use cases like running as pid 1 in a container. Spec URL: https://fedorapeople.org/~otaylor/regindexer.spec SRPM URL: https://fedorapeople.org/~otaylor/regindexer-0.2-1.fc28.src.rpm
I meant to say "This is in preparation for the planned Fedora infrastructure move to fedora-messaging, which doesn't have an equivalent of fedmsg-hub and expects consumers to run as individual daemons"
Seems good, package approved.
> Requires: %{py3_dist fedmsg PyYAML requests six} Please replace this with "%{?python_enable_dependency_generator}".
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/regindexer
also use `-p` for install to preserve timestamps.
regindexer-0.2-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f89c89a47a
regindexer-0.2-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f89c89a47a
(In reply to Igor Gnatenko from comment #6) > > Requires: %{py3_dist fedmsg PyYAML requests six} > > Please replace this with "%{?python_enable_dependency_generator}". (In reply to Igor Gnatenko from comment #8) > also use `-p` for install to preserve timestamps. Owen, do you read comments in bugzilla?
regindexer-0.2-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
> Please replace this with "%{?python_enable_dependency_generator}". > also use `-p` for install to preserve timestamps. Fixed in master branch > Owen, do you read comments in bugzilla? Not as well as I should often ;-( ... just did some changes to my mail filtering to separate out the mutter/gnome-shell firehose of bug reports that I'm still subscribed to from the rest and to highlight needinfos.