Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://copr-be.cloud.fedoraproject.org/results/ansasaki/abimap/fedora-rawhide-x86_64/00783889-python-abimap/python-abimap.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ansasaki/abimap/fedora-rawhide-x86_64/00783889-python-abimap/python-abimap-0.3.0-1.fc29.src.rpm Description: Description: This script allows to generate and update symbol version linker scripts which adds version information to the exported symbols. The script is intended to be integrated as part of a shared library build to check for changes in the set of exported symbols and update the symbol version linker script accordingly. Copr build: https://copr.fedorainfracloud.org/coprs/ansasaki/abimap/build/783889/ Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28819575 Note: This review request replaces https://bugzilla.redhat.com/show_bug.cgi?id=1592254. The project upstream was renamed. Fedora Account System Username: ansasaki
INFO: Downloading (Source0): https://files.pythonhosted.org/packages/source/s/abimap/abimap-0.3.0.tar.gz WARNING: Cannot download url: https://files.pythonhosted.org/packages/source/s/abimap/abimap-0.3.0.tar.gz INFO: No upstream for (Source0): abimap-0.3.0.tar.gz You need to replace source/s/abimap with source/a/abimap Missing in files section: %dir %{python3_sitelib}/abimap The doc packages misses a %license /usr/bin/abimap doesn't have a manpage.
(In reply to Andreas Schneider from comment #1) > INFO: Downloading (Source0): > https://files.pythonhosted.org/packages/source/s/abimap/abimap-0.3.0.tar.gz > WARNING: Cannot download url: > https://files.pythonhosted.org/packages/source/s/abimap/abimap-0.3.0.tar.gz > INFO: No upstream for (Source0): abimap-0.3.0.tar.gz > > You need to replace source/s/abimap with source/a/abimap > > Missing in files section: > %dir %{python3_sitelib}/abimap > > The doc packages misses a %license I'll fix these and run a new scratch build. > > > /usr/bin/abimap doesn't have a manpage. About the manpage, it is not available upstream. Should I use something like help2man to generate a man page?
I normally write manpages with asciidoc and check in the manpage if it doesn't change for a long time. Example: https://git.samba.org/?p=socket_wrapper.git;a=tree;f=doc;h=634e12fa99c0b13dbdb782ff39c8ce827981455d;hb=refs/heads/master Check the README
(In reply to Andreas Schneider from comment #3) > I normally write manpages with asciidoc and check in the manpage if it > doesn't change for a long time. > > Example: > https://git.samba.org/?p=socket_wrapper.git;a=tree;f=doc; > h=634e12fa99c0b13dbdb782ff39c8ce827981455d;hb=refs/heads/master > > Check the README I found a package (argparse-manpage) which creates a manpage from the python arparse object. I think it is better than nothing. New spec file: https://copr-be.cloud.fedoraproject.org/results/ansasaki/abimap/fedora-rawhide-x86_64/00785001-python-abimap/python-abimap.spec New SRPM file: https://copr-be.cloud.fedoraproject.org/results/ansasaki/abimap/fedora-rawhide-x86_64/00785001-python-abimap/python-abimap-0.3.0-1.fc29.src.rpm New Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28884181 New Copr build: https://copr.fedorainfracloud.org/coprs/ansasaki/abimap/build/785001/
%define module_name abimap should be: %global module_name abimap === # BuildRequires: %{py3_dist pytest-console-scripts} use # BuildRequires: %%{py3_dist pytest-console-scripts} The double %% will not expand in a comment. === 46 Summary: python-%{module_name} documentation change to 46 Summary: Documentation for python-%{module_name} Then we should be good to go :-)
(In reply to Andreas Schneider from comment #5) > %define module_name abimap > > should be: > > %global module_name abimap > > === > > # BuildRequires: %{py3_dist pytest-console-scripts} > > use > > # BuildRequires: %%{py3_dist pytest-console-scripts} > > The double %% will not expand in a comment. > > === > > 46 Summary: python-%{module_name} documentation > > change to > > 46 Summary: Documentation for python-%{module_name} > > > > Then we should be good to go :-) Fixed all following the suggestions. New spec: https://copr-be.cloud.fedoraproject.org/results/ansasaki/abimap/fedora-rawhide-x86_64/00785056-python-abimap/python-abimap.spec New SRPM: https://copr-be.cloud.fedoraproject.org/results/ansasaki/abimap/fedora-rawhide-x86_64/00785056-python-abimap/python-abimap-0.3.0-1.fc29.src.rpm New Fedora scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28886629 New Copr build: https://copr.fedorainfracloud.org/coprs/ansasaki/abimap/build/785056/
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 216 files have unknown license. Detailed output of licensecheck in /home/asn/workspace/package/fedora/review/1612551-python- abimap/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.7/site- packages, /usr/lib/python3.7 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-abimap , python-abimap-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-abimap-0.3.0-1.fc29.noarch.rpm python-abimap-doc-0.3.0-1.fc29.noarch.rpm python-abimap-0.3.0-1.fc29.src.rpm python3-abimap.noarch: W: spelling-error Summary(en_US) versioning -> versifying, version, overseeing python-abimap.src: W: spelling-error Summary(en_US) versioning -> versifying, version, overseeing 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- python-abimap-doc (rpmlib, GLIBC filtered): python3-abimap (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) Provides -------- python-abimap-doc: python-abimap-doc python3-abimap: python3-abimap python3.7dist(abimap) python3dist(abimap) Source checksums ---------------- https://files.pythonhosted.org/packages/source/a/abimap/abimap-0.3.0.tar.gz : CHECKSUM(SHA256) this package : ff41025ba6995501e0c320fd58a98f80edc76c3ddf3632b5a3beab677ae3181e CHECKSUM(SHA256) upstream package : ff41025ba6995501e0c320fd58a98f80edc76c3ddf3632b5a3beab677ae3181e
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-abimap
*** Bug 1592254 has been marked as a duplicate of this bug. ***