Bug 1612917 - Adding an IP address to a logical network wipes IP on other logical network
Summary: Adding an IP address to a logical network wipes IP on other logical network
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: Core
Version: ---
Hardware: Unspecified
OS: Linux
medium
medium
Target Milestone: ovirt-4.2.8
: ---
Assignee: Edward Haas
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-06 14:15 UTC by Michael Waiblinger
Modified: 2019-01-22 10:23 UTC (History)
5 users (show)

Fixed In Version: v4.20.45
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-01-22 10:23:30 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 94697 0 master MERGED net tests: Add test_add_static_ip_to_the_existing_net_with_bond 2020-05-13 08:22:18 UTC
oVirt gerrit 94839 0 master MERGED net: Do not flush IP addresses from a bond if it's used by a network 2020-05-13 08:22:18 UTC
oVirt gerrit 94886 0 ovirt-4.2 MERGED net: Do not flush IP addresses from a bond if it's used by a network 2020-05-13 08:22:18 UTC

Description Michael Waiblinger 2018-08-06 14:15:40 UTC
Description of problem:

After adding an IP address to a logical network, which has newly been added to an Interface (bond) the previously bound IP address to the formerly sole logical network vanished.

Version-Release number of selected component (if applicable):
Ovirt 4.2.4.5
CentOS Linux release 7.5.1804 (Core) 

How reproducible:
100%

Steps to Reproduce:
1. Create a bond (bond0)
2. Assign logical network (non-VM) to bond (foo -> bond0)
3. Assign IP address to said logical network (10.10.10.10 -> foo)
4. Check with ip a, find bond0 has the 10.10.10.10, as no bridge has been deployed, all fine.
5. Add logical network (VM, vlan tagged) (bar -> bond0.10)
6. Bridge "bar" gets created, all fine so far
7. Assign an static IP address to the logical network (10.20.20.20 -> bar)

Actual results:

The new IP address gets set correctly to the bridge "bar", but the IP address from the former network "foo" is lost, as is the connectivity in case that network was needed.

Expected results:

Both IP addresses should be set correctly.

Additional info:

I added the ip manually to the bond0 on the host to get it back.
After that an update/reinstall fixed the issue.

Comment 1 Dan Kenigsberg 2018-08-07 18:28:23 UTC
Would you please attach engine.log as well as supervdsm.log from the host during the time of the said setupNetwork operation?

Please specify rpm versions of ovirt-engine and vdsm.rpm.

Comment 2 Michael Waiblinger 2018-08-08 10:00:02 UTC
ovirt-engine-4.2.4.5-1.el7.noarch
vdsm-4.20.35-1.el7.x86_64

The logs I can't provide due to privacy protection of our customers. If you can't reproduce the problem I might be able to clear the relevant information, but that's quite a task. Is there a script/tool to clear all those informations?

Comment 3 Yaniv Lavi 2018-08-15 07:34:32 UTC
(In reply to Michael Waiblinger from comment #2)
> ovirt-engine-4.2.4.5-1.el7.noarch
> vdsm-4.20.35-1.el7.x86_64
> 
> The logs I can't provide due to privacy protection of our customers. If you
> can't reproduce the problem I might be able to clear the relevant
> information, but that's quite a task. Is there a script/tool to clear all
> those informations?

Please do that, we don't have a script for it.
You can also share the log with privately and then only the oVirt devs will be able to see them.

Comment 4 Michael Burman 2018-08-15 07:38:30 UTC
Hi

I can't reproduce the issue described above. I followed the steps as described. Both IPs set correctly.

Comment 5 Yaniv Lavi 2018-09-05 07:19:22 UTC
Please reopen if you can provide the needed info.
Closing for now.

Comment 6 Michael Waiblinger 2018-09-05 07:22:17 UTC
I sent you the logs via email.

Comment 8 Michael Burman 2018-10-03 08:33:21 UTC
The exact way to reproduce this bug is :

1. Create a bond (bond0)
2. Attach non-VM network to the bond0 ('foo' -> bond0) and VM vlan tagged network ('bar' -> bond0.10) and assign IP address to the non-vm network (10.10.10.10 -> foo), now approve operation
3. Check with ip a, find bond0 has the 10.10.10.10 
4. Edit the vlan tagged network 'bar' and set static IP address (10.20.20.20 -> bar)

Result:
The IP address 10.10.10.10 is gone from network 'foo' and it is now out-of-sync

Comment 9 Michael Burman 2018-11-06 07:30:35 UTC
Edy, I'm testing this bug on 4.2 u/s vdsm-4.20.43-4.gitb76af64.el7.x86_64 and i'm concern that this fix has created a new regression bug. 
My flow as described in comment#8 doesn't work as it should.

1. Create a bond (bond0)
2. Attach non-VM network to the bond0 ('foo' -> bond0) and VM vlan tagged network ('bar' -> bond0.10) and assign IP address to the non-vm network (10.10.10.10 -> foo), now approve operation
3. Check with ip a, find bond0 has the 10.10.10.10 - FAIL!
Because the IP address doesn't applied on the non-VM network and reported as out-of-sync in the engine. No IP address on bond0.

This wasn't the result before this fix. Please check this out

Comment 10 Michael Burman 2018-11-06 12:04:36 UTC
Ignore, i had an issue on one of my hosts.

Verified upstream on - vdsm-4.20.43-4.gitb76af64.el7.x86_64 and 4.2.8-0.0.master.20181101130712.git326ea78.el7

Comment 11 RHV bug bot 2018-11-28 14:38:43 UTC
INFO: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Tag 'v4.20.44' doesn't contain patch 'https://gerrit.ovirt.org/94697']
gitweb: https://gerrit.ovirt.org/gitweb?p=vdsm.git;a=shortlog;h=refs/tags/v4.20.44

For more info please contact: infra

Comment 12 Dan Kenigsberg 2018-11-30 10:57:28 UTC
Missing patch is a test-only one. no need to backport it.

Comment 13 Sandro Bonazzola 2019-01-22 10:23:30 UTC
This bugzilla is included in oVirt 4.2.8 release, published on January 22nd 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.2.8 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.