Documentation is missing the information about expected name of the ISO. It describes steps to upload the rhv-tools-setup.iso (which is in fact a symlink) to the domain but does not mention that the name resolves to the format: RHV-toolsSetup_<version>.iso. E.g.: RHV-toolsSetup_4.2_5.iso Correct name is important for automatic attachment of the ISO to Windows VMs for automatic update of tools in the guest. Documenting the name is especially important for users that manage the content of ISO domain manually.
This bug has not been marked as blocker for oVirt 4.3.0. Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.
Aviv, can you please provide the actual name of the iso for 4.3.z? For example, Tomas in the description gives the example RHV-toolsSetup_4.2_5.iso. So for 4.3 is it RHV-toolsSetup_4.3_0.iso?
after unpacking rhv-guest-tools-iso-4.3-6.el7ev.noarch.rpm, I see that the ISO file to be released is: RHV-toolsSetup_4.3_6.iso
Michal, OK. That helps. 1. I notice that in one section we say: "Upload the ISO file (referring to rhv-tools-setup.iso) to your data domain" [1] and in another section, we say "rhv-tools-setup.iso...must be manually uploaded to an ISO storage domain." [2] I see in the 4.3 Admin Guide that the iso_uploader tool is deprecated and we recommend to upload iso files to a data domain, so I edited the statement in [1] accordingly. See step 2: https://pnt-devops-rad-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/ccs-mr-preview-prod/2603/artifact/doc-Virtual_Machine_Management_Guide/preview/index.html#Installing_the_Guest_Agents_and_Drivers_on_Windows 2. There's a note in "Installing the Guest Agents and Drivers on Windows"[2] that says: ------------ To install updated versions of the tools and drivers, you must manually attach updated versions of the RHV-toolsSetup_<version>_.iso file to any running Windows virtual machines. If the APT service is enabled on virtual machines, the updated ISO files are automatically attached. ------------ Should I add the last sentence in the note (about APT service) to Updating the Guest Agents and Drivers on Windows[1]? (The note seems out of place to me, and I'm replacing it with a simple cross reference to [1]) at the end of the procedure. 3. In table 3.2 in Red Hat Virtualization Guest Agents and Drivers [3], I notice that we say: qemu-guest-agent: Used instead of `ovirt-guest-agent-common` on Red Hat Enterprise Linux 8 virtual machines. It is installed and enabled by default. We don't actually describe qemu-guest-agent. Here's the description for ovirt-guest-agent-common [3]: Allows the Red Hat Virtualization Manager to receive guest internal events and information such as IP address and installed applications. Also allows the Manager to execute specific commands, such as shut down or reboot, on a guest. On Red Hat Enterprise Linux 6 and later guests, the ovirt-guest-agent-common installs "tuned" on your virtual machine and configures it to use an optimized, virtualized-guest profile. Is the description for ovirt-guest-agent-common the same for qemu-guest-agent (other than the version of RHEL mentioned)? [1] https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.3/html-single/virtual_machine_management_guide/index#Updating_the_Guest_Agents_and_Drivers_on_Windows [2] https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.3/html-single/virtual_machine_management_guide/index#Installing_the_Guest_Agents_and_Drivers_on_Windows [3] https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.3/html-single/virtual_machine_management_guide/index#Installing_Guest_Agents_and_Drivers_Windows
From comment 10: > I also noticed that VMM 6.6.2 talks about uploading the ISO to data domain. This will break the functionality because AFAIK the underlying code has not been changed yet. The ISOs have to be in ISO domain (see VMM 3.3.2). Tomas: 1. You wrote "AFAIK the underlying code has not been changed yet. The ISOs have to be in ISO domain." According to 8.8.1. Uploading Images to a Data Storage Domain [1] "You can upload virtual disk images and ISO images to your data storage domain in the Administration Portal or with the REST API." 2. The topic I just mentioned [1] does not provide a way for someone without permissions to use the Admin Portal to upload an ISO to a data domain other than by using the REST API. Is there another way? 3. The iso_uploader tool is deprecated, so is there another way to upload the iso to an iso domain? [1] https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.3/html-single/administration_guide/index#Uploading_Images_to_a_Data_Storage_Domain_storage_tasks
Here's the deal with iso domain vs data domain: ISO DOMAIN - The ISO domain is deprecated, but still exists in 4.3. - It is the only domain type that can be shared between data centers. That is its advantage for iso files. You can upload an iso file once and share it among all your data centers. - You can upload isos to the iso domain using the REST API or the ISO uploader tool, no other way DATA DOMAIN - The data domain can also be used for sharing isos, but only between clusters within the same data center; you can't share a data domain between data centers. So if you use a data center for isos, you need to upload the same iso to the data domain for each data center that you want to access the iso. - You can upload isos to the data domain using the Admin portal or the imageio tool. So ISOs don't have to be in an ISO domain. So I have removed any mention of uploading the iso in question to an ISO domain. If this is incorrect, you can let me know if in this bug. I'm moving forward with this to peer review.
Hi Steve, sorry for the delay. Looks good!
I made some more edits, viewable in the merge request: https://gitlab.cee.redhat.com/rhci-documentation/docs-Red_Hat_Enterprise_Virtualization/merge_requests/1336/diffs?diff_id=173337&start_sha=a9d56be098183e1c2d9e6f0138ea44456f8716a2 Eli can you please do a peer review?
(In reply to Steve Goodman from comment #24) > Here's the deal with iso domain vs data domain: > > ISO DOMAIN > - The ISO domain is deprecated, but still exists in 4.3. > - It is the only domain type that can be shared between data centers. > That is its advantage for iso files. You can upload an iso file once > and share it among all your data centers. > - You can upload isos to the iso domain using the REST API or the ISO > uploader tool, no other way + guest tools on iso domain is still required for IMS functionality (v2v). Such note can remain in the IMS product guide only. > > DATA DOMAIN > - The data domain can also be used for sharing isos, but only between > clusters > within the same data center; you can't share a data domain between data > centers. > So if you use a data center for isos, you need to upload the same iso to > the > data domain for each data center that you want to access the iso. > - You can upload isos to the data domain using the Admin portal or the > imageio tool.
(In reply to Michal Skrivanek from comment #27) > > + guest tools on iso domain is still required for IMS functionality (v2v). > Such note can remain in the IMS product guide only. I want to be clear about this: Are you saying: - for normal RHV functionality, without taking IMS into account, you can upload RHV-toolsSetup_<version>_.iso to a data domain, and this will be what appears in the RHV documentation - for IMS, you need to upload RHV-toolsSetup_<version>_.iso to an ISO domain, and so a statement of this requirement should be present in the IMS guide, but not in the RHV documentation
(In reply to Steve Goodman from comment #28) > (In reply to Michal Skrivanek from comment #27) > > > > + guest tools on iso domain is still required for IMS functionality (v2v). > > Such note can remain in the IMS product guide only. > > I want to be clear about this: > > Are you saying: > - for normal RHV functionality, without taking IMS into account, you can > upload RHV-toolsSetup_<version>_.iso to a data domain, and this will be what > appears in the RHV documentation > - for IMS, you need to upload RHV-toolsSetup_<version>_.iso to an ISO > domain, and so a statement of this requirement should be present in the IMS > guide, but not in the RHV documentation I don't think that is is IMS-specific. I understood that RHV requires the guest tools and virtio image files to be in the ISO domain. That is what Tomas said in comment 10. Tomas, can you clarify? Will the VirtIO and guest tools images work if they're uploaded to the data domain instead of the ISO domain? Or is Michal's comment 27 the final word? Only IMS requires the guest tools and virtio images to be in ISO domain? That doesn't make sense to me, but if that's the case, I'll look into why we would require a non-standard configuration.
(In reply to Avital Pinnick from comment #29) > (In reply to Steve Goodman from comment #28) > > (In reply to Michal Skrivanek from comment #27) > > > > > > + guest tools on iso domain is still required for IMS functionality (v2v). > > > Such note can remain in the IMS product guide only. > > > > I want to be clear about this: > > > > Are you saying: > > - for normal RHV functionality, without taking IMS into account, you can > > upload RHV-toolsSetup_<version>_.iso to a data domain, and this will be what > > appears in the RHV documentation > > - for IMS, you need to upload RHV-toolsSetup_<version>_.iso to an ISO > > domain, and so a statement of this requirement should be present in the IMS > > guide, but not in the RHV documentation > > I don't think that is is IMS-specific. I understood that RHV requires the > guest tools and virtio image files to be in the ISO domain. That is what > Tomas said in comment 10. > > Tomas, can you clarify? Will the VirtIO and guest tools images work if > they're uploaded to the data domain instead of the ISO domain? > Avital is correct, this is not IMS specific. If you upload the ISO into data domain it will not be automatically attached to Windows guests. I checked the engine code and the actual behavior to make sure.
> (In reply to Avital Pinnick from comment #29) > Avital is correct, this is not IMS specific. If you upload the ISO into data > domain it will not be automatically attached to Windows guests. > I checked the engine code and the actual behavior to make sure. The question is what is the intended behavior on RHV 4.3 (not IMS)? ISO domains are deprecated, as stated in the 4.3 Product Guide: "The ISO domain is a deprecated storage domain type that was used to store ISO files for installing a virtual machine operating system or additional applications, such as the Windows guest agents and drivers. Virtual machine images can now be uploaded to data domains instead. "[1] So is the intended behavior that you need to manually attach the ISO to Windows guests using a data domain? Or is the intended behavior that you're supposed to use an ISO domain to store this iso? [1] https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.3/html-single/product_guide/index#storage(In reply to Tomáš Golembiovský from comment #30)
(In reply to Tomáš Golembiovský from comment #30) > If you upload the ISO into data > domain it will not be automatically attached to Windows guests. > I checked the engine code and the actual behavior to make sure. can you point me to that code? It was supposed to be handled the same as iso domains when Tal implemented the iso on datadomain rfe. The general change was to internally use a cached list of isos from all SDs and so all functionality depending on iso domain should work. If it's not working then that gap needs a bug fix
Michal, Tomas, and I just spoke to clarify the open issues and this is the outcome of that conversation: - Data domains are supposed to fully support all functionality supported by ISO domains (except that you can't share data domains across data centers), including: If you upload RHV-toolsSetup_<version>.iso to a data domain it should be automatically attached to Windows guests. If it doesn't automatically attach, that is a functional bug, requiring a new BZ. But the RHV 4.3 documentation should reflect the intended functionality. Michal also restated that using ISO domains is mandatory for IMS and should be documented in the IMS doc as described in comment 27. - In the Product Guide, I should add a sentence about uploading to Data Domain (To upload to data domain...) and to ISO Domain paragraph (To upload to ISO Domain you need to use the iso-uploader tool (also deprecated) or the REST API. You can search for the term RHV-toolsSetup_version_.iso in the preview version of the Virtual Machine Mgm Guide: https://pnt-devops-rad-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/ccs-mr-preview-prod/3148/artifact/doc-Virtual_Machine_Management_Guide/preview/index.html#Installing_the_Guest_Agents_and_Drivers_on_Windows And the Admin Guide: https://pnt-devops-rad-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/ccs-mr-preview-prod/3148/artifact/doc-Administration_Guide/preview/index.html#Uploading_the_VirtIO_and_Guest_Tool_Image_Files_to_an_ISO_Storage_Domain
Petr, Can you please do QA on this? Here are the procedural topics that have changed and need to have QA done (keeping in mind the bug that was mentioned in comment 33). https://pnt-devops-rad-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/ccs-mr-preview-prod/3148/artifact/doc-Virtual_Machine_Management_Guide/preview/index.html#Installing_the_Guest_Agents_and_Drivers_on_Windows https://pnt-devops-rad-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/ccs-mr-preview-prod/3148/artifact/doc-Virtual_Machine_Management_Guide/preview/index.html#Updating_the_Guest_Agents_and_Drivers_on_Windows
The documentation looks good to me.
Keeping with our new workflow, I merged this after QA's and peer approval.
Published to https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.3/html-single/virtual_machine_management_guide/index#Updating_the_Guest_Agents_and_Drivers_on_Windows