Bug 1613024 - [RFE] TripleO-Validations should warn when included environment files override one another
Summary: [RFE] TripleO-Validations should warn when included environment files overrid...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-tripleo-validations
Version: 14.0 (Rocky)
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: Upstream M3
: ---
Assignee: RHOS Maint
QA Contact: nlevinki
URL:
Whiteboard: NeedsAllocation
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-06 19:15 UTC by Dan Sneddon
Modified: 2019-11-20 10:51 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-20 10:47:22 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1785694 0 None None None 2018-08-06 19:15:23 UTC

Description Dan Sneddon 2018-08-06 19:15:24 UTC
Description of problem:
If I deploy tripleo with multiple environment files that include the same default parameters with different values, the last one included wins. This can cause a surprise for the deployer. We should create a tripleo-validation which tests the included environment files for duplicate parameters/parameter_defaults and warns when one value is overridden by another file.

Version-Release number of selected component (if applicable):
Rocky and all previous versions


How reproducible:
100%

Steps to Reproduce:
1. If this is my deploy command-line:

openstack overcloud deploy --templates \
-e environments/network-isolation.yaml \
-e environments/neutron-ovs-dvr.yaml \
-e network-environment.yaml \
-r roles_data.yaml \
--control-scale 1 \
--compute-scale 2 \
--control-flavor control \
--compute-flavor compute \
--ntp-server 10.1.24.11

Assume that the parameter_default for OS::TripleO::Compute::Ports::ExternalPort is different in network-isolation.yaml than it is in neutron-ovs-dvr.yaml, then the value in neutron-ovs-dvr.yaml will override the value in network-isolation.yaml. This creates different outcomes depending on which file was included last.

Actual results:
The deployment will either work or fail depending on the order which the environment files were included.

Expected results:
TripleO-Validations should warn when a parameter_default included in one environment file is overridden by another included environment file. This would help troubleshoot failed deployments and help the deployer understand what is happening.

Additional info:


Note You need to log in before you can comment on or make changes to this bug.