When attempting to change the mac address pool, if you select a range that is invalid, the only error that is reported is "Internal Error" with no additional description. This also puts the pool in a state where any and all attempts to make any changes, even back to the default values, results in the same "Internal Error" How reproducible: Edit the default mac address pool and change the first field to an 01 in both the start and end value fields. Select Ok Actual results: "Internal Error"
Please include your engine.log and the complete traceback.
Created attachment 1474081 [details] Engine and server logs Engine and server logs, in tar format
WARN: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason: [Found non-acked flags: '{'rhevm-4.2.z': '?'}', ] For more info please contact: rhv-devops: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason: [Found non-acked flags: '{'rhevm-4.2.z': '?'}', ] For more info please contact: rhv-devops
Ales Hi, I'm trying to test this report on ovirt-engine-4.2.7.2-0.0.master.20180926072101.git7001334.el7.noarch same result om master of course. I'm followed by the reporter's step and i get - "Error while executing action UpdateMacPool: Error Initializing MAC Pool" Is this is the fix? is this message more descriptive than before? i'm not sure.. If yes, i think this error message still not descriptive enough IMHO
Hi Michael, from my point of view this is a lot better than just throwing "Internal Error" or "Internal Engine Error" at user. Also the patch didn't changed any messages itself, instead it changed the way that engine propagates errors to users, if there is any. So the message you are getting is correct.
(In reply to Ales Musil from comment #7) > Hi Michael, > > from my point of view this is a lot better than just throwing "Internal > Error" or "Internal Engine Error" at user. Also the patch didn't changed any > messages itself, instead it changed the way that engine propagates errors to > users, if there is any. So the message you are getting is correct. OK, i see, but still, this error message still doesn't say anything meaning full. We need to indicate the reason for failing, no? I'm not sure I'm OK with this fix. Dana, does "Error while executing action UpdateMacPool: Error Initializing MAC Pool" descriptive enough for you?
Yes, that's plenty descriptive.
OK, if you both fine with this error message than i'm fine as well. Although personally this is not descriptive enough. Verified upstream on - 4.2.7.2-0.0.master.20180926072101.git7001334.el7 The new error message for the described scenario will be now - "Error while executing action UpdateMacPool: Error Initializing MAC Pool"