Bug 1613371
| Summary: | Error message when attempting to change the MAC address pool is non descriptive. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Dana Lane <dlane> | ||||
| Component: | ovirt-engine | Assignee: | Ales Musil <amusil> | ||||
| Status: | CLOSED UPSTREAM | QA Contact: | Michael Burman <mburman> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 4.1.9 | CC: | amusil, danken, dlane, lsurette, mburman, Rhev-m-bugs, srevivo, tburke | ||||
| Target Milestone: | ovirt-4.2.7 | Keywords: | ZStream | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | ovirt-engine-4.2.7.2 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2018-10-15 14:38:16 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Network | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Dana Lane
2018-08-07 12:44:43 UTC
Please include your engine.log and the complete traceback. Created attachment 1474081 [details]
Engine and server logs
Engine and server logs, in tar format
WARN: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:
[Found non-acked flags: '{'rhevm-4.2.z': '?'}', ]
For more info please contact: rhv-devops: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:
[Found non-acked flags: '{'rhevm-4.2.z': '?'}', ]
For more info please contact: rhv-devops
Ales Hi, I'm trying to test this report on ovirt-engine-4.2.7.2-0.0.master.20180926072101.git7001334.el7.noarch same result om master of course. I'm followed by the reporter's step and i get - "Error while executing action UpdateMacPool: Error Initializing MAC Pool" Is this is the fix? is this message more descriptive than before? i'm not sure.. If yes, i think this error message still not descriptive enough IMHO Hi Michael, from my point of view this is a lot better than just throwing "Internal Error" or "Internal Engine Error" at user. Also the patch didn't changed any messages itself, instead it changed the way that engine propagates errors to users, if there is any. So the message you are getting is correct. (In reply to Ales Musil from comment #7) > Hi Michael, > > from my point of view this is a lot better than just throwing "Internal > Error" or "Internal Engine Error" at user. Also the patch didn't changed any > messages itself, instead it changed the way that engine propagates errors to > users, if there is any. So the message you are getting is correct. OK, i see, but still, this error message still doesn't say anything meaning full. We need to indicate the reason for failing, no? I'm not sure I'm OK with this fix. Dana, does "Error while executing action UpdateMacPool: Error Initializing MAC Pool" descriptive enough for you? Yes, that's plenty descriptive. OK, if you both fine with this error message than i'm fine as well. Although personally this is not descriptive enough. Verified upstream on - 4.2.7.2-0.0.master.20180926072101.git7001334.el7 The new error message for the described scenario will be now - "Error while executing action UpdateMacPool: Error Initializing MAC Pool" WARN: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:
[Found non-acked flags: '{'rhevm-4.2.z': '?'}', ]
For more info please contact: rhv-devops: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:
[Found non-acked flags: '{'rhevm-4.2.z': '?'}', ]
For more info please contact: rhv-devops
|