Spec URL: https://raw.githubusercontent.com/UncleAlbie/timescale-rpm/master/postgresql-timescaledb.spec SRPM URL: https://github.com/UncleAlbie/timescale-rpm/blob/master/postgresql-timescaledb-0.10.1-1.fc28.src.rpm?raw=true Description: TimescaleDB is an open-source database designed to make SQL scalable for time-series data. It is engineered up from PostgreSQL, providing automatic partitioning across time and space (partitioning key), as well as full SQL support. Fedora Account System Username: panovotn
> %define short_name timescaledb > Name: postgresql-timescaledb Please use 'Name: timescaledb'. Otherwise it evokes that the package comes from postgresql.spec. > BuildRequires: cmake gcc postgresql-devel Since we install postgresql module, you should also use: %{?postgresql_module_requires} macro. Otherwise looks pretty nice. I'll have a look at fedora-review output tomorrow.
The `fedora-review -b 1613383 -m fedora-rawhide-x86_64` fails with: ERROR: Cannot find/open srpm: /tmp/1613383-postgresql-timescaledb/srpm/postgresql-timescaledb-0.10.1-1.fc28.src.rpm. Error: error reading package header Seems like the SRPM URL above isn't correct. Could you upload the file somewhere else? E.g. copr link should be OK.
Per upstream README prerequisities: A standard PostgreSQL 9.6 or 10 64-bit installation Does that mean that we should use ExcludeArch?
Spec URL: https://gist.githubusercontent.com/UncleAlbie/cfa3c4d70adcf39befb8fde86024080b/raw/4df53d60b614594eeb2524f70af2c81c10eb0485/timescaledb.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/panovotn/timescaledb-test/fedora-rawhide-x86_64/00785720-timescaledb/timescaledb-0.10.1-1.fc29.src.rpm Package name has been changed to 'timescaledb'. Requirements are now specified by %{?postgresql_module_requires} macro. ExcludeArch shouldn't be necessary as 64-bit installation is required only when building on Windows.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: timescaledb-debugsource : /usr/src/debug/timescaledb-0.10.1-1.fc29.x86_64/src/cache.h timescaledb- debugsource : praiskup: rhbz#1542507 - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 praiskup: not true anymore, rhbz#1613069 ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. praiskup: it's not on ldpath [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 310 files have unknown license. Detailed output of licensecheck in /home/praiskup/1613383-timescaledb/licensecheck.txt [x]: License file installed when any subpackage combination is installed. praiskup: no subpackage [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id(iputils, efivar-libs, gc, gdbm, gpgme, rpm-plugin-selinux, libnfsidmap, gdb- headless, createrepo_c-libs, trousers, bzip2-libs, unzip, libdb-utils, praisukp: broken fedora-review [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in timescaledb-debuginfo , timescaledb-debugsource [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1208320 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: timescaledb-0.10.1-1.fc29.x86_64.rpm timescaledb-debuginfo-0.10.1-1.fc29.x86_64.rpm timescaledb-debugsource-0.10.1-1.fc29.x86_64.rpm timescaledb-0.10.1-1.fc29.src.rpm 4 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (debuginfo) ------------------- Checking: timescaledb-debuginfo-0.10.1-1.fc29.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory timescaledb.x86_64: W: invalid-url URL: http://www.timescale.com <urlopen error [Errno -2] Name or service not known> timescaledb-debuginfo.x86_64: W: invalid-url URL: http://www.timescale.com <urlopen error [Errno -2] Name or service not known> timescaledb-debugsource.x86_64: W: invalid-url URL: http://www.timescale.com <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Requires -------- timescaledb (rpmlib, GLIBC filtered): libc.so.6()(64bit) postgresql-server(:MODULE_COMPAT_10) rtld(GNU_HASH) timescaledb-debuginfo (rpmlib, GLIBC filtered): timescaledb-debugsource (rpmlib, GLIBC filtered): Provides -------- timescaledb: timescaledb timescaledb(x86-64) timescaledb-debuginfo: debuginfo(build-id) timescaledb-debuginfo timescaledb-debuginfo(x86-64) timescaledb-debugsource: timescaledb-debugsource timescaledb-debugsource(x86-64) Unversioned so-files -------------------- timescaledb: /usr/lib64/pgsql/timescaledb-0.10.1.so timescaledb: /usr/lib64/pgsql/timescaledb.so Source checksums ---------------- https://github.com/timescale/timescaledb/archive/0.10.1/timescaledb-0.10.1.tar.gz : CHECKSUM(SHA256) this package : 79dc9f53db14544c6a559f4f2f917348efcf502aef5aec599b3f532c646a817a CHECKSUM(SHA256) upstream package : 79dc9f53db14544c6a559f4f2f917348efcf502aef5aec599b3f532c646a817a Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1613383 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Thanks for the work on the package, btw.!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/timescaledb