Bug 1613504 - Should WWW::Mechanize require 'HTML::TreeBuilder'?
Summary: Should WWW::Mechanize require 'HTML::TreeBuilder'?
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: perl-WWW-Mechanize
Version: 27
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Emmanuel Seyman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1613218
TreeView+ depends on / blocked
 
Reported: 2018-08-07 17:14 UTC by Ralf Corsepius
Modified: 2018-08-20 18:41 UTC (History)
5 users (show)

Fixed In Version: perl-WWW-Mechanize-1.86-2.fc27 perl-WWW-Mechanize-1.87-2.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-08-20 17:57:58 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Ralf Corsepius 2018-08-07 17:14:36 UTC
Description of problem:

WWW::Mechanize has a hidden dep on Test::Builder:
...
WWW-Mechanize-1.88/lib/WWW/Mechanize.pm:        require HTML::TreeBuilder;
WWW-Mechanize-1.88/lib/WWW/Mechanize.pm:        my $tree = HTML::TreeBuilder->new();
WWW-Mechanize-1.88/lib/WWW/Mechanize.pm:stripped. This feature requires I<HTML::TreeBuilder> to be installed,
WWW-Mechanize-1.88/README.md:    stripped. This feature requires _HTML::TreeBuilder_ to be installed,
...

This forces some users of WWW::Mechanize (e.g. perl-Test-WWW-Mechanize)
to explicitly BR: perl(HTML::TreeBuilder), even though these packages do not directly require HTML::TreeBuilder.

Version-Release number of selected component (if applicable):
All versions of perl-WWW-Mechanize in all active Fedoras.

Additional info:
I am not sure, what to do about it, but I rather lean for WWW::Mechanize to "R: HTML::Builder", because this avoids having to add deps for non-obvious reason.

Comment 1 Emmanuel Seyman 2018-08-07 22:20:33 UTC
(In reply to Ralf Corsepius from comment #0)
>
> I am not sure, what to do about it, but I rather lean for WWW::Mechanize to
> "R: HTML::Builder", because this avoids having to add deps for non-obvious
> reason.

FTR, this is to allow the WWW::Mechanize to return content as text. It does make sense to add the requirement in this package.

I'll do this this week and release updates for all Fedora versions.

Comment 2 Fedora Update System 2018-08-10 05:49:54 UTC
perl-WWW-Mechanize-1.86-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-ccd98cb01c

Comment 3 Fedora Update System 2018-08-10 05:50:06 UTC
perl-WWW-Mechanize-1.87-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-e8defd29ee

Comment 4 Fedora Update System 2018-08-11 16:43:04 UTC
perl-WWW-Mechanize-1.86-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-ccd98cb01c

Comment 5 Fedora Update System 2018-08-11 19:38:13 UTC
perl-WWW-Mechanize-1.87-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-e8defd29ee

Comment 6 Fedora Update System 2018-08-20 17:57:58 UTC
perl-WWW-Mechanize-1.86-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2018-08-20 18:41:08 UTC
perl-WWW-Mechanize-1.87-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.