Bug 1613572 - Review Request: libdparse - Library for lexing and parsing D source code
Summary: Review Request: libdparse - Library for lexing and parsing D source code
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
Depends On: 1613568
Blocks: 1613573 1613574
TreeView+ depends on / blocked
Reported: 2018-08-07 22:04 UTC by MERCIER Jonathan
Modified: 2018-11-04 06:50 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2018-11-04 06:50:07 UTC
Type: Bug
zebob.m: fedora-review+

Attachments (Terms of Use)

Description MERCIER Jonathan 2018-08-07 22:04:55 UTC

In order to provides to fedora community, DCD tools for enable autocomplete dlang  statement with your favourite IDE. It is necessary to package its dependencies.

SPEC: https://bioinfornatics.fedorapeople.org/packages/libdparse.spec
SRPMS: https://bioinfornatics.fedorapeople.org/packages/libdparse-0.9.0-1.fc28.src.rpm

Comment 1 Robert-André Mauchin 🐧 2018-08-08 21:51:28 UTC
 - URL should be


 - Use:

Source0:        https://github.com/dlang-community/libdparse/archive/v%{version}%{?pre:-%{pre}}/%{name}-%{version}%{?pre:-%{pre}}.tar.gz

+ ldc2 -I src -o- -c src/dparse/parser.d -Hf include//dparse/parser.di
BUILDSTDERR: src/dparse/parser.d(9): Error: module `mallocator` is in file 'stdx/allocator/mallocator.d' which cannot be read
BUILDSTDERR: import path[0] = src
BUILDSTDERR: import path[1] = /usr/include/d/ldc
BUILDSTDERR: import path[2] = /usr/include/d

 - You need to include -I %{_includedir}/d/stdx-allocator:

    # generate header
    ldc2 -I %{_includedir}/d/stdx-allocator -I "${src_dir}" -o- -c $f -Hf ${header_file};
    # generate doc
    ldc2 -I %{_includedir}/d/stdx-allocator -I "${src_dir}" -o- -c $f -Df ${doc_file} doc-src/index.ddoc doc-src/macros.ddoc;
    # generate object
    ldc2 -I %{_includedir}/d/stdx-allocator -I "${src_dir}" ${DFLAGS} -c -relocation-model=pic $f -of ${object_file}

 - I think it would be nice to implement Meson for this too:

# debug info seem not works with D compiler
%global debug_package %{nil}

%global major_version 0
%global minor_version 9
%global patch_version 1
#%%global pre beta

Name:           libdparse
Version:        %{major_version}.%{minor_version}.%{patch_version}
Release:        1%{?pre:.%{pre}}%{?dist}
Summary:        Library for lexing and parsing D source code
Summary(fr):    Bibliothèque pour l'analyse syntaxique et grammaticale de code source D
License:        Boost
URL:            https://github.com/dlang-community/libdparse

Source0:        https://github.com/dlang-community/libdparse/archive/v%{version}%{?pre:-%{pre}}/%{name}-%{version}%{?pre:-%{pre}}.tar.gz

Patch0:         https://patch-diff.githubusercontent.com/raw/dlang-community/libdparse/pull/257.patch#/0001-Add-Meson-build-definition.patch

ExclusiveArch:  %{ldc_arches}

BuildRequires:  ldc meson stdx-allocator-devel
Requires:       ldc-phobos ldc-druntime stdx-allocator

Library for lexing and parsing D source code.

%description -l fr
Bibliothèque pour l'analyse syntaxique et grammaticale de code source en D.

%package        devel
Summary:        Development files for %{name}
Summary(fr):    Fichiers de développement pour %{name}
Requires:       %{name}%{?_isa} = %{version}-%{release}
Requires:    stdx-allocator-devel

%description devel
libdparse package contains header files for developing D applications
that use libdparse.

%description devel -l fr
Le paquet libdparse contient les fichiers d'entêtes pour développer
des applications en D utilisant libdparse.

%package geany-tags
Summary:        Support for enable autocompletion in geany
Summary(fr):    Support pour activer l'auto-complétion dans geany
Requires:       %{name} = %{version}-%{release}
BuildArch:      noarch
BuildRequires:  geany
Requires:       geany

%description geany-tags
Enable autocompletion for dsymbol library in geany (IDE)

%description -l fr geany-tags
Active l'autocompletion pour pour la bibliothèque dsymbol dans geany (IDE)

%autosetup -p1 -n %{name}-%{version}%{?pre:-%{pre}}
# temp geany config directory for allow geany to generate tags
mkdir geany_config


LDFLAGS='-Wl,-z,relro -Wl,-z,now' %meson

# generate doc
sources=$(find "${src_dir}" -name '*.d')
for f in ${sources[@]}; do
    d_path=$(dirname ${f});
    d_file=$(basename ${f});
    ldc2 -I %{_includedir}/d/stdx-allocator -I "${src_dir}" -o- -c $f -Df ${doc_file} doc-src/index.ddoc doc-src/macros.ddoc;
mv doc-src html

# generate geany tags
headers=$(find src -name '*.d')
geany -c geany_config -g %{name}.d.tags ${headers[@]}


# geany tags
mkdir -p %{buildroot}%{_datadir}/geany/tags/
install -pm0644 %{name}.d.tags %{buildroot}/%{_datadir}/geany/tags/


%license LICENSE_1_0.txt
%doc README.md

%files devel
%doc html

%files geany-tags

* Thu Aug  2 2018 MERCIER Jonathan <bioinfornatics at gmail.com> - 0.9.0-1
- Initial release

Comment 3 Robert-André Mauchin 🐧 2018-08-27 15:05:13 UTC
 - You should update/redownload the patch as I updated it upstream.

 - You can add:


 to run the test app.

Package approved.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* BSL", "Unknown or generated". 99 files have
     unknown license. Detailed output of licensecheck in
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.

Checking: libdparse-0.9.2-2.fc30.x86_64.rpm
libdparse.x86_64: W: spelling-error Summary(en_US) lexing -> flexing, sexing, hexing
libdparse.x86_64: I: enchant-dictionary-not-found fr
libdparse.x86_64: W: spelling-error %description -l en_US lexing -> flexing, sexing, hexing
libdparse.x86_64: W: unstripped-binary-or-object /usr/lib64/libdparse.so.0.9.2
libdparse-geany-tags.noarch: W: spelling-error Summary(en_US) autocompletion -> auto completion, auto-completion, completion
libdparse-geany-tags.noarch: W: spelling-error %description -l en_US autocompletion -> auto completion, auto-completion, completion
libdparse-geany-tags.noarch: W: spelling-error %description -l en_US dsymbol -> symbol, d symbol
libdparse-geany-tags.noarch: W: no-documentation
libdparse.src: W: spelling-error Summary(en_US) lexing -> flexing, sexing, hexing
libdparse.src: W: spelling-error %description -l en_US lexing -> flexing, sexing, hexing
4 packages and 0 specfiles checked; 0 errors, 9 warnings.

Comment 4 Gwyn Ciesla 2018-10-09 13:46:44 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/libdparse

Comment 5 Fedora Update System 2018-10-09 14:21:16 UTC
libdparse-0.9.9-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c0b4de3712

Comment 6 Fedora Update System 2018-10-09 20:03:46 UTC
libdparse-0.9.9-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c0b4de3712

Comment 7 Fedora Update System 2018-11-04 06:50:07 UTC
libdparse-0.9.9-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.