Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1613875

Summary:	[downstream clone - 4.2.6] Indicate that RHV-H hosts have to be rebooted always after upgrade
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	RHV bug bot <rhv-bugzilla-bot>
Component:	ovirt-engine	Assignee:	Ondra Machacek <omachace>
Status:	CLOSED ERRATA	QA Contact:	Pavol Brilla <pbrilla>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.2.4	CC:	cnagarka, eheftman, lsurette, mgoldboi, michal.skrivanek, mperina, Rhev-m-bugs, srevivo, tburke
Target Milestone:	ovirt-4.2.6	Keywords:	ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-4.2.6.4	Doc Type:	Bug Fix
Doc Text:	Red Hat Virtualization Hosts must always be rebooted after an upgrade. In this release, the Reboot check box in the Administration Portal will be read-only for Red Hat Virtualization Hosts. For REST API requests Reboot option will be set to true by default for Red Hat Virtualization Hosts.	Story Points:	---
Clone Of:	1603020	Environment:
Last Closed:	2018-09-04 13:41:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1603020, 1618980
Bug Blocks:

Description RHV bug bot 2018-08-08 12:57:01 UTC

+++ This bug is a downstream clone. The original bug is: +++
+++   bug 1603020 +++
======================================================================

Description of problem:
While upgrading Hosts from RHV manager, It prompts a warning dialogue box with check-box for 'Reboot Host after upgrade'. Even if the User unchecks the box, Host reboots.

Version-Release number of selected component (if applicable):
rhvm-4.2.4.5-0.1.el7_3

How reproducible:
100%

Steps to Reproduce:

1] Upgrade Host using RHV manager - 
  i] Select Host which shows 'Upgrade Available'.
  ii] Go to Installation -> Upgrade.
  iii] Warning dialogue box opens up with a checkbox for asking 'Reboot Host after upgrade' option.
  iv] Uncheck the box and proceed with upgrading.

Actual results:
Host reboots.

Expected results:
The host should not be rebooted post upgrading packages.

Additional info:

As per upstream BZ [RFE] https://bugzilla.redhat.com/show_bug.cgi?id=1380498#c16, If user unchecks the 'Restart host after upgrade', Host should not be rebooting.

(Originally by Chetan Nagarkar)

Comment 1 RHV bug bot 2018-08-08 12:57:09 UTC

Either way it’s probably better that it did reboot rather than the opposite. 

And attach logs and concrete description of action please. A Bug without logs is only half-useful.

(Originally by michal.skrivanek)

Comment 2 RHV bug bot 2018-08-08 12:57:13 UTC

Michael,

Here is the engine logs snippet: [I will soon attach engine log file to this BZ in private]

=> Host Upgrade started:

~~~
2018-07-17 11:15:21,978+12 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (EE-ManagedThreadFactory-hostUpdatesChecker-Thread-3) [] EVENT_ID: HOST_AVAILABLE_UPDATES_FINISHED(885), Check for available updates on host Host-1 was completed successfully with message 'found updates for packages nbdkit-plugin-python-common, python-perf, nbdkit'.

2018-07-17 11:26:07,862+12 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (default task-13) [] EVENT_ID: HOST_UPGRADE_STARTED(840), Host Host-1 upgrade was started (User: admin@internal-authz).

2018-07-17 11:26:10,715+12 INFO  [org.ovirt.engine.core.vdsbroker.SetVdsStatusVDSCommand] (EE-ManagedThreadFactory-commandCoordinator-Thread-10) [abcdefgh-d8b6-46e4-aa38-08f2fe813a61] START, SetVdsStatusVDSCommand(HostName = Host-1, SetVdsStatusVDSCommandParameters:{hostId='660e3593-3cac-4e8d-9a45-5359027e306b', status='Installing', nonOperationalReason='NONE', stopSpmFailureLogged='false', maintenanceReason='null'}), log id: 755c170 <-- Installing

2018-07-17 11:26:17,072+12 INFO  [org.ovirt.engine.core.common.utils.ansible.AnsibleExecutor] (EE-ManagedThreadFactory-commandCoordinator-Thread-10) [abcdefgh-d8b6-46e4-aa38-08f2fe813a61] Executing Ansible command:  [/usr/bin/ansible-playbook, --ssh-common-args=-F /var/lib/ovirt-engine/.ssh/config, -v, --private-key=/etc/pki/ovirt-engine/keys/engine_id_rsa, --inventory=/tmp/ansible-inventory678110676435562513, /usr/share/ovirt-engine/playbooks/ovirt-host-upgrade.yml] [Logfile: /var/log/ovirt-engine/host-deploy/ovirt-host-mgmt-ansible-20180717112617-Host-1-abcdefgh-d8b6-46e4-aa38-08f2fe813a61.log]

2018-07-17 11:27:07,116+12 INFO  [org.ovirt.engine.core.common.utils.ansible.AnsibleExecutor] (EE-ManagedThreadFactory-commandCoordinator-Thread-10) [abcdefgh-d8b6-46e4-aa38-08f2fe813a61] Ansible playbook command has exited with value: 0

2018-07-17 11:27:07,123+12 WARN  [org.ovirt.engine.core.dal.job.ExecutionMessageDirector] (EE-ManagedThreadFactory-commandCoordinator-Thread-10) [1c7fb13] The message key 'SshHostReboot' is 
missing from 'bundles/ExecutionMessages'

2018-07-17 11:27:07,137+12 INFO  [org.ovirt.engine.core.bll.SshHostRebootCommand] (EE-ManagedThreadFactory-commandCoordinator-Thread-10) [1c7fb13] Running command: SshHostRebootCommand internal: true. Entities affected :  ID: 660e3593-3cac-4e8d-9a45-5359027e306b Type: VDSAction group MANIPULATE_HOST with role type ADMIN

2018-07-17 11:27:07,140+12 INFO  [org.ovirt.engine.core.bll.SshHostRebootCommand] (EE-ManagedThreadFactory-commandCoordinator-Thread-10) [1c7fb13] Opening SSH reboot session on host Host-1 

2018-07-17 11:27:07,350+12 INFO  [org.ovirt.engine.core.bll.SshHostRebootCommand] (EE-ManagedThreadFactory-commandCoordinator-Thread-10) [1c7fb13] Executing SSH reboot command on host Host-1

2018-07-17 11:27:08,900+12 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (EE-ManagedThreadFactory-commandCoordinator-Thread-10) [1c7fb13] EVENT_ID: SYSTEM_SSH_HOST_RESTART(197), Host Host-1 was restarted using SSH by the engine. <----- Host rebooted

2018-07-17 11:27:08,919+12 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (EE-ManagedThreadFactory-commandCoordinator-Thread-10) [abcdefgh-d8b6-46e4-aa38-08f2fe813a61] EVENT_ID: HOST_UPGRADE_FINISHED(842), Host Host-1 upgrade was completed successfully.
~~~

(Originally by Chetan Nagarkar)

Comment 4 RHV bug bot 2018-08-08 12:57:22 UTC

For the VDSType.oVirtNode we do always reboot the host. I couldn't find a bug requesting it, but here is patch introducing it: 

  https://gerrit.ovirt.org/#/c/53790/

Martin do you remember why we need it? Should change it?

(Originally by Ondra Machacek)

Comment 5 RHV bug bot 2018-08-08 12:57:27 UTC

No, node (RHV-H) has to be rebooted always after upgrade, there is not option to turn if off otherwise the upgrade will not actually happen (in previous version that was automatic without any option available). So I'm changing the bug title to indicate node and do following:

1. Webadmin - if selected host if node, then make Reboot checkbox disabled for user updates with Reboot option always on

2. RESTAPI - let's add documentation that reboot option is relevant only for RHEL-H hosts and it's always turned on for RHV-H hosts

(Originally by Martin Perina)

Comment 6 Pavol Brilla 2018-08-15 10:24:50 UTC

checkbox for asking 'Reboot Host after upgrade' option is gray out for RHVH
Software Version:4.2.6.3_SNAPSHOT-94.gbbcd5cb.0.scratch.master.el7ev

Comment 8 errata-xmlrpc 2018-09-04 13:41:42 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2623