Bug 1613909 - Review Request: containernetworking-plugins - Libraries for writing CNI plugins
Summary: Review Request: containernetworking-plugins - Libraries for writing CNI plugins
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Frantisek Kluknavsky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-08 14:17 UTC by Lokesh Mandvekar
Modified: 2018-09-03 15:07 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-08-29 00:55:23 UTC
Type: ---
Embargoed:
fkluknav: fedora-review+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1602064 0 unspecified CLOSED change package name to containernetworking-plugins 2021-02-22 00:41:40 UTC

Internal Links: 1602064

Description Lokesh Mandvekar 2018-08-08 14:17:29 UTC
Spec URL: https://pagure.io/containernetworking-plugins/raw/master/f/containernetworking-plugins.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lsm5/containernetworking-plugins/fedora-rawhide-x86_64/00785823-containernetworking-plugins/containernetworking-plugins-0.7.3-1.fc29.src.rpm

Description: 
The CNI (Container Network Interface) project consists of a specification
and libraries for writing plugins to configure network interfaces in Linux
containers, along with a number of supported plugins. CNI concerns itself
only with network connectivity of containers and removing allocated resources
when the container is deleted.

Fedora Account System Username: lsm5

$ rpmlint -i containernetworking-plugins.spec SRPMS/containernetworking-plugins-0.7.3-1.fc28.src.rpm RPMS/*/*
containernetworking-plugins-devel.noarch: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub
The value of this tag appears to be misspelled. Please double-check.

containernetworking-plugins-unit-test-devel.x86_64: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub
The value of this tag appears to be misspelled. Please double-check.

6 packages and 1 specfiles checked; 0 errors, 2 warnings.


Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=28923011


This is a package rename review request for containernetworking-cni, since upstream repo has changed name from 'cni' to 'plugins'.
See: https://fedoraproject.org/wiki/Package_Renaming_Process

Comment 1 Frantisek Kluknavsky 2018-08-20 12:48:51 UTC
Upgrade path seems smooth. The new spec contains:
Obsoletes: %{project}-cni <= 0.7.1-1
Provides: %{project}-cni = %{version}-%{release}

 - %{project} being "containernetworking"

Comment 2 Frantisek Kluknavsky 2018-08-20 12:54:38 UTC
The %build section is changed and the new spec is cleaner, but without major changes. I think the results of original review request still hold and the package is OK

Comment 3 Gwyn Ciesla 2018-08-20 13:01:56 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/containernetworking-plugins

Comment 4 Fedora Update System 2018-08-20 14:13:38 UTC
containernetworking-plugins-0.7.3-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a457d9490c

Comment 5 Fedora Update System 2018-08-22 03:12:13 UTC
containernetworking-plugins-0.7.3-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-a457d9490c

Comment 6 Fedora Update System 2018-08-22 15:13:45 UTC
containernetworking-plugins-0.7.3-1.fc28 podman-0.8.3-4.git9d09a4d.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a457d9490c

Comment 7 Fedora Update System 2018-08-23 11:02:06 UTC
containernetworking-plugins-0.7.3-1.fc28, podman-0.8.3-4.git9d09a4d.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-a457d9490c

Comment 8 Fedora Update System 2018-08-29 00:55:23 UTC
containernetworking-plugins-0.7.3-1.fc28, podman-0.8.3-4.git9d09a4d.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Dagan McGregor 2018-08-31 01:34:59 UTC
This update changing installed package containernetworking-cni to containernetworking-plugins caused an error during upgrade that both packages provided the same set of files.

containernetworking-plugins is now pulled as a dependency for podman.

It is not clear if the containernetworking-plugins indicate it obsoletes the previous containernetworking-cni package for upgrades.

A reinstall of podman with the new dependencies fixed the upgrade error.

Comment 10 Dagan McGregor 2018-08-31 01:39:06 UTC
Since I didn't capture the actual error message at the time, here is the history for the package installation on F28:


Command Line   : install podman
Transaction performed with:
    Installed     dnf-2.7.5-12.fc28.noarch @anaconda
    Installed     rpm-4.14.1-9.fc28.x86_64 @updates
Packages Altered:
    Install atomic-registries-1.22.1-2.fc28.x86_64                 @fedora
    Install buildah-1.3-1.git4888163.fc28.x86_64                   @updates
    Install containernetworking-cni-0.7.1-1.fc28.x86_64            @updates
    Install containers-common-0.1.31-13.dev.gite3034e1.fc28.x86_64 @updates
    Install criu-3.10-4.fc28.x86_64                                @updates
    Install libnet-1.1.6-15.fc28.x86_64                            @fedora
    Install oci-systemd-hook-1:0.1.17-3.gitbd86a79.fc28.x86_64     @updates
    Install podman-0.8.3-1.git9d09a4d.fc28.x86_64                  @updates
    Install protobuf-c-1.3.0-4.fc28.x86_64                         @fedora
    Install python3-PyYAML-3.12-10.fc28.x86_64                     @fedora
    Install python3-pytoml-0.1.18-1.fc28.noarch                    @updates
    Install runc-2:1.0.0-50.dev.git20aff4f.fc28.x86_64             @updates
    Install slirp4netns-0.1-1.dev.gitc4e1bc5.fc28.x86_64           @updates

Command Line   : remove podman
Transaction performed with:
    Installed     dnf-2.7.5-12.fc28.noarch @anaconda
    Installed     rpm-4.14.1-9.fc28.x86_64 @updates
Packages Altered:
    Erase atomic-registries-1.22.1-2.fc28.x86_64             @fedora
    Erase buildah-1.3-1.git4888163.fc28.x86_64               @updates
    Erase containernetworking-cni-0.7.1-1.fc28.x86_64        @updates
    Erase criu-3.10-4.fc28.x86_64                            @updates
    Erase libnet-1.1.6-15.fc28.x86_64                        @fedora
    Erase oci-systemd-hook-1:0.1.17-3.gitbd86a79.fc28.x86_64 @updates
    Erase podman-0.8.3-1.git9d09a4d.fc28.x86_64              @updates
    Erase protobuf-c-1.3.0-4.fc28.x86_64                     @fedora
    Erase python3-PyYAML-3.12-10.fc28.x86_64                 @fedora
    Erase python3-pytoml-0.1.18-1.fc28.noarch                @updates
    Erase runc-2:1.0.0-50.dev.git20aff4f.fc28.x86_64         @updates
    Erase slirp4netns-0.1-1.dev.gitc4e1bc5.fc28.x86_64       @updates

Command Line   : install podman buildah skopeo
Transaction performed with:
    Installed     dnf-2.7.5-12.fc28.noarch @anaconda
    Installed     rpm-4.14.1-9.fc28.x86_64 @updates
Packages Altered:
    Install atomic-registries-1.22.1-2.fc28.x86_64                 @fedora
    Install buildah-1.3-1.git4888163.fc28.x86_64                   @updates
    Install checkpolicy-2.8-1.fc28.x86_64                          @updates
    Install container-selinux-2:2.71-1.git5721d74.fc28.noarch      @updates
    Install containernetworking-plugins-0.7.3-1.fc28.x86_64        @updates
    Install containers-common-0.1.31-13.dev.gite3034e1.fc28.x86_64 @updates
    Install criu-3.10-4.fc28.x86_64                                @updates
    Install libnet-1.1.6-15.fc28.x86_64                            @fedora
    Install oci-systemd-hook-1:0.1.17-3.gitbd86a79.fc28.x86_64     @updates
    Install podman-0.8.3-4.git9d09a4d.fc28.x86_64                  @updates
    Install policycoreutils-python-utils-2.8-1.fc28.noarch         @updates
    Install protobuf-c-1.3.0-4.fc28.x86_64                         @fedora
    Install python3-IPy-0.81-21.fc28.noarch                        @fedora
    Install python3-PyYAML-3.12-10.fc28.x86_64                     @fedora
    Install python3-audit-2.8.4-2.fc28.x86_64                      @updates
    Install python3-libsemanage-2.8-2.fc28.x86_64                  @updates
    Install python3-policycoreutils-2.8-1.fc28.noarch              @updates
    Install python3-pytoml-0.1.18-1.fc28.noarch                    @updates
    Install python3-setools-4.1.1-9.fc28.x86_64                    @updates
    Install runc-2:1.0.0-50.dev.git20aff4f.fc28.x86_64             @updates
    Install skopeo-0.1.31-13.dev.gite3034e1.fc28.x86_64            @updates
    Install slirp4netns-0.1-1.dev.gitc4e1bc5.fc28.x86_64           @updates
Scriptlet output:
   1 warning: %post(container-selinux-2:2.71-1.git5721d74.fc28.noarch) scriptlet failed, exit status 255

Comment 11 Lokesh Mandvekar 2018-08-31 04:07:10 UTC
Dagan, sorry about that issue. I pushed new builds with the update at https://bodhi.fedoraproject.org/updates/FEDORA-2018-f1f3b41ec3


Note You need to log in before you can comment on or make changes to this bug.