Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1613931

Summary:	[RFE] Add the ability to recover from failed upgrades
Product:	[oVirt] imgbased	Reporter:	Yuval Turgeman <yturgema>
Component:	RFEs	Assignee:	Yuval Turgeman <yturgema>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Yaning Wang <yaniwang>
Severity:	medium	Docs Contact:
Priority:	high
Version:	---	CC:	bugs, cshao, huzhao, mtessun, qiyuan, trichard, weiwang, yaniwang, ycui
Target Milestone:	ovirt-4.2.7	Keywords:	FutureFeature
Target Release:	---	Flags:	rule-engine: ovirt-4.2+ cshao: testing_plan_complete? mtessun: planning_ack+ sbonazzo: devel_ack+ cshao: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	imgbased-1.0.25	Doc Type:	Enhancement
Doc Text:	This release adds the recover verb to imgbase. While upgrading ovirt-node-ng, imgbase creates LVs. If for any reason imgbase fails, and those LVs remain on the system, rerunning the upgrade fails on "existing LVs". Now, `imgbase --experimental recover` finds and removes stale LVs that remained on the system due to a failed upgrade. imgbase will prompt the user before removing LVs, unless used with --force.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-11-02 14:29:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Node	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Yuval Turgeman 2018-08-08 15:03:49 UTC

Description of problem:
Whenever an upgrade of ovirt-node-ng fails, it may leave behind some LVs that will never be used and prevent the user from retrying to apply the update.  To over come this, the user needs to remove manually some LVs that were created by imgbased either layers that contain most of the OS or NIST volumes.  Adding a "recover" verb to imgbased would ease the recovering from failed upgrades.

Comment 1 Yaning Wang 2018-09-25 09:36:26 UTC

Tested version:

rhvh-4.2-20180917.0
rhvh-4.2-20180918.0

Steps:

1. install rhvh-4.2-20180917.0
2. upgrade to rhvh-4.2-20180918.0
3. umount /var/crash, to fail the upgrade

Results:

[root@dhcp-8-193 ~]# imgbase --experimental recover
Remove volume on /var/crash? [y/N]: y
Removing volume on: [/var/crash]
2018-09-25 17:25:20,024 [WARNING] (MainThread) Removing the volume will also remove the data on that volume.
2018-09-25 17:25:20,485 [INFO] (MainThread) Volume for '/var/crash' was detached successful
2018-09-25 17:25:20,600 [INFO] (MainThread) Volume for '/var/crash' was removed successful

Comment 2 Sandro Bonazzola 2018-11-02 14:29:05 UTC

This bugzilla is included in oVirt 4.2.7 release, published on November 2nd 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.7 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.