Bug 1614044 - Review Request: python-animatplot - Making animating in Matplotlib easy
Summary: Review Request: python-animatplot - Making animating in Matplotlib easy
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-08 21:40 UTC by Elliott Sales de Andrade
Modified: 2018-08-23 10:32 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-08-23 10:32:09 UTC
Type: ---
Embargoed:
jamatos: fedora-review+


Attachments (Terms of Use)

Description Elliott Sales de Andrade 2018-08-08 21:40:42 UTC
Spec URL: https://qulogic.fedorapeople.org//python-animatplot.spec
SRPM URL: https://qulogic.fedorapeople.org//python-animatplot-0.2.2-1.fc28.src.rpm

Description:
A Python package for making interactive animated plots build on
Matplotlib.

Comment 1 Elliott Sales de Andrade 2018-08-08 21:43:04 UTC
koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28929815

Comment 2 José Matos 2018-08-09 14:36:49 UTC
Hi Elliot,
  I will take this review.

Just two issues/questions:

1) why do you use as the URL the readthedocs and not the github repo?

2) fedora-review identifies a missing %license...

Comment 3 Elliott Sales de Andrade 2018-08-10 06:03:20 UTC
(In reply to José Matos from comment #2)
> 1) why do you use as the URL the readthedocs and not the github repo?

It just seemed more interesting than the other. I suppose it doesn't really matter that much.

> 2) fedora-review identifies a missing %license...

Yes, that was mistakenly put in %doc.

Spec URL: https://qulogic.fedorapeople.org/python-animatplot.spec
SRPM URL: https://qulogic.fedorapeople.org/python-animatplot-0.2.2-2.fc28.src.rpm

Comment 4 José Matos 2018-08-10 07:32:50 UTC
(In reply to Elliott Sales de Andrade from comment #3)
> (In reply to José Matos from comment #2)
> > 1) why do you use as the URL the readthedocs and not the github repo?
> 
> It just seemed more interesting than the other. I suppose it doesn't really
> matter that much.

I was curious. After all the readthedocs refers the github source.

> > 2) fedora-review identifies a missing %license...
> 
> Yes, that was mistakenly put in %doc.
> 
> Spec URL: https://qulogic.fedorapeople.org/python-animatplot.spec
> SRPM URL:
> https://qulogic.fedorapeople.org/python-animatplot-0.2.2-2.fc28.src.rpm

Approved.

Comment 5 Gwyn Ciesla 2018-08-10 20:46:23 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-animatplot

Comment 6 Fedora Update System 2018-08-11 03:20:58 UTC
python-animatplot-0.2.2-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-7b310fd69c

Comment 7 Fedora Update System 2018-08-14 22:40:54 UTC
python-animatplot-0.2.2-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-7b310fd69c

Comment 8 Fedora Update System 2018-08-23 10:32:09 UTC
python-animatplot-0.2.2-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.