Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1614195

Summary:	[v2v] Keep more logs with ovirt-imageio-daemon
Product:	[oVirt] ovirt-imageio	Reporter:	Mor <mkalfon>
Component:	Daemon	Assignee:	Nir Soffer <nsoffer>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ilan Zuckerman <izuckerm>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	1.4.2	CC:	bugs, dagur, ebenahar, michal.skrivanek, nsoffer, tnisan, ylavi
Target Milestone:	ovirt-4.2.6	Keywords:	Performance
Target Release:	---	Flags:	rule-engine: ovirt-4.2? rule-engine: planning_ack? rule-engine: devel_ack+ rule-engine: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-imageio-{common,daemon}-1.4.3	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-09-03 15:08:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Scale	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mor 2018-08-09 07:52:13 UTC

Description of problem:
While trying to debug a failure of converting 20x100GB VMs, we lost the relevant ovirt-imageio-daemon logs due to them filling too fast. 

The suggestion here is to compress them, and increase the size of the single log, so we can have more logs for troubleshooting.

Version-Release number of selected component (if applicable):
ovirt-imageio-daemon-1.4.2-0.el7ev.noarch

Comment 1 Red Hat Bugzilla Rules Engine 2018-08-12 15:30:42 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 2 Red Hat Bugzilla Rules Engine 2018-08-12 15:33:21 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 3 Nir Soffer 2018-08-12 15:43:29 UTC

Since we decreased the amount of logged data to 25% (see bug 1614202), I think 
increasing the kept logs to 10 x 20M should be enough.

For testing with debug level you should increase the log files size to at leat
80M, see:
https://bugzilla.redhat.com/show_bug.cgi?id=1614202#c3

Fixed in:

commit 2ddff6d5825f603d82d973508b927cb18d7306f2
Author: Nir Soffer <nsoffer>
Date:   Fri Aug 10 03:56:08 2018 +0300

    logging: Double amount of daemon logs
    
    Increase maximum log size to 20 MiB. This will make it easier to debug
    big uploads, spanning over less logs, and reduce the chance of loosing
    old logs because of log rotation.
    
    Testing with 100G sparse image (19G data, 12,704 segments), show that we
    need about 6.1M of logs per virt-v2v import. With 10 logs, this is enough
    to keep 32 uploads logs.
    
    Change-Id: I8927b3228b6c2c14f8c0b3b54b9d898c54096ead
    Bug-Url: https://bugzilla.redhat.com/1614195
    Signed-off-by: Nir Soffer <nsoffer>

Comment 4 Nir Soffer 2018-08-12 15:44:09 UTC

Moving to urgent, since without these changes it is very likely to loose virt-v2v
import logs because of rotation. Without logs, we will not be able to debug issues
in the field.

Comment 5 Sandro Bonazzola 2018-08-14 19:14:21 UTC

We're releasing today 4.2.6 RC2 including v1.4.3 which is referencing this bug. can you please check this bug status?

Comment 6 Nir Soffer 2018-08-14 19:34:04 UTC

(In reply to Sandro Bonazzola from comment #5)
Bug should be fixed in 1.4.3, but not tested by QE yet.

Comment 7 Nir Soffer 2018-08-14 23:47:41 UTC

We have a downstream build, moving to ON_QA

Comment 8 Ilan Zuckerman 2018-08-28 12:41:05 UTC

Verified on rhev 4.2.6.3-0.1.el7ev
/etc/ovirt-imageio-daemon/logger.conf  contains 20971520 bytes for log file size.