https://apps.fedoraproject.org/koschei/build/4807194 https://github.com/libgit2/pygit2/issues/811 https://github.com/libgit2/pygit2/issues/812 One of errors is that it gets some 'U' character and this happens only on aarc64. Second error makes some option to not pass correctly into libgit2 C code (because same test in C works fine).
# aarch64 ====================================================================== FAIL: test_get_gpg_signature_when_signed (test.test_commit.GpgSignatureTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/builddir/build/BUILD/pygit2-0.27.1/test/test_commit.py", line 191, in test_get_gpg_signature_when_signed assert payload == expected_payload AssertionError ---------------------------------------------------------------------- # ppc64 ====================================================================== FAIL: test_no_context_lines (test.test_patch.PatchTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/builddir/build/BUILD/pygit2-0.27.1/test/test_patch.py", line 192, in test_no_context_lines self.assertEqual(context_count, 0) AssertionError: 1 != 0 ---------------------------------------------------------------------- # s390x ====================================================================== FAIL: test_no_context_lines (test.test_patch.PatchTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/builddir/build/BUILD/pygit2-0.27.1/test/test_patch.py", line 192, in test_no_context_lines self.assertEqual(context_count, 0) AssertionError: 1 != 0 ----------------------------------------------------------------------
Unfortunately that doesn't help but quick analyses gives something like: # aarch64 expected_payload = ( 'tree c36c20831e43e5984c672a714661870b67ab1d95\nauthor Mark Adams ' '<madams> 1517510299 -0600\ncommitter Mark Adams <ma' 'dams> 1517510441 -0600\n\nMaking a GPG signed commi' 't\n' ).encode('ascii') But the payload, pygit2 gives contains extra 'U' at the end of this line. # ppc64/s390x patch = pygit2.Patch.create_from( old_blob, new_blob, old_as_path=BLOB_OLD_PATH, new_as_path=BLOB_NEW_PATH, context_lines=0, ) context_count = ( len([line for line in patch.patch.splitlines() if line.startswith(" ")]) ) self.assertEqual(context_count, 0) Inspecting patch.patch, it seems to ignore context_lines=0 ENTIRELY.
jlinton: can you possibly take a look at this please?
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle. Changing version to '29'.
ping?
Oh, I just saw this. I guess the expectation here is that it zlib related again? I will take a look at it.
On aarch64 its definitly the optimization patch, and this problem is similar to the one in git itself. Basically the buffer is being allocated with calloc(), and zlib is poisoning unused portions of the buffer. A small tweak to force a null termination at the end of the buffer in packfile_unpack_compressed() obj->type = type; obj->len = size; obj->data = buffer; if (buf_size>size) { buffer[size]='\0'; } return 0; fixes the problem. As this is aarch64 specific, should I split this defect from the PPC one?
> As this is aarch64 specific, should I split this defect from the PPC one? Yes, it's a different issue so should be split.
Leaving this one for PPC, the aarch64 bug is #1626587
This message is a reminder that Fedora 29 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '29'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 29 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.