Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1615327

Summary: upgrade fails when restarting nodes object has no attribute status
Product: OpenShift Container Platform Reporter: Borja Aranda <farandac>
Component: InstallerAssignee: Vadim Rutkovsky <vrutkovs>
Status: CLOSED CURRENTRELEASE QA Contact: liujia <jiajliu>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.7.0CC: aos-bugs, jokerman, mmccomas, vlaad
Target Milestone: ---   
Target Release: 3.10.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-08 11:57:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Borja Aranda 2018-08-13 10:55:50 UTC
Description of problem:
During the upgrade from 3.6.173.0.126 to 3.7.61-1 the upgrade playbook fails with:

2018-08-13 10:44:05,541 p=33325 u=root |  fatal: [ap-os-master-01.local.ergodirekt.de]: FAILED! => {"msg": "The conditional check 'node_output.results.returncode == 0 and node_output.results.results[0].status.conditions | selectattr('type', 'match', '^Ready$') | map(attribute='status') | join | bool == True' failed. The error was: error while evaluating conditional (node_output.results.returncode == 0 and node_output.results.results[0].status.conditions | selectattr('type', 'match', '^Ready$') | map(attribute='status') | join | bool == True): 'dict object' has no attribute 'status'"}

Recommended workaround and possibly fixed with https://github.com/openshift/openshift-ansible/pull/8674

And this bz is related to https://bugzilla.redhat.com/show_bug.cgi?id=1572870

Version-Release number of the following components:
3.7.61-1

Comment 1 Scott Dodson 2018-08-13 15:12:06 UTC
https://github.com/openshift/openshift-ansible/pull/8674
https://github.com/openshift/openshift-ansible/pull/9520

Both of those have been backported to 3.10.z already. Moving MODIFIED, if QE can verify we should backport to 3.9 and 3.7.

Comment 3 Vadim Rutkovsky 2018-08-13 15:27:37 UTC
3.10 backport of upgrade part - https://github.com/openshift/openshift-ansible/pull/9525

Applied the same logic to node restart - https://github.com/openshift/openshift-ansible/pull/9562 for master and https://github.com/openshift/openshift-ansible/pull/9563 for release-3.10

Comment 4 Scott Dodson 2018-08-14 21:40:14 UTC
Should be in openshift-ansible-3.10.28-1

Comment 7 liujia 2018-09-13 06:10:40 UTC
Verified on openshift-ansible-3.10.45-1.git.0.5aef941.el7.noarch

Checked that pr#9525 9562 9563 were merged. Upgrade succeed.