RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1615680 - Improve --adapter-parent-wwnn,--adapter-parent-wwpn and --adapter-parent-fabric-wwn info for pool-define-as in man page
Summary: Improve --adapter-parent-wwnn,--adapter-parent-wwpn and --adapter-parent-fabr...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.6
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: John Ferlan
QA Contact: gaojianan
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-14 03:11 UTC by Meina Li
Modified: 2019-08-06 13:14 UTC (History)
8 users (show)

Fixed In Version: libvirt-4.5.0-12.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-06 13:13:56 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2019:2294 0 None None None 2019-08-06 13:14:34 UTC

Description Meina Li 2018-08-14 03:11:25 UTC 
Description of problem:
Perfect --adapter-parent-wwnn,--adapter-parent-wwpn and --adapter-parent-fabric-wwn for pool-define-as in man page

Version-Release number of selected component (if applicable):
libvirt-4.5.0-6.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
# man virsh
...
pool-define-as name type [--source-host hostname] [--source-path path] [--source-dev path] [--source-name name] [--target path] [--source-format format] [--auth-type authtype --auth-username username [--secret-usage usage | --secret-uuid uuid]] [[--adapter-name name] | [--adapter-wwnn --adapter-wwpn] [--adapter-parent parent]][--print-xml]
...

Actual results:
no relevant explanation for --adapter-parent-wwnn,--adapter-parent-wwpn and --adapter-parent-fabric-wwn in pool-define-as command

Expected results:
Supplement related information

Additional info:
Related patch:
https://bugzilla.redhat.com/show_bug.cgi?id=1601377#c8

John Ferlan 2018-08-13 08:26:22 EDT
Hmmm, strange. Neglected to update the pool-create-as item list, but I did add the descriptions for each later in the description section:

See the series:
https://www.redhat.com/archives/libvir-list/2018-March/msg00458.html

and in particular patch 3:
https://www.redhat.com/archives/libvir-list/2018-March/msg00461.html

This was committed upstream here:

$ git show d45bee449c52c25a80dc61cb5af8fab7d77446e9
commit d45bee449c52c25a80dc61cb5af8fab7d77446e9
Author: John Ferlan <jferlan>
Date:   Thu Mar 8 18:17:10 2018 -0500

    tools: Add support for additional adapter parent options
    
    Add the ability to provide the adapter parent_wwnn and parent_wwpn
    or the parent_fabric_wwn on the virsh command line for the pool
    define/create as commands.  Update the virsh.pod description.
    
    Signed-off-by: John Ferlan <jferlan>
...

I just posted a patch upstream to add the strings to the virsh.pod item list:

https://www.redhat.com/archives/libvir-list/2018-August/msg00661.html
Comment 5 John Ferlan 2018-08-14 11:34:02 UTC 
Patch posted upstream:

https://www.redhat.com/archives/libvir-list/2018-August/msg00661.html

and pushed:

$ git show
commit b0451117b399df8107340dee8b653cb48e8da1c8
Author: John Ferlan <jferlan>
Date:   Mon Aug 13 08:19:30 2018 -0400

    virsh: Add missed fields to pool-define-as item entry
    
...
    
    Commit id d45bee449 updated the pool-define-as qualifier descriptions
    to add some new fields, but neglected to modify the command item list
    in order to add those fields as well.
    
    Signed-off-by: John Ferlan <jferlan>

$ git describe b0451117b399df8107340dee8b653cb48e8da1c8
v4.6.0-163-gb0451117b3
$
Comment 9 gaojianan 2019-04-16 06:54:27 UTC 
Verified on version:
libvirt-4.5.0-12.virtcov.el7.x86_64

Step:
# man virsh 
....
       pool-create-as name type [--source-host hostname] [--source-path path] [--source-dev path]
       [--source-name name] [--target path] [--source-format format] [--auth-type authtype --auth-username
       username [--secret-usage usage | --secret-uuid uuid]] [[--adapter-name name] | [--adapter-wwnn wwnn
       --adapter-wwpn wwpn] [--adapter-parent parent | --adapter-parent-wwnn parent_wwnn adapter-parent-
       wwpn parent_wwpn | --adapter-parent-fabric-wwn parent_fabric_wwn]] [--build] [[--overwrite] |
       [--no-overwrite]] [--print-xml]
....
           [--adapter-wwnn wwnn --adapter-wwpn wwpn [--adapter-parent parent | --adapter-parent-wwnn
           parent_wwnn adapter-parent-wwpn parent_wwpn | --adapter-parent-fabric-wwn parent_fabric_wwn]]
           defines the wwnn and wwpn to be used for the fc_host adapter type pool.  Optionally provide the
           parent scsi_hostN node device to be used for the vHBA either by parent name, parent_wwnn and
           parent_wwpn, or parent_fabric_wwn.  The parent name could change between reboots if the
           hardware environment changes, so providing the parent_wwnn and parent_wwpn ensure usage of the
           same physical HBA even if the scsi_hostN node device changes. Usage of the parent_fabric_wwn
           allows a bit more flexibility to choose an HBA on the same storage fabric in order to define
           the pool.

Show as expected
Comment 11 errata-xmlrpc 2019-08-06 13:13:56 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:2294
Note You need to log in before you can comment on or make changes to this bug.