Bug 1615913

licensecheck is too long to paste it as a comment, adding it as an attachment. 

License is correct: Apache v2.0

Created attachment 1476374 [details]
licensecheck

I'd propose following naming:

main package: openstack-rally-plugins
Subpackage with python module only python2-rally-openstack
openstack-rally-plugins would contain all non-python stuff and would depend on python2-rally-openstack.

I'll take care of running fedora-review, using the followint SRPM from the Gerrit review: https://logs.rdoproject.org/07/16107/9/check/legacy-DLRN-rpmbuild/c775645/buildset/centos/repos/current/openstack-rally-plugins-1.2.1-0.20180913090746.430cf06.el7.src.rpm

Review notes:

- The notes about Source0 tarball generation and %define requiring justification are expected, since the SRPM was generated by DLRN.

- There is no issue with the CC 3.0 content, it is just specs that are not packaged.

The package is APPROVED.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "*No copyright* CC by (v3.0)", "Unknown or
     generated", "*No copyright* Apache (v2.0)". 1045 files have unknown
     license. Detailed output of licensecheck in /tmp/openstack-rally-
     plugins/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     openstack-rally-plugins-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define upstream_version
     1.2.1.dev34
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: openstack-rally-plugins-1.2.1-0.20180913090746.430cf06.el7.noarch.rpm
          openstack-rally-plugins-doc-1.2.1-0.20180913090746.430cf06.el7.noarch.rpm
          openstack-rally-plugins-1.2.1-0.20180913090746.430cf06.el7.src.rpm
openstack-rally-plugins.noarch: E: no-changelogname-tag
openstack-rally-plugins.noarch: W: no-documentation
openstack-rally-plugins-doc.noarch: E: no-changelogname-tag
openstack-rally-plugins.src: E: no-changelogname-tag
openstack-rally-plugins.src: W: invalid-url Source0: rally-openstack-1.2.1.dev34-0.20180913090746.430cf06.tar.gz
3 packages and 0 specfiles checked; 3 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
openstack-rally-plugins.noarch: E: no-changelogname-tag
openstack-rally-plugins.noarch: W: invalid-url URL: https://rally.readthedocs.io <urlopen error [Errno -2] Name or service not known>
openstack-rally-plugins.noarch: W: no-documentation
openstack-rally-plugins-doc.noarch: E: no-changelogname-tag
openstack-rally-plugins-doc.noarch: W: invalid-url URL: https://rally.readthedocs.io <urlopen error [Errno -2] Name or service not known>
2 packages and 0 specfiles checked; 2 errors, 3 warnings.



Requires
--------
openstack-rally-plugins (rpmlib, GLIBC filtered):
    python(abi)
    python2-boto
    python2-ceilometerclient
    python2-cinderclient
    python2-designateclient
    python2-glanceclient
    python2-gnocchiclient
    python2-heatclient
    python2-ironicclient
    python2-keystoneauth1
    python2-keystoneclient
    python2-kubernetes
    python2-magnumclient
    python2-manilaclient
    python2-mistralclient
    python2-monascaclient
    python2-muranoclient
    python2-neutronclient
    python2-novaclient
    python2-octaviaclient
    python2-os-faults
    python2-osprofiler
    python2-rally
    python2-requests
    python2-saharaclient
    python2-senlinclient
    python2-swiftclient
    python2-troveclient
    python2-zaqarclient

openstack-rally-plugins-doc (rpmlib, GLIBC filtered):



Provides
--------
openstack-rally-plugins:
    openstack-rally-plugins

openstack-rally-plugins-doc:
    openstack-rally-plugins-doc



Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m dlrn -n openstack-rally-plugins -r
Buildroot used: dlrn-centos7-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

The package has been present in RDO Trunk for a while, closing the bug.