Bug 161598 - sr_open: remove random call to scsi_cd_put
Summary: sr_open: remove random call to scsi_cd_put
Alias: None
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: kernel
Version: 4.0
Hardware: i686
OS: Linux
Target Milestone: ---
: ---
Assignee: Doug Ledford
QA Contact: Brian Brock
Depends On:
TreeView+ depends on / blocked
Reported: 2005-06-24 18:42 UTC by nate.dailey
Modified: 2008-10-02 13:59 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2008-10-02 13:59:02 UTC
Target Upstream Version:

Attachments (Terms of Use)

Description nate.dailey 2005-06-24 18:42:49 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2

Description of problem:
This patch removes a call to scsi_cd_put from the error_out section of sr_open. I don't know why this is in there, but it seems like a bad idea (and it's not there in the latest kernel.org kernel).

--- sr.c.orig   2005-06-24 14:39:38.000000000 -0400
+++ sr.c        2005-06-24 14:40:18.000000000 -0400
@@ -544,7 +544,6 @@ static int sr_open(struct cdrom_device_i
        return 0;

-       scsi_cd_put(cd);
        return retval;

Version-Release number of selected component (if applicable):

How reproducible:
Didn't try

Steps to Reproduce:

Additional info:

Comment 1 Doug Ledford 2008-10-02 13:59:02 UTC
This was fixed some time ago and doesn't exist in the current tree, so closing as NOTABUG (I would use CURRENTRELEASE, but they want to know *what* release it was fixed in for that and I don't have that answer, I just know it's fixed now).

Note You need to log in before you can comment on or make changes to this bug.