When refactoring Transformation - PowerOn method, we made it generic by checking in which phase we are: either transformation, or cleanup. We do it by checking whether we have service_template_transformation_plan_task or service_template_plan_task_id as attribute of $evm.root. However, both attributes are really close in spelling and the check doesn't express the intent.
It would be great to add an attribute to the transformation state machines to explicitly state that it is a transformation or cleanup state machine. This would ease the check in methods that can be used in both phases.
Associated PR: https://github.com/ManageIQ/manageiq-content/pull/402
I validated that following Attributes and Values are present in Automate code on 188.8.131.52:
1. The state machines in /Transformation/StateMachines/VMTransformation have an attribute name 'state_machine_phase'
2. This attribute for state machine /Transformation/StateMachines/VMTransformation/Transformation has a value of 'transformation'
3. This attribute for state machine /Transformation/StateMachines/VMTransformation/TransformationCleanup has a value of 'cleanup'