Bug 1616327
| Summary: | UI plugin contributed buttons in main view aren't reflected into detail view | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Vojtech Szocs <vszocs> | ||||||||
| Component: | Frontend.WebAdmin | Assignee: | biakymet | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Petr Matyáš <pmatyas> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | future | CC: | biakymet, bugs, gshereme, lleistne, sgratch, vszocs | ||||||||
| Target Milestone: | ovirt-4.3.5 | Flags: | rule-engine:
ovirt-4.3+
lleistne: testing_ack+ |
||||||||
| Target Release: | 4.3.5.2 | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | ovirt-engine-4.3.5.2 | Doc Type: | If docs needed, set a value | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2019-07-30 14:08:04 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | UX | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Vojtech Szocs
2018-08-15 15:25:40 UTC
Created attachment 1476184 [details]
main view - custom button is present
Created attachment 1476186 [details]
detail view - custom button is missing
Vojtech, can you roughly estimate how difficult this would be to fix? (In reply to Greg Sheremeta from comment #3) > Vojtech, can you roughly estimate how difficult this would be to fix? ETA ~1 day to fix, details follow. Looking at the code, there are two separate <Entity>ActionPanelPresenterWidget instances, one used in main view and another one used in detail view. Taking Cluster as an example, the main view renders all buttons as-is (first ActionPanel instance unchanged), while the detail view removes the "New" button (second ActionPanel instance modified): // in ClusterSubTabPanelView constructor actionPanel.removeButton(actionPanel.getNewButtonDefinition()); When a UI plugin adds new button to the given main view, only the first ActionPanel instance is updated. To fix this, we should either ensure that given button is added to both ActionPanel instances, or bind ActionPanel for given <Entity> as singleton and have it return two logical button representations, one for main and one for detail. Created attachment 1521664 [details]
Test UI plugin
I've attached a test UI plugin that can be used to verify this bug. To apply this plugin, extract the files to /usr/share/ovirt-engine/ui-plugins directory and reload WebAdmin UI. (There's no need to restart Engine.) Navigate to Compute/DataCenters and notice two test buttons (first one represented as a regular button, second one represented as a kebab menu item). Then, click some DC name to navigate to its details and notice that those two test buttons are still accessible in the top-right panel. This bug has not been marked as blocker for oVirt 4.3.0. Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1. I have ovirt-engine-4.3.5.1-0.1.el7.noarch and I can see the buttons from given ui plugin in DC overview however I can't find them anywhere in detail view of any DC detail view. Is the fix included in 4.3.5.2? Verified on ovirt-engine-4.3.5.2-0.1.el7.noarch This bugzilla is included in oVirt 4.3.5 release, published on July 30th 2019. Since the problem described in this bug report should be resolved in oVirt 4.3.5 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |